[GitHub] [airflow] potiuk commented on a diff in pull request #24399: Upgrade FAB to 4.1.1

[GitBox <gi...@apache.org>]

potiuk commented on code in PR #24399:
URL: https://github.com/apache/airflow/pull/24399#discussion_r901473144


##########
tests/www/views/test_views_log.py:
##########
@@ -461,7 +461,7 @@ def test_redirect_to_external_log_with_local_log_handler(log_admin_client, task_
     )
     response = log_admin_client.get(url)
     assert 302 == response.status_code
-    assert 'http://localhost/home' == response.headers['Location']
+    assert '/home' == response.headers['Location']

Review Comment:
   I tihnk not - it will work in general - it will only redirect using path rather than full URL, I guess in any browser it will be treated properly and redirection will work as the browser will automatically pre-pend the host if it's the same as previously. 
   
   I can't imagine scenario where it will create a problem (unless I am mistaken about the circumstances of this different Flask behaviour)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org