You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/06/24 12:16:59 UTC
[GitHub] [servicecomb-website] liubao68 opened a new pull request #272: update release guide and fix navigation error
liubao68 opened a new pull request #272:
URL: https://github.com/apache/servicecomb-website/pull/272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-website] liubao68 commented on a change in pull request #272: update release guide and fix navigation error
Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #272:
URL: https://github.com/apache/servicecomb-website/pull/272#discussion_r658654920
##########
File path: script/release
##########
@@ -1,7 +1,28 @@
#!/bin/sh
-#push a release to branch asf-site
+## publish website steps
+CUR_DIR=$PWD
-bundle update
+## downlowd code
+git clone https://github.com/apache/servicecomb-website.git servicecomb-website-master
+cp -R servicecomb-website-master servicecomb-website-publish
+git clone https://github.com/huaweicse/servicecomb-java-chassis-doc.git
-git push origin asf-site
+## build source
+cd $CUR_DIR/servicecomb-website-master
+git checkout -f master
+bundle exec jekyll build
+
+## copy complied files
+cd $CUR_DIR/servicecomb-website-publish
+git checkout -B liubao -t origin/asf-site
Review comment:
The push step is commented, and the publisher should use this step to commit changes and create a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-website] liubao68 merged pull request #272: update release guide and fix navigation error
Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #272:
URL: https://github.com/apache/servicecomb-website/pull/272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-website] WillemJiang commented on a change in pull request #272: update release guide and fix navigation error
Posted by GitBox <gi...@apache.org>.
WillemJiang commented on a change in pull request #272:
URL: https://github.com/apache/servicecomb-website/pull/272#discussion_r658352760
##########
File path: script/release
##########
@@ -1,7 +1,28 @@
#!/bin/sh
-#push a release to branch asf-site
+## publish website steps
+CUR_DIR=$PWD
-bundle update
+## downlowd code
+git clone https://github.com/apache/servicecomb-website.git servicecomb-website-master
+cp -R servicecomb-website-master servicecomb-website-publish
+git clone https://github.com/huaweicse/servicecomb-java-chassis-doc.git
-git push origin asf-site
+## build source
+cd $CUR_DIR/servicecomb-website-master
+git checkout -f master
+bundle exec jekyll build
+
+## copy complied files
+cd $CUR_DIR/servicecomb-website-publish
+git checkout -B liubao -t origin/asf-site
+rm -R content/*
+mkdir content/references
+cp -R $CUR_DIR/servicecomb-website-master/content/* ./content/
+cp -R $CUR_DIR/servicecomb-java-chassis-doc/docs/* ./content/references/
Review comment:
It's better to add links to the reference, as we have other docs need to link such as kie.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-website] liubao68 commented on a change in pull request #272: update release guide and fix navigation error
Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #272:
URL: https://github.com/apache/servicecomb-website/pull/272#discussion_r658654341
##########
File path: script/release
##########
@@ -1,7 +1,28 @@
#!/bin/sh
-#push a release to branch asf-site
+## publish website steps
+CUR_DIR=$PWD
-bundle update
+## downlowd code
+git clone https://github.com/apache/servicecomb-website.git servicecomb-website-master
+cp -R servicecomb-website-master servicecomb-website-publish
+git clone https://github.com/huaweicse/servicecomb-java-chassis-doc.git
-git push origin asf-site
+## build source
+cd $CUR_DIR/servicecomb-website-master
+git checkout -f master
+bundle exec jekyll build
+
+## copy complied files
+cd $CUR_DIR/servicecomb-website-publish
+git checkout -B liubao -t origin/asf-site
+rm -R content/*
+mkdir content/references
+cp -R $CUR_DIR/servicecomb-website-master/content/* ./content/
+cp -R $CUR_DIR/servicecomb-java-chassis-doc/docs/* ./content/references/
Review comment:
Folder can not use symbolic link. This way is the best option that can use now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-website] WillemJiang commented on a change in pull request #272: update release guide and fix navigation error
Posted by GitBox <gi...@apache.org>.
WillemJiang commented on a change in pull request #272:
URL: https://github.com/apache/servicecomb-website/pull/272#discussion_r658352142
##########
File path: script/release
##########
@@ -1,7 +1,28 @@
#!/bin/sh
-#push a release to branch asf-site
+## publish website steps
+CUR_DIR=$PWD
-bundle update
+## downlowd code
+git clone https://github.com/apache/servicecomb-website.git servicecomb-website-master
+cp -R servicecomb-website-master servicecomb-website-publish
+git clone https://github.com/huaweicse/servicecomb-java-chassis-doc.git
-git push origin asf-site
+## build source
+cd $CUR_DIR/servicecomb-website-master
+git checkout -f master
+bundle exec jekyll build
+
+## copy complied files
+cd $CUR_DIR/servicecomb-website-publish
+git checkout -B liubao -t origin/asf-site
Review comment:
It can be changed to the website repo and the committer has the right to push the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org