You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nutch.apache.org by eh...@apache.org on 2005/07/21 14:59:07 UTC
svn commit: r220056 -
/lucene/nutch/trunk/src/test/org/apache/nutch/plugin/TestPluginSystem.java
Author: ehatcher
Date: Thu Jul 21 05:59:07 2005
New Revision: 220056
URL: http://svn.apache.org/viewcvs?rev=220056&view=rev
Log:
correct misspelling of getExtensions()
Modified:
lucene/nutch/trunk/src/test/org/apache/nutch/plugin/TestPluginSystem.java
Modified: lucene/nutch/trunk/src/test/org/apache/nutch/plugin/TestPluginSystem.java
URL: http://svn.apache.org/viewcvs/lucene/nutch/trunk/src/test/org/apache/nutch/plugin/TestPluginSystem.java?rev=220056&r1=220055&r2=220056&view=diff
==============================================================================
--- lucene/nutch/trunk/src/test/org/apache/nutch/plugin/TestPluginSystem.java (original)
+++ lucene/nutch/trunk/src/test/org/apache/nutch/plugin/TestPluginSystem.java Thu Jul 21 05:59:07 2005
@@ -95,7 +95,7 @@
.getExtensionPoint(xpId);
assertEquals(extensionPoint, null);
Extension[] extension1 = PluginRepository.getInstance()
- .getExtensionPoint(getGetExtensionId()).getExtentens();
+ .getExtensionPoint(getGetExtensionId()).getExtensions();
assertEquals(extension1.length, fPluginCount);
for (int i = 0; i < extension1.length; i++) {
Extension extension2 = extension1[i];
@@ -109,7 +109,7 @@
*/
public void testGetExtensionInstances() throws PluginRuntimeException {
Extension[] extensions = PluginRepository.getInstance()
- .getExtensionPoint(getGetExtensionId()).getExtentens();
+ .getExtensionPoint(getGetExtensionId()).getExtensions();
assertEquals(extensions.length, fPluginCount);
for (int i = 0; i < extensions.length; i++) {
Extension extension = extensions[i];
Re: svn commit: r220056 - /lucene/nutch/trunk/src/test/org/apache/nutch/plugin/TestPluginSystem.java
Posted by Stefan Groschupf <sg...@media-style.com>.
> Oh yes Erik.
> I'm wrong, the mispelled method is in the ExtensionPoint class.
> Since, I think it is not a class that is commonly used outside of
> Nutch,
> you're right, there is no needs to deprecate it.
:-) To late. In any case some one should create a jira issue so we
remember to remove the depreciated method.
I'm sorry that I had created the typo, back in the days I remember I
was writing more mails to discuss the sense of plugins than writing
code. ;)
Erik, thanks for fixing it.
Stefan
Re: svn commit: r220056 - /lucene/nutch/trunk/src/test/org/apache/nutch/plugin/TestPluginSystem.java
Posted by Jérôme Charron <je...@gmail.com>.
> Do you really feel it is necessary to use deprecation in a pre-1.0
> version like this? I'd be happy to add back the old method signature
> and deprecate it, but it seems unnecessary at this stage.
Oh yes Erik.
I'm wrong, the mispelled method is in the ExtensionPoint class.
Since, I think it is not a class that is commonly used outside of Nutch,
you're right, there is no needs to deprecate it.
Sorry
Jerome
--
http://motrech.free.fr/
http://www.frutch.org/
Re: svn commit: r220056 - /lucene/nutch/trunk/src/test/org/apache/nutch/plugin/TestPluginSystem.java
Posted by Erik Hatcher <er...@ehatchersolutions.com>.
On Jul 21, 2005, at 10:22 AM, Erik Hatcher wrote:
>
> On Jul 21, 2005, at 9:21 AM, Jérôme Charron wrote:
>
>
>>> For grins I tried to see if I had commit access to fix the
>>> misspelling myself. Lo and behold I do! I hope I didn't step on any
>>> toes by committing this - if so let me know and I'll be more patient
>>> and submit patches. I'm a newbie to Nutch and definitely don't want
>>> to step in to committing lightly and I'll keep them only at the
>>> minor
>>> fix type of level if at all.
>>>
>>>
>>
>> Erik,
>>
>> I don't look inside the modifications you have commited, but do
>> you have
>> replaced the misspelled method, or add a new one (and deprecate the
>> misspelled one).
>> Since, it is an API that can be used by code that is outside of
>> the nutch
>> code, it is better to deprecate such methods.
>>
>
> Do you really feel it is necessary to use deprecation in a pre-1.0
> version like this? I'd be happy to add back the old method
> signature and deprecate it, but it seems unnecessary at this stage.
Just to ensure this isn't an issue, I went ahead and added the old
method name back and deprecated it. This should be removed in the
1.0 release, or perhaps another pre-1.0 release.
Erik
Re: svn commit: r220056 - /lucene/nutch/trunk/src/test/org/apache/nutch/plugin/TestPluginSystem.java
Posted by Erik Hatcher <er...@ehatchersolutions.com>.
On Jul 21, 2005, at 9:21 AM, Jérôme Charron wrote:
>> For grins I tried to see if I had commit access to fix the
>> misspelling myself. Lo and behold I do! I hope I didn't step on any
>> toes by committing this - if so let me know and I'll be more patient
>> and submit patches. I'm a newbie to Nutch and definitely don't want
>> to step in to committing lightly and I'll keep them only at the minor
>> fix type of level if at all.
>>
>
> Erik,
>
> I don't look inside the modifications you have commited, but do you
> have
> replaced the misspelled method, or add a new one (and deprecate the
> misspelled one).
> Since, it is an API that can be used by code that is outside of the
> nutch
> code, it is better to deprecate such methods.
Do you really feel it is necessary to use deprecation in a pre-1.0
version like this? I'd be happy to add back the old method signature
and deprecate it, but it seems unnecessary at this stage.
Erik
Re: svn commit: r220056 - /lucene/nutch/trunk/src/test/org/apache/nutch/plugin/TestPluginSystem.java
Posted by Jérôme Charron <je...@gmail.com>.
> For grins I tried to see if I had commit access to fix the
> misspelling myself. Lo and behold I do! I hope I didn't step on any
> toes by committing this - if so let me know and I'll be more patient
> and submit patches. I'm a newbie to Nutch and definitely don't want
> to step in to committing lightly and I'll keep them only at the minor
> fix type of level if at all.
Erik,
I don't look inside the modifications you have commited, but do you have
replaced the misspelled method, or add a new one (and deprecate the
misspelled one).
Since, it is an API that can be used by code that is outside of the nutch
code, it is better to deprecate such methods.
regards
Jerome
--
http://motrech.free.fr/
http://www.frutch.org/
Fwd: svn commit: r220056 - /lucene/nutch/trunk/src/test/org/apache/nutch/plugin/TestPluginSystem.java
Posted by Erik Hatcher <er...@ehatchersolutions.com>.
For grins I tried to see if I had commit access to fix the
misspelling myself. Lo and behold I do! I hope I didn't step on any
toes by committing this - if so let me know and I'll be more patient
and submit patches. I'm a newbie to Nutch and definitely don't want
to step in to committing lightly and I'll keep them only at the minor
fix type of level if at all.
Erik
Begin forwarded message:
> From: ehatcher@apache.org
> Date: July 21, 2005 8:59:07 AM EDT
> To: nutch-cvs@incubator.apache.org
> Subject: svn commit: r220056 - /lucene/nutch/trunk/src/test/org/
> apache/nutch/plugin/TestPluginSystem.java
> Reply-To: nutch-dev@lucene.apache.org
>
>
> Author: ehatcher
> Date: Thu Jul 21 05:59:07 2005
> New Revision: 220056
>
> URL: http://svn.apache.org/viewcvs?rev=220056&view=rev
> Log:
> correct misspelling of getExtensions()
>
> Modified:
> lucene/nutch/trunk/src/test/org/apache/nutch/plugin/
> TestPluginSystem.java
>
> Modified: lucene/nutch/trunk/src/test/org/apache/nutch/plugin/
> TestPluginSystem.java
> URL: http://svn.apache.org/viewcvs/lucene/nutch/trunk/src/test/org/
> apache/nutch/plugin/TestPluginSystem.java?
> rev=220056&r1=220055&r2=220056&view=diff
> ======================================================================
> ========
> --- lucene/nutch/trunk/src/test/org/apache/nutch/plugin/
> TestPluginSystem.java (original)
> +++ lucene/nutch/trunk/src/test/org/apache/nutch/plugin/
> TestPluginSystem.java Thu Jul 21 05:59:07 2005
> @@ -95,7 +95,7 @@
> .getExtensionPoint(xpId);
> assertEquals(extensionPoint, null);
> Extension[] extension1 = PluginRepository.getInstance()
> - .getExtensionPoint(getGetExtensionId
> ()).getExtentens();
> + .getExtensionPoint(getGetExtensionId
> ()).getExtensions();
> assertEquals(extension1.length, fPluginCount);
> for (int i = 0; i < extension1.length; i++) {
> Extension extension2 = extension1[i];
> @@ -109,7 +109,7 @@
> */
> public void testGetExtensionInstances() throws
> PluginRuntimeException {
> Extension[] extensions = PluginRepository.getInstance()
> - .getExtensionPoint(getGetExtensionId
> ()).getExtentens();
> + .getExtensionPoint(getGetExtensionId
> ()).getExtensions();
> assertEquals(extensions.length, fPluginCount);
> for (int i = 0; i < extensions.length; i++) {
> Extension extension = extensions[i];
>
>