You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2023/01/18 09:59:33 UTC

[GitHub] [hbase] Apache9 commented on a diff in pull request #4935: HBASE-27543 May be miss data when use mob

Apache9 commented on code in PR #4935:
URL: https://github.com/apache/hbase/pull/4935#discussion_r1073325006


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java:
##########
@@ -216,8 +216,9 @@ private FileDetails getFileDetails(Collection<HStoreFile> filesToCompact, boolea
         }
       }
       tmp = fileInfo.get(TIMERANGE_KEY);
-      fd.latestPutTs =
+      long latestPutTs =
         tmp == null ? HConstants.LATEST_TIMESTAMP : TimeRangeTracker.parseFrom(tmp).getMax();
+      fd.latestPutTs = Math.max(fd.latestPutTs, latestPutTs);

Review Comment:
   Check  the code, we do not assign any value to fd.latestPutTs, so what is the actual problem here? The latestPutTs info for bulk loaded files can not negative and cause problem?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org