You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/08 14:00:06 UTC

[GitHub] [kafka] lkokhreidze commented on a change in pull request #10802: KAFKA-6718 / Part1: Update SubscriptionInfoData with clientTags

lkokhreidze commented on a change in pull request #10802:
URL: https://github.com/apache/kafka/pull/10802#discussion_r647470689



##########
File path: streams/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java
##########
@@ -161,8 +162,8 @@ public ByteBuffer subscriptionUserData(final Set<String> topics) {
                     userEndPoint(),
                     taskManager.getTaskOffsetSums(),
                     uniqueField,
-                    0
-                ).encode();
+                    0,
+                    Collections.emptyMap()).encode();

Review comment:
       Makes sense. Added non-empty map as a static final field.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org