You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/08/25 16:32:55 UTC
[GitHub] [ozone] siddhantsangwan opened a new pull request #2577: HDDS-5670. ContainerBalancer should get OzoneConfiguration from Conta…
siddhantsangwan opened a new pull request #2577:
URL: https://github.com/apache/ozone/pull/2577
…inerBalancerConfiguration.
## What changes were proposed in this pull request?
Currently, ContainerBalancer creates a new OzoneConfiguration in ContainerBalancer#start and uses that. Instead, it should get the OzoneConfiguration object from ContainerBalancerConfiguration.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5670
## How was this patch tested?
TestContainerBalancer UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] siddhantsangwan commented on pull request #2577: HDDS-5670. ContainerBalancer should get OzoneConfiguration from Conta…
Posted by GitBox <gi...@apache.org>.
siddhantsangwan commented on pull request #2577:
URL: https://github.com/apache/ozone/pull/2577#issuecomment-906934207
@lokeshj1703 @JacksonYao287 please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] siddhantsangwan commented on pull request #2577: HDDS-5670. ContainerBalancer should get OzoneConfiguration from Conta…
Posted by GitBox <gi...@apache.org>.
siddhantsangwan commented on pull request #2577:
URL: https://github.com/apache/ozone/pull/2577#issuecomment-915121998
@JacksonYao287 thanks for the review! I've updated according to your comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] lokeshj1703 merged pull request #2577: HDDS-5670. ContainerBalancer should get OzoneConfiguration from ContainerBalancerConfiguration.
Posted by GitBox <gi...@apache.org>.
lokeshj1703 merged pull request #2577:
URL: https://github.com/apache/ozone/pull/2577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] lokeshj1703 commented on pull request #2577: HDDS-5670. ContainerBalancer should get OzoneConfiguration from ContainerBalancerConfiguration.
Posted by GitBox <gi...@apache.org>.
lokeshj1703 commented on pull request #2577:
URL: https://github.com/apache/ozone/pull/2577#issuecomment-915802133
@siddhantsangwan Thanks for the contribution! @JacksonYao287 Thanks for the review! I have committed the PR to master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] JacksonYao287 commented on a change in pull request #2577: HDDS-5670. ContainerBalancer should get OzoneConfiguration from Conta…
Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on a change in pull request #2577:
URL: https://github.com/apache/ozone/pull/2577#discussion_r700792962
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerConfiguration.java
##########
@@ -111,10 +111,14 @@
*/
public ContainerBalancerConfiguration(
OzoneConfiguration ozoneConfiguration) {
- this.ozoneConfiguration = ozoneConfiguration;
+ if (ozoneConfiguration == null) {
Review comment:
actually, ozoneConfiguration should not be null. we'd better to use `Preconditions.checkNotNull` instead here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org