You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by Anh3h <gi...@git.apache.org> on 2017/08/23 06:32:36 UTC
[GitHub] fineract pull request #405: Notification sub-system
GitHub user Anh3h opened a pull request:
https://github.com/apache/fineract/pull/405
Notification sub-system
Work done:
- [x] User subscription to topic on user creation
- [x] Topic creation on entity creation
- [x] Upgrade process of user notification
- [x] Migration script - topic, topic subscription models for new and already existing users and entities
- [x] Update user subscription on user transfer and/or update of user's permission
- [x] Update topic details when entity details updates
- [x] Update topic details when member type are updated at the system level
- [x] Unit test topic-subscriber model
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Anh3h/fineract notification_module
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/fineract/pull/405.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #405
----
commit 5a3c2322f9e8d302a59eb2d9c48055d3f186a576
Author: Anh3h <co...@gmail.com>
Date: 2017-08-23T06:27:57Z
Notification sub-system
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] fineract issue #405: Notification sub-system
Posted by Anh3h <gi...@git.apache.org>.
Github user Anh3h commented on the issue:
https://github.com/apache/fineract/pull/405
Hi @avikganguly01, to manually test the system, you can follow the sample use case i stated. but the steps differ slightly for difference events like:
New Client Created
New Loan Created
New Loan Approved
New Share Account Created
New Share Account Approved
New Savings Account Created
New Savings Account Approved
New Fixed Deposit Account Created
---
[GitHub] fineract issue #405: Notification sub-system
Posted by Anh3h <gi...@git.apache.org>.
Github user Anh3h commented on the issue:
https://github.com/apache/fineract/pull/405
Ok. Will do that
On Sep 22, 2017 11:44 AM, "Shaik Nazeer Hussain" <no...@github.com>
wrote:
@Anh3h <https://github.com/anh3h> Can you share me the requirements/use
cases so that it will be helpful while reviewing the code.
It's better to create a jira issue and put all the details.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/apache/fineract/pull/405#issuecomment-331414438>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ATnCGtyLVB8hat6gFdQAiY24ILKf22aMks5sk4-YgaJpZM4O_jfz>
.
---
[GitHub] fineract issue #405: Notification sub-system
Posted by Anh3h <gi...@git.apache.org>.
Github user Anh3h commented on the issue:
https://github.com/apache/fineract/pull/405
OKay
---
[GitHub] fineract issue #405: Notification sub-system
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/405
@Anh3h Can you share me the requirements/use cases so that it will be helpful while reviewing the code.
It's better to create a jira issue and put all the details.
---
[GitHub] fineract pull request #405: Notification sub-system
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/fineract/pull/405
---
[GitHub] fineract issue #405: Notification sub-system
Posted by Anh3h <gi...@git.apache.org>.
Github user Anh3h commented on the issue:
https://github.com/apache/fineract/pull/405
Hi @nazeer1100126 sorry for the delayed reply, my computer crashed so I needed some time to bring back to life :). Here is the issue I created https://issues.apache.org/jira/browse/FINERACT-527
---
[GitHub] fineract issue #405: Notification sub-system
Posted by avikganguly01 <gi...@git.apache.org>.
Github user avikganguly01 commented on the issue:
https://github.com/apache/fineract/pull/405
Hi @Anh3h , would it be possible for you to update Fineract-527 with detailed test cases so that it can be manually tested in absence of integration / e2e tests?
---