[GitHub] [iceberg] rdblue commented on a change in pull request #3643: API: Fix typo in dropNamespace javadoc

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #3643:
URL: https://github.com/apache/iceberg/pull/3643#discussion_r763444662



##########
File path: api/src/main/java/org/apache/iceberg/catalog/SupportsNamespaces.java
##########
@@ -100,7 +100,7 @@ default void createNamespace(Namespace namespace) {
    *
    * @param namespace a namespace. {@link Namespace}
    * @return true if the namespace was dropped, false otherwise.
-   * @throws NamespaceNotEmptyException If the namespace does not empty
+   * @throws NamespaceNotEmptyException If the namespace is not empty

Review comment:
       I think it is pretty clear what empty means -- it has tables or nested namespaces. I think the "and contains tables" wording is actually less clear because it makes it sound like containing tables is distinct from being not empty, like a separate requirement. We could probably fix that up with "that is, if it contains tables or nested namespaces"... but again, I think it's reasonably clear. Maybe I'm wrong, so if anyone else agrees that we should clarify please reply!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org