You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/25 12:08:00 UTC
[jira] [Commented] (FLINK-9041) Refactor StreamTaskTest to not use
scala and akka
[ https://issues.apache.org/jira/browse/FLINK-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452127#comment-16452127 ]
ASF GitHub Bot commented on FLINK-9041:
---------------------------------------
GitHub user azagrebin opened a pull request:
https://github.com/apache/flink/pull/5912
[FLINK-9041] Refactor StreamTaskTest to not use scala and akka
## What is the purpose of the change
Get rid of scala/akka dependency in StreamTaskTest
## Brief change log
`StreamTaskTest.testEarlyCanceling()` and `StreamTaskTest.TestingExecutionStateListener` are refactored to use java 8 `CompletableFuture` instead of scala `Promise`
## Verifying this change
This change is already covered by existing tests, as it just refactors them.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes: javassist 3.18.2-GA to 3.19.0-GA - [reason](https://github.com/powermock/powermock/issues/729))
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/azagrebin/flink FLINK-9041
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5912.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5912
----
commit 0b119c931fd3e0c83eaaa4d858b775b57cc41d3b
Author: Andrey Zagrebin <an...@...>
Date: 2018-04-25T09:02:09Z
[FLINK-9041] Refactor StreamTaskTest to use java 8 CompletableFuture instead of scala/akka Promise
----
> Refactor StreamTaskTest to not use scala and akka
> -------------------------------------------------
>
> Key: FLINK-9041
> URL: https://issues.apache.org/jira/browse/FLINK-9041
> Project: Flink
> Issue Type: Improvement
> Components: Streaming, Tests
> Affects Versions: 1.5.0
> Reporter: Chesnay Schepler
> Assignee: Sihua Zhou
> Priority: Trivial
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)