You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by el...@apache.org on 2021/12/11 01:09:34 UTC

[superset] branch 1.4 updated (9908163 -> 2e0fe93)

This is an automated email from the ASF dual-hosted git repository.

elizabeth pushed a change to branch 1.4
in repository https://gitbox.apache.org/repos/asf/superset.git.


 discard 9908163  fix prettier/lint error
     new 2e0fe93  fix prettier/lint error

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (9908163)
            \
             N -- N -- N   refs/heads/1.4 (2e0fe93)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../dashboard/components/PropertiesModal/index.tsx |  8 +++-
 .../explore/components/PropertiesModal/index.tsx   | 47 ++++++++++------------
 2 files changed, 28 insertions(+), 27 deletions(-)

[superset] 01/01: fix prettier/lint error

Posted by el...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

elizabeth pushed a commit to branch 1.4
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 2e0fe9326998f35103be9b197c7d10b00a09f1c1
Author: Elizabeth Thompson <es...@gmail.com>
AuthorDate: Fri Dec 10 16:43:17 2021 -0800

    fix prettier/lint error
---
 .../src/dashboard/components/PropertiesModal/index.tsx            | 8 ++++++--
 .../src/explore/components/PropertiesModal/index.tsx              | 6 +++++-
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/superset-frontend/src/dashboard/components/PropertiesModal/index.tsx b/superset-frontend/src/dashboard/components/PropertiesModal/index.tsx
index 6f9c723..7e7ad24 100644
--- a/superset-frontend/src/dashboard/components/PropertiesModal/index.tsx
+++ b/superset-frontend/src/dashboard/components/PropertiesModal/index.tsx
@@ -273,8 +273,12 @@ const PropertiesModal = ({
   };
 
   const onFinish = () => {
-    const { title, slug, certifiedBy, certificationDetails } =
-      form.getFieldsValue();
+    const {
+      title,
+      slug,
+      certifiedBy,
+      certificationDetails,
+    } = form.getFieldsValue();
     let currentColorScheme = colorScheme;
     let colorNamespace = '';
 
diff --git a/superset-frontend/src/explore/components/PropertiesModal/index.tsx b/superset-frontend/src/explore/components/PropertiesModal/index.tsx
index 6b50d2b..6dbf866 100644
--- a/superset-frontend/src/explore/components/PropertiesModal/index.tsx
+++ b/superset-frontend/src/explore/components/PropertiesModal/index.tsx
@@ -89,7 +89,11 @@ export default function PropertiesModal({
 
   const loadOptions = useMemo(
     () => (input = '', page: number, pageSize: number) => {
-      const query = rison.encode({ filter: input, page, page_size: pageSize });
+      const query = rison.encode({
+        filter: input,
+        page,
+        page_size: pageSize,
+      });
       return SupersetClient.get({
         endpoint: `/api/v1/chart/related/owners?q=${query}`,
       }).then(response => ({