You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/05/20 22:33:07 UTC

Review Request 21727: Fixed pointer ownership bug in Authorizer.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21727/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Repository: mesos-git


Description
-------

Also took the chance to do a minor fix in ACLs protobuf.


Diffs
-----

  include/mesos/mesos.proto 8012873f853fdee47f8cb2f5d9dbb7cd8ccc6028 
  src/authorizer/authorizer.hpp 75b5a33cc2d83016598e5858d537ce1106784b41 

Diff: https://reviews.apache.org/r/21727/diff/


Testing
-------

make check


Thanks,

Vinod Kone

Re: Review Request 21727: Fixed pointer ownership bug in Authorizer.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21727/#review43669
-----------------------------------------------------------

Ship it!



include/mesos/mesos.proto
<https://reviews.apache.org/r/21727/#comment77959>

    FYI, this sneaked in (it's okay by me, just wanted to let you know).


- Benjamin Hindman


On May 20, 2014, 8:33 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21727/
> -----------------------------------------------------------
> 
> (Updated May 20, 2014, 8:33 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Also took the chance to do a minor fix in ACLs protobuf.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 8012873f853fdee47f8cb2f5d9dbb7cd8ccc6028 
>   src/authorizer/authorizer.hpp 75b5a33cc2d83016598e5858d537ce1106784b41 
> 
> Diff: https://reviews.apache.org/r/21727/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 21727: Fixed pointer ownership bug in Authorizer.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21727/
-----------------------------------------------------------

(Updated May 22, 2014, 12:38 a.m.)


Review request for mesos and Benjamin Hindman.


Changes
-------

rebased. NNFR.


Repository: mesos-git


Description
-------

Also took the chance to do a minor fix in ACLs protobuf.


Diffs (updated)
-----

  include/mesos/mesos.proto 8012873f853fdee47f8cb2f5d9dbb7cd8ccc6028 
  src/authorizer/authorizer.hpp 75b5a33cc2d83016598e5858d537ce1106784b41 

Diff: https://reviews.apache.org/r/21727/diff/


Testing
-------

make check


Thanks,

Vinod Kone