[GitHub] [incubator-doris] caiconghui commented on a change in pull request #6384: [Optimize] Speed up converting the data of other type to string in mysql_result_writer

[GitBox <gi...@apache.org>]

caiconghui commented on a change in pull request #6384:
URL: https://github.com/apache/incubator-doris/pull/6384#discussion_r690086354



##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/Planner.java
##########
@@ -101,9 +101,7 @@ private void setResultExprScale(Analyzer analyzer, ArrayList<Expr> outputExprs)
                             }
 
                     if (slotList.contains(slotDesc.getId()) && null != slotDesc.getColumn()) {
-                        // TODO output scale
-                        // int outputScale = slotDesc.getColumn().getType().getScale();
-                        int outputScale = 10;
+                        int outputScale = slotDesc.getColumn().getScale();

Review comment:
       it is only for decimal, if scale < 0,  be will ignore it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org