[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #840: feature: allow set up header to client in proxy-rewrite, CROS allowed

[GitBox <gi...@apache.org>]

lilien1010 commented on a change in pull request #840: feature: allow set up header to client in proxy-rewrite,CROS allowed
URL: https://github.com/apache/incubator-apisix/pull/840#discussion_r344996411
 
 

 ##########
 File path: doc/plugins/proxy-rewrite.md
 ##########
 @@ -30,6 +30,7 @@ upstream proxy info rewrite plugin.
 |host            |No| Upstream new `host` forwarding address, example `iresty.com`. |
 |enable_websocket|No| enable `websocket`(boolean), default `false`.|
 |headers         |No| Forward to the new `headers` of the upstream, can set up multiple. If it exists, will rewrite the header, otherwise will add the header. You can set the corresponding value to an empty string to remove a header.|
+|resp_headers    |No| set a new to `headers` , and return it to client, can set up multiple. If upstream aleady return the same head field, will rewrite the header, otherwise will add the header.|
 
 Review comment:
   I have the same doubt, I think we can check the value,if it is a empty string ,we can delete the header

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services