You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/03/25 12:16:11 UTC
[GitHub] [incubator-pekko-grpc] mdedetrich opened a new pull request, #53: Update sbt
mdedetrich opened a new pull request, #53:
URL: https://github.com/apache/incubator-pekko-grpc/pull/53
Update sbt version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich merged pull request #53: Update sbt
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #53:
URL: https://github.com/apache/incubator-pekko-grpc/pull/53
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #53: Update sbt
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #53:
URL: https://github.com/apache/incubator-pekko-grpc/pull/53#discussion_r1168047743
##########
project/plugins.sbt:
##########
@@ -21,6 +21,9 @@ addSbtPlugin("org.mdedetrich" % "sbt-apache-sonatype" % "0.1.6")
// allow access to snapshots for pekko-sbt-paradox
resolvers += "Apache Nexus Snapshots".at("https://repository.apache.org/content/repositories/snapshots/")
+// See https://github.com/akka/akka-http/pull/3995 and https://github.com/akka/akka-http/pull/3995#issuecomment-1026978593
Review Comment:
This is necessary because we are getting many conflict `scala-xml` versions from various libraries, this feature was introduced into the latest sbt version. Note that this only applies to the sbt classpath for plugins and not pekko-grpc in general.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on pull request #53: Update sbt
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #53:
URL: https://github.com/apache/incubator-pekko-grpc/pull/53#issuecomment-1483812090
sbt 1.8.2 is more strict and because of this its complaining about some libraries, will check it out later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on pull request #53: Update sbt
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #53:
URL: https://github.com/apache/incubator-pekko-grpc/pull/53#issuecomment-1510514476
PR is now ready to review. One thing to note that is due to pekko-http-cors bringing in an incompatible version of pekko-http (see https://github.com/lomigmegard/pekko-http-cors/blob/2fad65439d2fbf9fa8ef6a63863ca04a179b7b81/build.sbt#L53) I had to make an exclusion rule which can be removed once a proper release of pekko-http and then pekko-http-cors is made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #53: Update sbt
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #53:
URL: https://github.com/apache/incubator-pekko-grpc/pull/53#discussion_r1168047743
##########
project/plugins.sbt:
##########
@@ -21,6 +21,9 @@ addSbtPlugin("org.mdedetrich" % "sbt-apache-sonatype" % "0.1.6")
// allow access to snapshots for pekko-sbt-paradox
resolvers += "Apache Nexus Snapshots".at("https://repository.apache.org/content/repositories/snapshots/")
+// See https://github.com/akka/akka-http/pull/3995 and https://github.com/akka/akka-http/pull/3995#issuecomment-1026978593
Review Comment:
This is necessary because we are getting many conflict `scala-xml` versions from various libraries. Note that this only applies to the sbt classpath for plugins and not pekko-grpc in general.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on pull request #53: Update sbt
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #53:
URL: https://github.com/apache/incubator-pekko-grpc/pull/53#issuecomment-1510818185
> LGTM,better with a //TODO in case forgetting that
I will add TODO's in next PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org