You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/13 11:17:37 UTC
[GitHub] [shardingsphere] tuichenchuxin opened a new issue, #17635: [WeOpen-Star] Support ShardingSphere parser of oracle sql.
tuichenchuxin opened a new issue, #17635:
URL: https://github.com/apache/shardingsphere/issues/17635
Hi community,
This issue is for [WeOpen-Star](https://github.com/apache/shardingsphere/issues/17502)
ref to #6480
### Background
**How is a SQL parsed?**
`SQL definition file`
->(Parse to)
`AST`
->(Visit it)
`SQLStatment`
### Process
1. Compare `SQL definitions` in [Oficial SQL Doc](https://docs.oracle.com/en/database/oracle/oracle-database/18/lnpls/plsql-language-elements.html#GUID-285DFAEE-1A34-4248-BA4B-2591476A0C3C) and [ShardingSphere SQL Doc](https://github.com/apache/shardingsphere/tree/master/shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle)
2. If there is any difference in ShardingSphere SQL Doc, please correct them referring to Official SQL Doc
3. Run `mvn install the current_file_module`
4. Check whether there are any exceptions. If indeed, please fix them. (Especially `xxxVisitor.class`)
5. Add new corresponding SQL case in [SQL Cases](https://github.com/apache/shardingsphere/tree/master/shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sql/supported) and expected parsed result in [Expected Statment XML](https://github.com/apache/shardingsphere/tree/master/shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/resources/case)
6. Run [SQLParserParameterizedTest](https://github.com/apache/shardingsphere/blob/master/shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/engine/SQLParserParameterizedTest.java) to make sure no exceptions.
### Notice
1.`Left recursion` can not work well in Antlr4,
```
a
: b
| a b
;
b
: a c
;
c
: ...
;
```
you can consider the following one,
```
a
: b*
;
b
: a c
;
c
: ...
;
```
2. [Here](https://shimo.im/docs/WrgrCt9JR3JDjq8H/read) is a Chinese version for reference.
### subtask
- [ ] ALTER PROCEDURE [doc](https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/ALTER-PROCEDURE.html#GUID-24A5796F-7D97-49D4-8448-7E541CB73AC6)
- [ ] CREATE PROCEDURE [doc](https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/CREATE-PROCEDURE.html#GUID-771879D8-BBFD-4D87-8A6C-290102142DA3)
- [ ] DROP PROCEDURE [doc](https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/DROP-PROCEDURE.html#GUID-D7F2B5AD-DEEE-466B-B6D3-B765EB897DCB)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuichenchuxin closed issue #17635: [WeOpen-Star] Support ShardingSphere parser of oracle sql.
Posted by GitBox <gi...@apache.org>.
tuichenchuxin closed issue #17635: [WeOpen-Star] Support ShardingSphere parser of oracle sql.
URL: https://github.com/apache/shardingsphere/issues/17635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tianhao960 commented on issue #17635: [WeOpen-Star] Support ShardingSphere parser of oracle sql.
Posted by GitBox <gi...@apache.org>.
tianhao960 commented on issue #17635:
URL: https://github.com/apache/shardingsphere/issues/17635#issuecomment-1218913209
I would like to try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #17635: [WeOpen-Star] Support ShardingSphere parser of oracle sql.
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #17635:
URL: https://github.com/apache/shardingsphere/issues/17635#issuecomment-1218976901
@tianhao960 Welcome, I will assign this issue to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #17635: [WeOpen-Star] Support ShardingSphere parser of oracle sql.
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #17635:
URL: https://github.com/apache/shardingsphere/issues/17635#issuecomment-1212707112
Hi community, this issue still keep open to pick up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tianhao960 commented on issue #17635: [WeOpen-Star] Support ShardingSphere parser of oracle sql.
Posted by GitBox <gi...@apache.org>.
tianhao960 commented on issue #17635:
URL: https://github.com/apache/shardingsphere/issues/17635#issuecomment-1223524972
hi, @tuichenchuxin , I'm sorry that the pull request just fix the create procedure one; I'll post a new pr to fix the alter and drop statement. thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] complone commented on issue #17635: [WeOpen-Star] Support ShardingSphere parser of oracle sql.
Posted by GitBox <gi...@apache.org>.
complone commented on issue #17635:
URL: https://github.com/apache/shardingsphere/issues/17635#issuecomment-1136690586
I want to try this work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org