You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/10/01 00:49:42 UTC

[kudu-CR](branch-1.17.x) [tests] fix failing TestWebUIDoesNotCrashCluster

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21868


Change subject: [tests] fix failing TestWebUIDoesNotCrashCluster
......................................................................

[tests] fix failing TestWebUIDoesNotCrashCluster

Before this patch, the TestWebUIDoesNotCrashCluster scenario of the
webserver-stress-itest was failing if running in an environment where
KUDU_HOME was set and pointed to the correct location of the Kudu
git workspace.  Also, the webserver-stress-itest didn't look like a good
place for such a test.

This is a follow-up to b2514b98c7639c2a328a4dddd8fd9213428b0d4d.

Change-Id: I59b6ef64b522540620bdc622156b3516ada23f5d
Reviewed-on: http://gerrit.cloudera.org:8080/21863
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit c2003752ea9aefaec3e2414abcc23ed05e3de0dd)
---
M src/kudu/integration-tests/webserver-stress-itest.cc
M src/kudu/tserver/tablet_server-test.cc
2 files changed, 12 insertions(+), 16 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/21868/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I59b6ef64b522540620bdc622156b3516ada23f5d
Gerrit-Change-Number: 21868
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR](branch-1.17.x) [tests] fix failing TestWebUIDoesNotCrashCluster

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21868 )

Change subject: [tests] fix failing TestWebUIDoesNotCrashCluster
......................................................................

[tests] fix failing TestWebUIDoesNotCrashCluster

Before this patch, the TestWebUIDoesNotCrashCluster scenario of the
webserver-stress-itest was failing if running in an environment where
KUDU_HOME was set and pointed to the correct location of the Kudu
git workspace.  Also, the webserver-stress-itest didn't look like a good
place for such a test.

This is a follow-up to b2514b98c7639c2a328a4dddd8fd9213428b0d4d.

Change-Id: I59b6ef64b522540620bdc622156b3516ada23f5d
Reviewed-on: http://gerrit.cloudera.org:8080/21863
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit c2003752ea9aefaec3e2414abcc23ed05e3de0dd)
Reviewed-on: http://gerrit.cloudera.org:8080/21868
Tested-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Marton Greber <gr...@gmail.com>
---
M src/kudu/integration-tests/webserver-stress-itest.cc
M src/kudu/tserver/tablet_server-test.cc
2 files changed, 12 insertions(+), 16 deletions(-)

Approvals:
  Marton Greber: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/21868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I59b6ef64b522540620bdc622156b3516ada23f5d
Gerrit-Change-Number: 21868
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>

[kudu-CR](branch-1.17.x) [tests] fix failing TestWebUIDoesNotCrashCluster

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has removed a vote on this change.

Change subject: [tests] fix failing TestWebUIDoesNotCrashCluster
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/21868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I59b6ef64b522540620bdc622156b3516ada23f5d
Gerrit-Change-Number: 21868
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>

[kudu-CR](branch-1.17.x) [tests] fix failing TestWebUIDoesNotCrashCluster

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21868 )

Change subject: [tests] fix failing TestWebUIDoesNotCrashCluster
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/552/


-- 
To view, visit http://gerrit.cloudera.org:8080/21868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I59b6ef64b522540620bdc622156b3516ada23f5d
Gerrit-Change-Number: 21868
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 01 Oct 2024 00:49:56 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [tests] fix failing TestWebUIDoesNotCrashCluster

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21868 )

Change subject: [tests] fix failing TestWebUIDoesNotCrashCluster
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I59b6ef64b522540620bdc622156b3516ada23f5d
Gerrit-Change-Number: 21868
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 01 Oct 2024 15:56:58 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [tests] fix failing TestWebUIDoesNotCrashCluster

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21868 )

Change subject: [tests] fix failing TestWebUIDoesNotCrashCluster
......................................................................


Patch Set 1: Verified+1

unrelated test failures:
release: raft_consensus_election-itest.0
tsan: org.apache.kudu.client.TestSecurity


-- 
To view, visit http://gerrit.cloudera.org:8080/21868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I59b6ef64b522540620bdc622156b3516ada23f5d
Gerrit-Change-Number: 21868
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 01 Oct 2024 15:56:54 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [tests] fix failing TestWebUIDoesNotCrashCluster

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21868 )

Change subject: [tests] fix failing TestWebUIDoesNotCrashCluster
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/552/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/21868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I59b6ef64b522540620bdc622156b3516ada23f5d
Gerrit-Change-Number: 21868
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 01 Oct 2024 03:18:43 +0000
Gerrit-HasComments: No