You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by DivineEnder <gi...@git.apache.org> on 2017/07/10 21:42:17 UTC
[GitHub] geode pull request #622: GEODE-1731: Modifying region size check to be more ...
GitHub user DivineEnder opened a pull request:
https://github.com/apache/geode/pull/622
GEODE-1731: Modifying region size check to be more accurate
Changed the hardcoded 5010 region size check to the size of the region already plus 20 new elements. The 20 new elements is due to the fact that a synchronous call to get the region size of vm2 had to be used, so there should be more time for elements to be put.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DivineEnder/geode feature/GEODE-1731
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/622.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #622
----
commit 10e04c6a035b6ad83ba9bdedc6651eebe177f133
Author: David Anuta <da...@gmail.com>
Date: 2017-07-10T20:05:44Z
GEODE-1731: Modifying region size check to be more accurate
Changed the hardcoded 5010 region size check to the size of the region already plus 20 new elements. The 20 new elements is due to the fact that a synchronous call to get the region size of vm2 had to be used, so there should be more time for elements to be put.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #622: GEODE-1731: Modifying region size check to be more accurat...
Posted by nabarunnag <gi...@git.apache.org>.
Github user nabarunnag commented on the issue:
https://github.com/apache/geode/pull/622
Merging into develop
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #622: GEODE-1731: Modifying region size check to be more accurat...
Posted by ladyVader <gi...@git.apache.org>.
Github user ladyVader commented on the issue:
https://github.com/apache/geode/pull/622
Looks good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #622: GEODE-1731: Modifying region size check to be more ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/622
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #622: GEODE-1731: Modifying region size check to be more accurat...
Posted by DivineEnder <gi...@git.apache.org>.
Github user DivineEnder commented on the issue:
https://github.com/apache/geode/pull/622
@ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---