You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Saurav Lahiri <sa...@sungard.com> on 2014/04/08 17:15:13 UTC
Review Request 20123: Fix for cloudstack-6328 to Prevent console proxy
support scripts from spawning multiple java processes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20123/
-----------------------------------------------------------
Review request for cloudstack, Rajani Karuturi and Rajesh Battala.
Repository: cloudstack-git
Description
-------
With multiple java processes writing to the same logfile, each is not aware of the log4j's internal counter state, this needs to be prevented. So before starting new java process via the _run.sh , a check is made to ensure that there are no existing java processes running. This will prevent multiple java process writing to the same log file namely cloud.out.
Diffs
-----
systemvm/patches/debian/config/etc/init.d/cloud 83853bc
systemvm/scripts/run.sh 146d96f
systemvm/scripts/utils.sh PRE-CREATION
Diff: https://reviews.apache.org/r/20123/diff/
Testing
-------
Tested the changes with console proxy vm and secondary storage vm. They start and stop as expected.
Thanks,
Saurav Lahiri
Re: Review Request 20123: Fix for cloudstack-6328 to Prevent console proxy
support scripts from spawning multiple java processes
Posted by Saurav Lahiri <sa...@sungard.com>.
> On April 14, 2014, 8:58 a.m., Santhosh Edukulla wrote:
> > systemvm/scripts/utils.sh, line 9
> > <https://reviews.apache.org/r/20123/diff/1/?file=552596#file552596line9>
> >
> > Where is the variable CLOUD_COM_HOME defined?
This is a typo. I have fixed this with the new patch file.
> On April 14, 2014, 8:58 a.m., Santhosh Edukulla wrote:
> > systemvm/scripts/utils.sh, line 3
> > <https://reviews.apache.org/r/20123/diff/1/?file=552596#file552596line3>
> >
> > Where is this variable used?
This is a typo. I have fixed this with the new patch file.
> On April 14, 2014, 8:58 a.m., Santhosh Edukulla wrote:
> > systemvm/scripts/run.sh, line 30
> > <https://reviews.apache.org/r/20123/diff/1/?file=552595#file552595line30>
> >
> > How do we achieve syncrhonization and avoid few race flows here? I mean by the time pid value is retrieved at 30, and went to line 32, there could be a pid available genuinely for process check we are doing?
> >
> > As well, if run.sh is called multiple times at same time, the value will not be synchronous, then there is no lock protection here?
Added locking code via the shells flock. Since run.sh is invoked only via /etc/init.d/cloud it perhaps is not a serious issue. But still to avoid parallel invocations of /etc/init.d/cloud start, locking code has been added.
> On April 14, 2014, 8:58 a.m., Santhosh Edukulla wrote:
> > systemvm/scripts/utils.sh, line 6
> > <https://reviews.apache.org/r/20123/diff/1/?file=552596#file552596line6>
> >
> > This is not lock protected and can be run and called multiple times, may lead to unwarranted values.
The only two scripts which uses get_pids subroutines are the cloud script and the run.sh script and each of them have a local copy of the subroutine as they have sourced utils.sh. which contains the definition. Currently I think there might not be a need to lock protect this one. If you think otherwise, then a little bit more details would be very helpful.
- Saurav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20123/#review40251
-----------------------------------------------------------
On April 15, 2014, 11:50 a.m., Saurav Lahiri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20123/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 11:50 a.m.)
>
>
> Review request for cloudstack, Jayapal Reddy, Rajani Karuturi, and Rajesh Battala.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> With multiple java processes writing to the same logfile, each is not aware of the log4j's internal counter state, this needs to be prevented. So before starting new java process via the _run.sh , a check is made to ensure that there are no existing java processes running. This will prevent multiple java process writing to the same log file namely cloud.out.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/etc/init.d/cloud 83853bc
> systemvm/patches/debian/config/etc/init.d/cloud 83853bc
> systemvm/scripts/run.sh 146d96f
> systemvm/scripts/run.sh 146d96f
> systemvm/scripts/utils.sh PRE-CREATION
> systemvm/scripts/utils.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20123/diff/
>
>
> Testing
> -------
>
> Tested the changes with console proxy vm and secondary storage vm. They start and stop as expected.
>
>
> Thanks,
>
> Saurav Lahiri
>
>
Re: Review Request 20123: Fix for cloudstack-6328 to Prevent console proxy
support scripts from spawning multiple java processes
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20123/#review40251
-----------------------------------------------------------
systemvm/scripts/run.sh
<https://reviews.apache.org/r/20123/#comment73207>
How do we achieve syncrhonization and avoid few race flows here? I mean by the time pid value is retrieved at 30, and went to line 32, there could be a pid available genuinely for process check we are doing?
As well, if run.sh is called multiple times at same time, the value will not be synchronous, then there is no lock protection here?
systemvm/scripts/run.sh
<https://reviews.apache.org/r/20123/#comment73206>
What to do in case of multiple processes running?
systemvm/scripts/utils.sh
<https://reviews.apache.org/r/20123/#comment73204>
Where is this variable used?
systemvm/scripts/utils.sh
<https://reviews.apache.org/r/20123/#comment73208>
This is not lock protected and can be run and called multiple times, may lead to unwarranted values.
systemvm/scripts/utils.sh
<https://reviews.apache.org/r/20123/#comment73205>
Where is the variable CLOUD_COM_HOME defined?
- Santhosh Edukulla
On April 14, 2014, 7:15 a.m., Saurav Lahiri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20123/
> -----------------------------------------------------------
>
> (Updated April 14, 2014, 7:15 a.m.)
>
>
> Review request for cloudstack, Jayapal Reddy, Rajani Karuturi, and Rajesh Battala.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> With multiple java processes writing to the same logfile, each is not aware of the log4j's internal counter state, this needs to be prevented. So before starting new java process via the _run.sh , a check is made to ensure that there are no existing java processes running. This will prevent multiple java process writing to the same log file namely cloud.out.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/etc/init.d/cloud 83853bc
> systemvm/scripts/run.sh 146d96f
> systemvm/scripts/utils.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20123/diff/
>
>
> Testing
> -------
>
> Tested the changes with console proxy vm and secondary storage vm. They start and stop as expected.
>
>
> Thanks,
>
> Saurav Lahiri
>
>
Re: Review Request 20123: Fix for cloudstack-6328 to Prevent console proxy
support scripts from spawning multiple java processes
Posted by Saurav Lahiri <sa...@sungard.com>.
> On April 25, 2014, 10:10 a.m., Santhosh Edukulla wrote:
> > systemvm/scripts/run.sh, line 44
> > <https://reviews.apache.org/r/20123/diff/3/?file=558063#file558063line44>
> >
> > Just to know, is _run.sh called only from here or has other references as well? If yes, then this logic does nt solve purpose i believe. If it is only here, then it seems ok.
> >
> > AS well, i hope it is tested for various occurrences of java processes and the sequence is working fine?
> >
Yes that's correct _run.sh is only invoked from run.sh and spawns the java process for systemvms.
> On April 25, 2014, 10:10 a.m., Santhosh Edukulla wrote:
> > systemvm/scripts/utils.sh, line 18
> > <https://reviews.apache.org/r/20123/diff/3/?file=558064#file558064line18>
> >
> > is one time check for lock ok? Just use a timeout for acquiring lock, this way it will atleast wait that many units to get a lock otherwise exit.
I think it should be a good idea to not try to acquire a lock because the first run.sh which has acquired the lock would already attempt to start the java process and retries by the second run.sh process which has initially failed would not perhaps not be correct.
- Saurav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20123/#review41457
-----------------------------------------------------------
On April 23, 2014, 9:20 a.m., Saurav Lahiri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20123/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 9:20 a.m.)
>
>
> Review request for cloudstack, Jayapal Reddy, Rajani Karuturi, Rajesh Battala, and Santhosh Edukulla.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> With multiple java processes writing to the same logfile, each is not aware of the log4j's internal counter state, this needs to be prevented. So before starting new java process via the _run.sh , a check is made to ensure that there are no existing java processes running. This will prevent multiple java process writing to the same log file namely cloud.out.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/etc/init.d/cloud 83853bc
> systemvm/scripts/run.sh 146d96f
> systemvm/scripts/utils.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20123/diff/
>
>
> Testing
> -------
>
> Tested the changes with console proxy vm and secondary storage vm. They start and stop as expected.
>
>
> Thanks,
>
> Saurav Lahiri
>
>
Re: Review Request 20123: Fix for cloudstack-6328 to Prevent console proxy
support scripts from spawning multiple java processes
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20123/#review41457
-----------------------------------------------------------
systemvm/scripts/run.sh
<https://reviews.apache.org/r/20123/#comment74890>
Just to know, is _run.sh called only from here or has other references as well? If yes, then this logic does nt solve purpose i believe. If it is only here, then it seems ok.
AS well, i hope it is tested for various occurrences of java processes and the sequence is working fine?
systemvm/scripts/utils.sh
<https://reviews.apache.org/r/20123/#comment74891>
is one time check for lock ok? Just use a timeout for acquiring lock, this way it will atleast wait that many units to get a lock otherwise exit.
- Santhosh Edukulla
On April 23, 2014, 9:20 a.m., Saurav Lahiri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20123/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 9:20 a.m.)
>
>
> Review request for cloudstack, Jayapal Reddy, Rajani Karuturi, Rajesh Battala, and Santhosh Edukulla.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> With multiple java processes writing to the same logfile, each is not aware of the log4j's internal counter state, this needs to be prevented. So before starting new java process via the _run.sh , a check is made to ensure that there are no existing java processes running. This will prevent multiple java process writing to the same log file namely cloud.out.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/etc/init.d/cloud 83853bc
> systemvm/scripts/run.sh 146d96f
> systemvm/scripts/utils.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20123/diff/
>
>
> Testing
> -------
>
> Tested the changes with console proxy vm and secondary storage vm. They start and stop as expected.
>
>
> Thanks,
>
> Saurav Lahiri
>
>
Re: Review Request 20123: Fix for cloudstack-6328 to Prevent
console proxy support scripts from spawning multiple java processes
Posted by Jayapal Reddy Uradi <ja...@citrix.com>.
Hi Saurav,
Can you please file bug describing the issue ?
Also please update the bug-id in review request.
Thanks,
Jayapal
On 24-May-2014, at 12:24 AM, Santhosh Edukulla <sa...@citrix.com> wrote:
>
>
>> On April 29, 2014, 12:29 p.m., Santhosh Edukulla wrote:
>>> Ship It!
>
> If we don't have any review issues pending, can some body with commit rights push this patch?
>
>
> - Santhosh
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20123/#review41708
> -----------------------------------------------------------
>
>
> On April 23, 2014, 9:20 a.m., Saurav Lahiri wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/20123/
>> -----------------------------------------------------------
>>
>> (Updated April 23, 2014, 9:20 a.m.)
>>
>>
>> Review request for cloudstack, Jayapal Reddy, Rajani Karuturi, Rajesh Battala, and Santhosh Edukulla.
>>
>>
>> Repository: cloudstack-git
>>
>>
>> Description
>> -------
>>
>> With multiple java processes writing to the same logfile, each is not aware of the log4j's internal counter state, this needs to be prevented. So before starting new java process via the _run.sh , a check is made to ensure that there are no existing java processes running. This will prevent multiple java process writing to the same log file namely cloud.out.
>>
>>
>> Diffs
>> -----
>>
>> systemvm/patches/debian/config/etc/init.d/cloud 83853bc
>> systemvm/scripts/run.sh 146d96f
>> systemvm/scripts/utils.sh PRE-CREATION
>>
>> Diff: https://reviews.apache.org/r/20123/diff/
>>
>>
>> Testing
>> -------
>>
>> Tested the changes with console proxy vm and secondary storage vm. They start and stop as expected.
>>
>>
>> Thanks,
>>
>> Saurav Lahiri
>>
>>
>
Re: Review Request 20123: Fix for cloudstack-6328 to Prevent console proxy
support scripts from spawning multiple java processes
Posted by Santhosh Edukulla <sa...@citrix.com>.
> On April 29, 2014, 12:29 p.m., Santhosh Edukulla wrote:
> > Ship It!
If we don't have any review issues pending, can some body with commit rights push this patch?
- Santhosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20123/#review41708
-----------------------------------------------------------
On April 23, 2014, 9:20 a.m., Saurav Lahiri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20123/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 9:20 a.m.)
>
>
> Review request for cloudstack, Jayapal Reddy, Rajani Karuturi, Rajesh Battala, and Santhosh Edukulla.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> With multiple java processes writing to the same logfile, each is not aware of the log4j's internal counter state, this needs to be prevented. So before starting new java process via the _run.sh , a check is made to ensure that there are no existing java processes running. This will prevent multiple java process writing to the same log file namely cloud.out.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/etc/init.d/cloud 83853bc
> systemvm/scripts/run.sh 146d96f
> systemvm/scripts/utils.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20123/diff/
>
>
> Testing
> -------
>
> Tested the changes with console proxy vm and secondary storage vm. They start and stop as expected.
>
>
> Thanks,
>
> Saurav Lahiri
>
>
Re: Review Request 20123: Fix for cloudstack-6328 to Prevent console
proxy support scripts from spawning multiple java processes
Posted by Saurav Lahiri <sa...@sungardas.com>.
Rajani,
I had missed this. My apologies. The status shows as submitted. I am
guessing that you have updated the status and nothing more needs to be done.
Saurav
On Mon, Jul 28, 2014 at 11:48 AM, Rajani Karuturi <ra...@gmail.com>
wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20123/
>
> On April 29th, 2014, 12:29 p.m. UTC, *Santhosh Edukulla* wrote:
>
> Ship It!
>
> On May 23rd, 2014, 6:54 p.m. UTC, *Santhosh Edukulla* wrote:
>
> If we don't have any review issues pending, can some body with commit rights push this patch?
>
> On July 22nd, 2014, 6:29 a.m. UTC, *Santhosh Edukulla* wrote:
>
> Saurav,
>
> Please update BugId and Branch fields. This review submission is pending since long. Please check.
>
> Santhosh
>
> santhosh, bug-id is mentioned in the subject CLOUDSTACK-6328
>
> I looked at the bug comments on the bug. changes are already committed by jayapal. But, commit id isnt updated here and the review isnt closed.
>
> here is the commit for master https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=96b1c6b
>
> saurav, can you mark this review submitted?
>
>
> - Rajani
>
> On April 23rd, 2014, 9:20 a.m. UTC, Saurav Lahiri wrote:
> Review request for cloudstack, Jayapal Reddy, Rajani Karuturi, Rajesh
> Battala, and Santhosh Edukulla.
> By Saurav Lahiri.
>
> *Updated April 23, 2014, 9:20 a.m.*
> *Repository: * cloudstack-git
> Description
>
> With multiple java processes writing to the same logfile, each is not aware of the log4j's internal counter state, this needs to be prevented. So before starting new java process via the _run.sh , a check is made to ensure that there are no existing java processes running. This will prevent multiple java process writing to the same log file namely cloud.out.
>
> Testing
>
> Tested the changes with console proxy vm and secondary storage vm. They start and stop as expected.
>
> Diffs
>
> - systemvm/patches/debian/config/etc/init.d/cloud (83853bc)
> - systemvm/scripts/run.sh (146d96f)
> - systemvm/scripts/utils.sh (PRE-CREATION)
>
> View Diff <https://reviews.apache.org/r/20123/diff/>
>
Re: Review Request 20123: Fix for cloudstack-6328 to Prevent console proxy
support scripts from spawning multiple java processes
Posted by Rajani Karuturi <ra...@gmail.com>.
> On April 29, 2014, 12:29 p.m., Santhosh Edukulla wrote:
> > Ship It!
>
> Santhosh Edukulla wrote:
> If we don't have any review issues pending, can some body with commit rights push this patch?
>
> Santhosh Edukulla wrote:
> Saurav,
>
> Please update BugId and Branch fields. This review submission is pending since long. Please check.
>
> Santhosh
santhosh, bug-id is mentioned in the subject CLOUDSTACK-6328
I looked at the bug comments on the bug. changes are already committed by jayapal. But, commit id isnt updated here and the review isnt closed.
here is the commit for master https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=96b1c6b
saurav, can you mark this review submitted?
- Rajani
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20123/#review41708
-----------------------------------------------------------
On April 23, 2014, 9:20 a.m., Saurav Lahiri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20123/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 9:20 a.m.)
>
>
> Review request for cloudstack, Jayapal Reddy, Rajani Karuturi, Rajesh Battala, and Santhosh Edukulla.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> With multiple java processes writing to the same logfile, each is not aware of the log4j's internal counter state, this needs to be prevented. So before starting new java process via the _run.sh , a check is made to ensure that there are no existing java processes running. This will prevent multiple java process writing to the same log file namely cloud.out.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/etc/init.d/cloud 83853bc
> systemvm/scripts/run.sh 146d96f
> systemvm/scripts/utils.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20123/diff/
>
>
> Testing
> -------
>
> Tested the changes with console proxy vm and secondary storage vm. They start and stop as expected.
>
>
> Thanks,
>
> Saurav Lahiri
>
>
Re: Review Request 20123: Fix for cloudstack-6328 to Prevent console proxy
support scripts from spawning multiple java processes
Posted by Santhosh Edukulla <sa...@citrix.com>.
> On April 29, 2014, 12:29 p.m., Santhosh Edukulla wrote:
> > Ship It!
>
> Santhosh Edukulla wrote:
> If we don't have any review issues pending, can some body with commit rights push this patch?
Saurav,
Please update BugId and Branch fields. This review submission is pending since long. Please check.
Santhosh
- Santhosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20123/#review41708
-----------------------------------------------------------
On April 23, 2014, 9:20 a.m., Saurav Lahiri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20123/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 9:20 a.m.)
>
>
> Review request for cloudstack, Jayapal Reddy, Rajani Karuturi, Rajesh Battala, and Santhosh Edukulla.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> With multiple java processes writing to the same logfile, each is not aware of the log4j's internal counter state, this needs to be prevented. So before starting new java process via the _run.sh , a check is made to ensure that there are no existing java processes running. This will prevent multiple java process writing to the same log file namely cloud.out.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/etc/init.d/cloud 83853bc
> systemvm/scripts/run.sh 146d96f
> systemvm/scripts/utils.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20123/diff/
>
>
> Testing
> -------
>
> Tested the changes with console proxy vm and secondary storage vm. They start and stop as expected.
>
>
> Thanks,
>
> Saurav Lahiri
>
>
Re: Review Request 20123: Fix for cloudstack-6328 to Prevent console proxy
support scripts from spawning multiple java processes
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20123/#review41708
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Edukulla
On April 23, 2014, 9:20 a.m., Saurav Lahiri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20123/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 9:20 a.m.)
>
>
> Review request for cloudstack, Jayapal Reddy, Rajani Karuturi, Rajesh Battala, and Santhosh Edukulla.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> With multiple java processes writing to the same logfile, each is not aware of the log4j's internal counter state, this needs to be prevented. So before starting new java process via the _run.sh , a check is made to ensure that there are no existing java processes running. This will prevent multiple java process writing to the same log file namely cloud.out.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/etc/init.d/cloud 83853bc
> systemvm/scripts/run.sh 146d96f
> systemvm/scripts/utils.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20123/diff/
>
>
> Testing
> -------
>
> Tested the changes with console proxy vm and secondary storage vm. They start and stop as expected.
>
>
> Thanks,
>
> Saurav Lahiri
>
>
Re: Review Request 20123: Fix for cloudstack-6328 to Prevent console proxy
support scripts from spawning multiple java processes
Posted by Saurav Lahiri <sa...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20123/
-----------------------------------------------------------
(Updated April 23, 2014, 9:20 a.m.)
Review request for cloudstack, Jayapal Reddy, Rajani Karuturi, Rajesh Battala, and Santhosh Edukulla.
Changes
-------
Adding Santosh E.
Repository: cloudstack-git
Description
-------
With multiple java processes writing to the same logfile, each is not aware of the log4j's internal counter state, this needs to be prevented. So before starting new java process via the _run.sh , a check is made to ensure that there are no existing java processes running. This will prevent multiple java process writing to the same log file namely cloud.out.
Diffs
-----
systemvm/patches/debian/config/etc/init.d/cloud 83853bc
systemvm/scripts/run.sh 146d96f
systemvm/scripts/utils.sh PRE-CREATION
Diff: https://reviews.apache.org/r/20123/diff/
Testing
-------
Tested the changes with console proxy vm and secondary storage vm. They start and stop as expected.
Thanks,
Saurav Lahiri
RE: Review Request 20123: Fix for cloudstack-6328 to Prevent
console proxy support scripts from spawning multiple java processes
Posted by Santhosh Edukulla <sa...@citrix.com>.
Saurav,
Just add me as reviewer.
Santhosh
________________________________________
From: Saurav Lahiri [saurav.lahiri@sungardas.com]
Sent: Wednesday, April 23, 2014 4:45 AM
To: Rajesh Battala; Rajani Karuturi; Jayapal Reddy Uradi
Cc: Santhosh Edukulla; Saurav Lahiri; cloudstack
Subject: Re: Review Request 20123: Fix for cloudstack-6328 to Prevent console proxy support scripts from spawning multiple java processes
Santosh,
Can you let me know ur thoughs If the review comments have been adequately addressed and the changes looks ok?
Thanks
Saurav
On Tue, Apr 15, 2014 at 5:43 PM, Saurav Lahiri <sa...@sungard.com>> wrote:
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20123/
Review request for cloudstack, Jayapal Reddy, Rajani Karuturi, and Rajesh Battala.
By Saurav Lahiri.
Updated April 15, 2014, 12:13 p.m.
Changes
Looks like the earlier patch had a problem. Please use this one instead which addresses the review comments.
Repository: cloudstack-git
Description
With multiple java processes writing to the same logfile, each is not aware of the log4j's internal counter state, this needs to be prevented. So before starting new java process via the _run.sh , a check is made to ensure that there are no existing java processes running. This will prevent multiple java process writing to the same log file namely cloud.out.
Testing
Tested the changes with console proxy vm and secondary storage vm. They start and stop as expected.
Diffs (updated)
* systemvm/patches/debian/config/etc/init.d/cloud (83853bc)
* systemvm/scripts/run.sh (146d96f)
* systemvm/scripts/utils.sh (PRE-CREATION)
View Diff<https://reviews.apache.org/r/20123/diff/>
Re: Review Request 20123: Fix for cloudstack-6328 to Prevent console
proxy support scripts from spawning multiple java processes
Posted by Saurav Lahiri <sa...@sungardas.com>.
Santosh,
Can you let me know ur thoughs If the review comments have been adequately
addressed and the changes looks ok?
Thanks
Saurav
On Tue, Apr 15, 2014 at 5:43 PM, Saurav Lahiri <sa...@sungard.com>wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20123/
> Review request for cloudstack, Jayapal Reddy, Rajani Karuturi, and
> Rajesh Battala.
> By Saurav Lahiri.
>
> *Updated April 15, 2014, 12:13 p.m.*
> Changes
>
> Looks like the earlier patch had a problem. Please use this one instead which addresses the review comments.
>
> *Repository: * cloudstack-git
> Description
>
> With multiple java processes writing to the same logfile, each is not aware of the log4j's internal counter state, this needs to be prevented. So before starting new java process via the _run.sh , a check is made to ensure that there are no existing java processes running. This will prevent multiple java process writing to the same log file namely cloud.out.
>
> Testing
>
> Tested the changes with console proxy vm and secondary storage vm. They start and stop as expected.
>
> Diffs (updated)
>
> - systemvm/patches/debian/config/etc/init.d/cloud (83853bc)
> - systemvm/scripts/run.sh (146d96f)
> - systemvm/scripts/utils.sh (PRE-CREATION)
>
> View Diff <https://reviews.apache.org/r/20123/diff/>
>
Re: Review Request 20123: Fix for cloudstack-6328 to Prevent console proxy
support scripts from spawning multiple java processes
Posted by Saurav Lahiri <sa...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20123/
-----------------------------------------------------------
(Updated April 15, 2014, 12:13 p.m.)
Review request for cloudstack, Jayapal Reddy, Rajani Karuturi, and Rajesh Battala.
Changes
-------
Looks like the earlier patch had a problem. Please use this one instead which addresses the review comments.
Repository: cloudstack-git
Description
-------
With multiple java processes writing to the same logfile, each is not aware of the log4j's internal counter state, this needs to be prevented. So before starting new java process via the _run.sh , a check is made to ensure that there are no existing java processes running. This will prevent multiple java process writing to the same log file namely cloud.out.
Diffs (updated)
-----
systemvm/patches/debian/config/etc/init.d/cloud 83853bc
systemvm/scripts/run.sh 146d96f
systemvm/scripts/utils.sh PRE-CREATION
Diff: https://reviews.apache.org/r/20123/diff/
Testing
-------
Tested the changes with console proxy vm and secondary storage vm. They start and stop as expected.
Thanks,
Saurav Lahiri
Re: Review Request 20123: Fix for cloudstack-6328 to Prevent console proxy
support scripts from spawning multiple java processes
Posted by Saurav Lahiri <sa...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20123/
-----------------------------------------------------------
(Updated April 15, 2014, 11:50 a.m.)
Review request for cloudstack, Jayapal Reddy, Rajani Karuturi, and Rajesh Battala.
Changes
-------
Addressed review comments.
Repository: cloudstack-git
Description
-------
With multiple java processes writing to the same logfile, each is not aware of the log4j's internal counter state, this needs to be prevented. So before starting new java process via the _run.sh , a check is made to ensure that there are no existing java processes running. This will prevent multiple java process writing to the same log file namely cloud.out.
Diffs (updated)
-----
systemvm/patches/debian/config/etc/init.d/cloud 83853bc
systemvm/patches/debian/config/etc/init.d/cloud 83853bc
systemvm/scripts/run.sh 146d96f
systemvm/scripts/run.sh 146d96f
systemvm/scripts/utils.sh PRE-CREATION
systemvm/scripts/utils.sh PRE-CREATION
Diff: https://reviews.apache.org/r/20123/diff/
Testing
-------
Tested the changes with console proxy vm and secondary storage vm. They start and stop as expected.
Thanks,
Saurav Lahiri
Re: Review Request 20123: Fix for cloudstack-6328 to Prevent console proxy
support scripts from spawning multiple java processes
Posted by Saurav Lahiri <sa...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20123/
-----------------------------------------------------------
(Updated April 14, 2014, 7:15 a.m.)
Review request for cloudstack, Jayapal Reddy, Rajani Karuturi, and Rajesh Battala.
Changes
-------
Added Jayapal.
Repository: cloudstack-git
Description
-------
With multiple java processes writing to the same logfile, each is not aware of the log4j's internal counter state, this needs to be prevented. So before starting new java process via the _run.sh , a check is made to ensure that there are no existing java processes running. This will prevent multiple java process writing to the same log file namely cloud.out.
Diffs
-----
systemvm/patches/debian/config/etc/init.d/cloud 83853bc
systemvm/scripts/run.sh 146d96f
systemvm/scripts/utils.sh PRE-CREATION
Diff: https://reviews.apache.org/r/20123/diff/
Testing
-------
Tested the changes with console proxy vm and secondary storage vm. They start and stop as expected.
Thanks,
Saurav Lahiri