[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1564: MINIFICPP-2081 - Read windows events from log file

["szaszm (via GitHub)" <gi...@apache.org>]

szaszm commented on code in PR #1564:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1564#discussion_r1226556614


##########
extensions/windows-event-log/tests/CWELTestUtils.h:
##########
@@ -94,3 +94,13 @@ class OutputFormatTestController : public TestController {
   std::string output_format_;
   std::optional<std::string> json_format_;
 };
+
+void generateLogFile(const std::wstring& channel, const std::filesystem::path& path) {
+  HANDLE event_log = OpenEventLog(NULL, std::string(channel.begin(), channel.end()).c_str());

Review Comment:
   is it? I see no `unique_ptr` or `finally` in the diff of this file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org