You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@guacamole.apache.org by "Mike Jumper (Jira)" <ji...@apache.org> on 2020/01/25 19:07:00 UTC

[jira] [Commented] (GUACAMOLE-939) Make the guacamole docker integration easier

    [ https://issues.apache.org/jira/browse/GUACAMOLE-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023629#comment-17023629 ] 

Mike Jumper commented on GUACAMOLE-939:
---------------------------------------

If you wish to contribute to Guacamole, please do so via a pull request. See our contribution guidelines:

https://github.com/apache/guacamole-client/blob/master/CONTRIBUTING

That said, I don't see the utility of the proposed change. Whether in a file or on the command line, the same options still need to be read, and the size of the burden on the user is unchanged. If the idea is that a file is more convenient, that's exactly what {{guacamole.properties}} already is, and the image allows you to provide your own. If the idea is to allow the environment variables of the image to be more maintainable, then a better choice would be {{docker-compose}}.

> Make the guacamole docker integration easier
> --------------------------------------------
>
>                 Key: GUACAMOLE-939
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-939
>             Project: Guacamole
>          Issue Type: Improvement
>          Components: guacamole-docker
>    Affects Versions: 1.0.0
>            Reporter: Thomas Eggers
>            Priority: Minor
>             Fix For: 1.1.0
>
>         Attachments: start.sh
>
>
> Hi,
> I'm not a Software developer,
>  but I have linux script and docker experience.
> I startet to enhance the start.sh file in the docker image.
> This new version is pre read required variable from guacamole.properties to configure the tomcat web interface. This make it much easier to start the docker container without so many options.
> Other things that I like to do is:
>   - import certificate for ldaps connections
>    - docker container health status
>   - and other small things
>  Thomas



--
This message was sent by Atlassian Jira
(v8.3.4#803005)