[GitHub] [incubator-druid] leventov edited a comment on issue #7206: Add the pull-request template

[GitBox <gi...@apache.org>]

leventov edited a comment on issue #7206: Add the pull-request template
URL: https://github.com/apache/incubator-druid/pull/7206#issuecomment-492234068
 
 
   > A broad question: is the intent of this PR template to put our current practices into writing, or to define a new set of expected practices? I'm asking because there are a lot of things this template asks for that we do not currently always ask for on every PR.
   
   I think I added enough language to make everything optional. However, the expectation is that regular developers will do most of the things (which they often don't do now). So yes, this is an elevation of the standards.
   
   The idea is that we think that doing these things is beneficial for the common productivity (when a PR author who is a regular contributor considers not only their own productivity right during the preparation of the given PR, but also productivity of the reviewers, and productivity of dozens of people who will work with their code later over the lifetime of the project). So we *want* to do these things rather than consider them as chores. The template is a memo for ourselves to not forget about them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org