You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jclouds.apache.org by na...@apache.org on 2013/09/09 16:23:45 UTC
[1/2] git commit: Fix typo.
Updated Branches:
refs/heads/master 3bc628f9e -> 476b957a0
Fix typo.
Project: http://git-wip-us.apache.org/repos/asf/incubator-jclouds-chef/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-jclouds-chef/commit/0ea7c890
Tree: http://git-wip-us.apache.org/repos/asf/incubator-jclouds-chef/tree/0ea7c890
Diff: http://git-wip-us.apache.org/repos/asf/incubator-jclouds-chef/diff/0ea7c890
Branch: refs/heads/master
Commit: 0ea7c8906ae1c44643b400a8ac748e49130589ef
Parents: 3bc628f
Author: Noorul Islam K M <no...@noorul.com>
Authored: Mon Sep 9 09:52:36 2013 +0530
Committer: Ignasi Barrera <na...@apache.org>
Committed: Mon Sep 9 16:22:24 2013 +0200
----------------------------------------------------------------------
.../internal/CleanupStaleNodesAndClientsImplLiveTest.java | 6 +++---
.../internal/DeleteAllApisAndNodesInListImplLiveTest.java | 8 ++++----
.../jclouds/chef/strategy/internal/GetNodesImplLiveTest.java | 8 ++++----
3 files changed, 11 insertions(+), 11 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-jclouds-chef/blob/0ea7c890/core/src/test/java/org/jclouds/chef/strategy/internal/CleanupStaleNodesAndClientsImplLiveTest.java
----------------------------------------------------------------------
diff --git a/core/src/test/java/org/jclouds/chef/strategy/internal/CleanupStaleNodesAndClientsImplLiveTest.java b/core/src/test/java/org/jclouds/chef/strategy/internal/CleanupStaleNodesAndClientsImplLiveTest.java
index 9a21b0f..30363c3 100644
--- a/core/src/test/java/org/jclouds/chef/strategy/internal/CleanupStaleNodesAndClientsImplLiveTest.java
+++ b/core/src/test/java/org/jclouds/chef/strategy/internal/CleanupStaleNodesAndClientsImplLiveTest.java
@@ -33,20 +33,20 @@ import com.google.common.collect.ImmutableSet;
@Test(groups = "live", testName = "CleanupStaleNodesAndClientsImplLiveTest")
public class CleanupStaleNodesAndClientsImplLiveTest extends BaseChefLiveTest<ChefApi> {
- private CreateNodeAndPopulateAutomaticAttributesImpl creater;
+ private CreateNodeAndPopulateAutomaticAttributesImpl creator;
private CleanupStaleNodesAndClientsImpl strategy;
@Override
protected void initialize() {
super.initialize();
- this.creater = injector.getInstance(CreateNodeAndPopulateAutomaticAttributesImpl.class);
+ this.creator = injector.getInstance(CreateNodeAndPopulateAutomaticAttributesImpl.class);
this.strategy = injector.getInstance(CleanupStaleNodesAndClientsImpl.class);
}
@Test
public void testExecute() throws InterruptedException {
try {
- creater.execute(prefix, ImmutableSet.<String> of());
+ creator.execute(prefix, ImmutableSet.<String> of());
// http://tickets.corp.opscode.com/browse/PL-522
// assert chef.nodeExists(prefix);
assertNotNull(api.getNode(prefix));
http://git-wip-us.apache.org/repos/asf/incubator-jclouds-chef/blob/0ea7c890/core/src/test/java/org/jclouds/chef/strategy/internal/DeleteAllApisAndNodesInListImplLiveTest.java
----------------------------------------------------------------------
diff --git a/core/src/test/java/org/jclouds/chef/strategy/internal/DeleteAllApisAndNodesInListImplLiveTest.java b/core/src/test/java/org/jclouds/chef/strategy/internal/DeleteAllApisAndNodesInListImplLiveTest.java
index 5f9d90a..79cef87 100644
--- a/core/src/test/java/org/jclouds/chef/strategy/internal/DeleteAllApisAndNodesInListImplLiveTest.java
+++ b/core/src/test/java/org/jclouds/chef/strategy/internal/DeleteAllApisAndNodesInListImplLiveTest.java
@@ -34,20 +34,20 @@ import com.google.common.collect.ImmutableSet;
public class DeleteAllApisAndNodesInListImplLiveTest extends BaseChefLiveTest<ChefApi> {
private DeleteAllNodesInListImpl strategy;
- private CreateNodeAndPopulateAutomaticAttributesImpl creater;
+ private CreateNodeAndPopulateAutomaticAttributesImpl creator;
@Override
protected void initialize() {
super.initialize();
- this.creater = injector.getInstance(CreateNodeAndPopulateAutomaticAttributesImpl.class);
+ this.creator = injector.getInstance(CreateNodeAndPopulateAutomaticAttributesImpl.class);
this.strategy = injector.getInstance(DeleteAllNodesInListImpl.class);
}
@Test
public void testExecute() throws InterruptedException {
try {
- creater.execute(prefix, ImmutableSet.<String> of());
- creater.execute(prefix + 1, ImmutableSet.<String> of());
+ creator.execute(prefix, ImmutableSet.<String> of());
+ creator.execute(prefix + 1, ImmutableSet.<String> of());
// http://tickets.corp.opscode.com/browse/PL-522
// assert api.nodeExists(prefix);
http://git-wip-us.apache.org/repos/asf/incubator-jclouds-chef/blob/0ea7c890/core/src/test/java/org/jclouds/chef/strategy/internal/GetNodesImplLiveTest.java
----------------------------------------------------------------------
diff --git a/core/src/test/java/org/jclouds/chef/strategy/internal/GetNodesImplLiveTest.java b/core/src/test/java/org/jclouds/chef/strategy/internal/GetNodesImplLiveTest.java
index 1c2cec1..f4c0698 100644
--- a/core/src/test/java/org/jclouds/chef/strategy/internal/GetNodesImplLiveTest.java
+++ b/core/src/test/java/org/jclouds/chef/strategy/internal/GetNodesImplLiveTest.java
@@ -36,15 +36,15 @@ import com.google.common.collect.ImmutableSet;
public class GetNodesImplLiveTest extends BaseChefLiveTest<ChefApi> {
private ListNodesImpl strategy;
- private CreateNodeAndPopulateAutomaticAttributesImpl creater;
+ private CreateNodeAndPopulateAutomaticAttributesImpl creator;
@Override
protected void initialize() {
super.initialize();
- this.creater = injector.getInstance(CreateNodeAndPopulateAutomaticAttributesImpl.class);
+ this.creator = injector.getInstance(CreateNodeAndPopulateAutomaticAttributesImpl.class);
this.strategy = injector.getInstance(ListNodesImpl.class);
- creater.execute(prefix, ImmutableSet.<String> of());
- creater.execute(prefix + 1, ImmutableSet.<String> of());
+ creator.execute(prefix, ImmutableSet.<String> of());
+ creator.execute(prefix + 1, ImmutableSet.<String> of());
}
@AfterClass(groups = { "integration", "live" })
[2/2] git commit: Use TestNG asserts
Posted by na...@apache.org.
Use TestNG asserts
Project: http://git-wip-us.apache.org/repos/asf/incubator-jclouds-chef/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-jclouds-chef/commit/476b957a
Tree: http://git-wip-us.apache.org/repos/asf/incubator-jclouds-chef/tree/476b957a
Diff: http://git-wip-us.apache.org/repos/asf/incubator-jclouds-chef/diff/476b957a
Branch: refs/heads/master
Commit: 476b957a0ddcb179c632dae5ce0d1bdeb83073ed
Parents: 0ea7c89
Author: Noorul Islam K M <no...@noorul.com>
Authored: Mon Sep 9 11:18:48 2013 +0530
Committer: Ignasi Barrera <na...@apache.org>
Committed: Mon Sep 9 16:22:28 2013 +0200
----------------------------------------------------------------------
.../org/jclouds/chef/strategy/internal/GetNodesImplLiveTest.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-jclouds-chef/blob/476b957a/core/src/test/java/org/jclouds/chef/strategy/internal/GetNodesImplLiveTest.java
----------------------------------------------------------------------
diff --git a/core/src/test/java/org/jclouds/chef/strategy/internal/GetNodesImplLiveTest.java b/core/src/test/java/org/jclouds/chef/strategy/internal/GetNodesImplLiveTest.java
index f4c0698..1b36471 100644
--- a/core/src/test/java/org/jclouds/chef/strategy/internal/GetNodesImplLiveTest.java
+++ b/core/src/test/java/org/jclouds/chef/strategy/internal/GetNodesImplLiveTest.java
@@ -18,6 +18,7 @@ package org.jclouds.chef.strategy.internal;
import static com.google.common.collect.Iterables.size;
import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.assertTrue;
import org.jclouds.chef.ChefApi;
import org.jclouds.chef.internal.BaseChefLiveTest;
@@ -57,7 +58,7 @@ public class GetNodesImplLiveTest extends BaseChefLiveTest<ChefApi> {
@Test
public void testExecute() {
- assert size(strategy.execute()) > 0;
+ assertTrue(size(strategy.execute()) > 0, "Expected one or more elements");
}
@Test