You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@fineract.apache.org by Aleksandar Vidakovic <ch...@monkeysintown.com> on 2022/02/07 14:50:36 UTC
Arnold Galovics as reviewer...
Hi everyone,
... not sure how the mechanics on Github work in detail, but could someone
make sure that Arnold Galovics (Github username "") can be added to do code
reviews? Does he need any specific permissions to do that?
If there's anything that I can help with then please let me know. Arnold
already made a contribution and will help out even more.
Thanks and cheers,
Aleks
Re: Arnold Galovics as reviewer...
Posted by Arnold Galovics <ga...@gmail.com>.
Hi Petri,
Thanks for the clarification. Makes sense.
Best,
Arnold
On Tue, Feb 8, 2022 at 1:21 AM Aleksandar Vidakovic <
cheetah@monkeysintown.com> wrote:
> Hi Petri,
>
> ... thanks for the update on this topic and sounds right to me... didn't
> have it exactly on the radar anymore.
>
> Cheers
>
> On Tue, Feb 8, 2022 at 1:17 AM Petri Tuomola <pe...@gmail.com>
> wrote:
>
>> Hi Aleks
>>
>> My understanding is that anyone can review just by adding comments in
>> GitHub. But for the review to count as “signoff” and result in a merge, the
>> reviewer should be a committer.
>>
>> And the process for proposing someone as committer is as per
>>
>> https://cwiki.apache.org/confluence/plugins/servlet/mobile?contentId=61334485#content/view/61334485
>>
>> But I’m happy to be corrected if the above understanding is not accurate
>> - I’m not claiming to be an expert on this…
>>
>> Regards
>> Petri
>>
>>
>>
>> On 8 Feb 2022, at 01:40, Arnold Galovics <ga...@gmail.com>
>> wrote:
>>
>> Hi Aleks,
>>
>> Probably you missed to copy paste my username so let me put it here: GH
>> username is galovics.
>>
>> Thanks!
>> Best,
>> Arnold
>>
>> On Mon, Feb 7, 2022 at 3:50 PM Aleksandar Vidakovic <
>> cheetah@monkeysintown.com> wrote:
>>
>>> Hi everyone,
>>>
>>> ... not sure how the mechanics on Github work in detail, but could
>>> someone make sure that Arnold Galovics (Github username "") can be added to
>>> do code reviews? Does he need any specific permissions to do that?
>>>
>>> If there's anything that I can help with then please let me know. Arnold
>>> already made a contribution and will help out even more.
>>>
>>> Thanks and cheers,
>>>
>>> Aleks
>>>
>>
>>
Re: Arnold Galovics as reviewer...
Posted by Aleksandar Vidakovic <ch...@monkeysintown.com>.
Hi Petri,
... thanks for the update on this topic and sounds right to me... didn't
have it exactly on the radar anymore.
Cheers
On Tue, Feb 8, 2022 at 1:17 AM Petri Tuomola <pe...@gmail.com>
wrote:
> Hi Aleks
>
> My understanding is that anyone can review just by adding comments in
> GitHub. But for the review to count as “signoff” and result in a merge, the
> reviewer should be a committer.
>
> And the process for proposing someone as committer is as per
>
> https://cwiki.apache.org/confluence/plugins/servlet/mobile?contentId=61334485#content/view/61334485
>
> But I’m happy to be corrected if the above understanding is not accurate -
> I’m not claiming to be an expert on this…
>
> Regards
> Petri
>
>
>
> On 8 Feb 2022, at 01:40, Arnold Galovics <ga...@gmail.com> wrote:
>
> Hi Aleks,
>
> Probably you missed to copy paste my username so let me put it here: GH
> username is galovics.
>
> Thanks!
> Best,
> Arnold
>
> On Mon, Feb 7, 2022 at 3:50 PM Aleksandar Vidakovic <
> cheetah@monkeysintown.com> wrote:
>
>> Hi everyone,
>>
>> ... not sure how the mechanics on Github work in detail, but could
>> someone make sure that Arnold Galovics (Github username "") can be added to
>> do code reviews? Does he need any specific permissions to do that?
>>
>> If there's anything that I can help with then please let me know. Arnold
>> already made a contribution and will help out even more.
>>
>> Thanks and cheers,
>>
>> Aleks
>>
>
>
Re: Arnold Galovics as reviewer...
Posted by Petri Tuomola <pe...@gmail.com>.
Hi Aleks
My understanding is that anyone can review just by adding comments in
GitHub. But for the review to count as “signoff” and result in a merge, the
reviewer should be a committer.
And the process for proposing someone as committer is as per
https://cwiki.apache.org/confluence/plugins/servlet/mobile?contentId=61334485#content/view/61334485
But I’m happy to be corrected if the above understanding is not accurate -
I’m not claiming to be an expert on this…
Regards
Petri
On 8 Feb 2022, at 01:40, Arnold Galovics <ga...@gmail.com> wrote:
Hi Aleks,
Probably you missed to copy paste my username so let me put it here: GH
username is galovics.
Thanks!
Best,
Arnold
On Mon, Feb 7, 2022 at 3:50 PM Aleksandar Vidakovic <
cheetah@monkeysintown.com> wrote:
> Hi everyone,
>
> ... not sure how the mechanics on Github work in detail, but could someone
> make sure that Arnold Galovics (Github username "") can be added to do code
> reviews? Does he need any specific permissions to do that?
>
> If there's anything that I can help with then please let me know. Arnold
> already made a contribution and will help out even more.
>
> Thanks and cheers,
>
> Aleks
>
Re: Arnold Galovics as reviewer...
Posted by Arnold Galovics <ga...@gmail.com>.
Hi Aleks,
Probably you missed to copy paste my username so let me put it here: GH
username is galovics.
Thanks!
Best,
Arnold
On Mon, Feb 7, 2022 at 3:50 PM Aleksandar Vidakovic <
cheetah@monkeysintown.com> wrote:
> Hi everyone,
>
> ... not sure how the mechanics on Github work in detail, but could someone
> make sure that Arnold Galovics (Github username "") can be added to do code
> reviews? Does he need any specific permissions to do that?
>
> If there's anything that I can help with then please let me know. Arnold
> already made a contribution and will help out even more.
>
> Thanks and cheers,
>
> Aleks
>