You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2014/11/11 23:51:04 UTC

[GitHub] incubator-brooklyn pull request: Bump groovy version to 2.3.4 from...

GitHub user aledsage opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/319

    Bump groovy version to 2.3.4 from 1.8.6

    - And groovy-eclipse-compiler to 2.9.0-01 from 2.7.0-01
    - And groovy-eclipse-batch to 2.3.4-01 from 1.8.6-01

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/incubator-brooklyn update/groovy-version-2.3.4

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/319.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #319
    
----
commit 7816362221eb65308fc1b9bf934113ce99d41a38
Author: Aled Sage <al...@gmail.com>
Date:   2014-11-11T14:48:58Z

    Bump groovy version to 2.3.4 from 1.8.6
    
    - And groovy-eclipse-compiler to 2.9.0-01 from 2.7.0-01
    - And groovy-eclipse-batch to 2.3.4-01 from 1.8.6-01

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Bump groovy version to 2.3.4 from...

Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/319#issuecomment-62709939
  
    +1, didn't expect the source changes to be so minute
    
    Please update the archetype-quickstart pom as well.
    
    After applying the change I can successfully compile with Java 8. IBM Java 7 also goes pretty far, only to abort with the same problems as in https://issues.apache.org/jira/browse/BROOKLYN-83 and https://issues.apache.org/jira/browse/BROOKLYN-84.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Bump groovy version to 2.3.4 from...

Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/319#issuecomment-62688480
  
    what does @asfbot say?  close and reopen?
    
    also can you edit:
    
        dev/build/eclipse.include.md:  Be sure to include Groovy 1.8.6 compiler support 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Bump groovy version to 2.3.4 from...

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/319#issuecomment-62710723
  
    build failure was a hudson error:
        InternalErrorException: Internal error: java.lang.IllegalStateException: Invalid object ID 28 iota=55
    
    Have updated `eclipse.include.md`, and also `usage/archetypes/quickstart/src/brooklyn-sample/pom.xml`, and rebased.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Bump groovy version to 2.3.4 from...

Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/319#issuecomment-62719528
  
    Merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Bump groovy version to 2.3.4 from...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/319


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Bump groovy version to 2.3.4 from...

Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/319#issuecomment-62717056
  
    :frog:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---