You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/14 13:20:54 UTC

[GitHub] [arrow] xhochy commented on a change in pull request #8459: ARROW-10195: [C++] Add string struct extract kernel using re2

xhochy commented on a change in pull request #8459:
URL: https://github.com/apache/arrow/pull/8459#discussion_r504670998



##########
File path: cpp/CMakeLists.txt
##########
@@ -735,6 +735,7 @@ endif()
 
 if(ARROW_WITH_UTF8PROC)
   list(APPEND ARROW_LINK_LIBS utf8proc::utf8proc)
+  list(APPEND ARROW_LINK_LIBS re2)

Review comment:
       That's the correct approach but maybe outside of the `ARROW_WITH_UTF8PROC` scope as we would always link `re2` independently of the `utf8proc`-based kernels?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org