You are viewing a plain text version of this content. The canonical link for it is here.
Posted to axis-cvs@ws.apache.org by sa...@apache.org on 2005/03/23 10:31:30 UTC
cvs commit: ws-axis/c/build testInitialize.xml
sanjaya 2005/03/23 01:31:30
Modified: c/build testInitialize.xml
Log:
added changes to copy parser specific library to generic parser library name in ${dir.bin}
Revision Changes Path
1.3 +13 -1 ws-axis/c/build/testInitialize.xml
Index: testInitialize.xml
===================================================================
RCS file: /home/cvs/ws-axis/c/build/testInitialize.xml,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- testInitialize.xml 8 Feb 2005 15:24:19 -0000 1.2
+++ testInitialize.xml 23 Mar 2005 09:31:30 -0000 1.3
@@ -16,7 +16,19 @@
<isset property="windows"/>
</not>
</condition>
- </target>
+
+ <!-- set the built lib for the selected client partser -->
+ <condition property="selectedClientParserLib" value="${libraryPrefix}${xml4c.xmlParserLibraryName}${librarySuffix}">
+ <istrue value="${testconf.client.parser.xml4c}"/>
+ </condition>
+ <condition property="selectedClientParserLib" value="${libraryPrefix}${xerces.xmlParserLibraryName}${librarySuffix}">
+ <istrue value="${testconf.client.parser.xerces}"/>
+ </condition>
+ <!-- make a copy of the parser specfic library with the general parser library name -->
+ <copy file="${dir.bin}/${selectedClientParserLib}" tofile="${dir.bin}/${libraryPrefix}${xmlParserLibraryName}${librarySuffix}"/>
+
+</target>
+
<target name="initializeLogFile">
<mkdir dir="${dir.results}"/>
Re: cvs commit: ws-axis/c/build testInitialize.xml
Posted by sanjaya singharage <sa...@opensource.lk>.
For the moment I will revert back this change. I will write later in detail.
sorry about breaking your test runs.
sanjaya.
----- Original Message -----
From: "Adrian Dick" <ad...@uk.ibm.com>
To: <ax...@ws.apache.org>
Sent: Wednesday, March 23, 2005 11:37 PM
Subject: Re: cvs commit: ws-axis/c/build testInitialize.xml
> Hi,
>
> This fix is not suitable, and indeed breaks completely for our automated
> test systems here.
> We carry out all our testing as a customer would be expected, having
access
> to just the binary package. Unfortunately, this means the files you're
> attempting to work with do not exist, causing ANT to fail.
>
> There are several issues that come to mind as I look at this particular
> fix:
> - Why are we renaming built libraries?
> Either the test needs to cope with what it's given, or there's a
> problem in the build and package steps.
> In this particular case, the test script needs to determine which of
> the XML parsers it wishes to test with, and use directly:
> - Why are we working with files in obj/bin?
> Surely we should be testing against the packaged (obj/package/....)
> structure, as we provide to our customers?
>
>
> I have added failonerror="false" to the copy task, which prevents ANT from
> failing. I also needed to replicate a number of new properties you've
> recently added to build.linux.properties across to the properties files
for
> the other platforms.
>
> However, I am still not happy with this being done. I would much prefer
> that we set a property for the desired xmlparser library name ... perhaps
> overriding ${xmlParserLibraryName} with the appropriate choice of
> ${xml4c.xmlParserLibraryName} or ${xerces.xmlParserLibraryName}, where the
> copy is currently taking place.
>
> Regards,
> Adrian
> _______________________________________
> Adrian Dick (adrian.dick@uk.ibm.com)
> WebSphere MQ and ESB Development
> Tel: +44-(0)-1962-819212
> Notes: Adrian Dick/UK/IBM@IBMGB
>
> sanjaya@apache.org wrote on 23/03/2005 09:31:30:
>
> > sanjaya 2005/03/23 01:31:30
> >
> > Modified: c/build testInitialize.xml
> > Log:
> > added changes to copy parser specific library to generic parser
> > library name in ${dir.bin}
> >
> > Revision Changes Path
> > 1.3 +13 -1 ws-axis/c/build/testInitialize.xml
> >
> > Index: testInitialize.xml
> > ===================================================================
> > RCS file: /home/cvs/ws-axis/c/build/testInitialize.xml,v
> > retrieving revision 1.2
> > retrieving revision 1.3
> > diff -u -r1.2 -r1.3
> > --- testInitialize.xml 8 Feb 2005 15:24:19 -0000 1.2
> > +++ testInitialize.xml 23 Mar 2005 09:31:30 -0000 1.3
> > @@ -16,7 +16,19 @@
> > <isset property="windows"/>
> > </not>
> > </condition>
> > - </target>
> > +
> > + <!-- set the built lib for the selected client partser -->
> > + <condition property="selectedClientParserLib"
> > value="${libraryPrefix}${xml4c.xmlParserLibraryName}${librarySuffix}">
> > + <istrue value="${testconf.client.parser.xml4c}"/>
> > + </condition>
> > + <condition property="selectedClientParserLib"
> > value="${libraryPrefix}${xerces.xmlParserLibraryName}${librarySuffix}">
> > + <istrue value="${testconf.client.parser.xerces}"/>
> > + </condition>
> > + <!-- make a copy of the parser specfic library with the
> > general parser library name -->
> > + <copy file="${dir.bin}/${selectedClientParserLib}"
> >
>
tofile="${dir.bin}/${libraryPrefix}${xmlParserLibraryName}${librarySuffix}"/
>
>
> > +
> > +</target>
> > +
> >
> > <target name="initializeLogFile">
> > <mkdir dir="${dir.results}"/>
> >
> >
> >
>
>
ant windows property file - changing default xerces parser library
Posted by sanjaya singharage <sa...@opensource.lk>.
Is it ok to ..
xerces.xmlParserLibrary = xerces-c_2 -----------> xerces.xmlParserLibrary =
xerces-c_2_2_0
in c/build/build.win32.properties as the default value?
sanjaya.
Re: cvs commit: ws-axis/c/build testInitialize.xml
Posted by Adrian Dick <ad...@uk.ibm.com>.
Hi,
Some comments below.
Adrian
_______________________________________
Adrian Dick (adrian.dick@uk.ibm.com)
"sanjaya singharage" <sa...@opensource.lk> wrote on 24/03/2005 05:04:15:
> and...
> build/build.Linux.properties:dir.libraries = ${dir.bin}
>
> correct me if I am wrong. but doesn't this use the binaries in the bin
> directory? If you don't have the bin directories I don't understand how
the
> tests can be run.
Ah, yes. I see the confusion. I've just found we over-ride that value
to use ${dir.release}/lib (or ${dir.release}/bin for windows) in our
automated test systems - due to only having the packaged structure.
Apologies for any confusion this may have caused.
>
> What I want to do is to have libaxis_xmlparser.so in LD_LIBRARY_PATH when
> the clients run. Apart from the option that you mentioned is there any
other
> way that this can be achieved? How about when the tests are run I create
> libaxis_xmlparser.so from the parser specified in
build.PLATFORM.properties
> in the "package bin" folder from what is in the package folder and point
> LD_LIBRARY_PATH there?
Rather than copying/renaming the file, we could update axiscpp.conf with
the appropriate parser library name.
>
> may be it is a trivial thing to change the PARSER.xmlParserLibraryName in
> build.PLATFORM.properties with the "general parse library name". but I
would
> rather set a true or false value to get this done. What do you think?
>
Indeed ... what I meant, was having a true/false value in the property file
(or a -D...=true when running), and the test script would then
appropriately update the property. Having to change the actual property
files is, as you say, trivial, but is also tedious.
You can use <propertycopy/> from ant-contrib to do this in the ANT scripts.
> sanjaya.
>
> ----- Original Message -----
> From: "Adrian Dick" <ad...@uk.ibm.com>
> To: <ax...@ws.apache.org>
> Sent: Wednesday, March 23, 2005 11:37 PM
> Subject: Re: cvs commit: ws-axis/c/build testInitialize.xml
>
>
> > Hi,
> >
> > This fix is not suitable, and indeed breaks completely for our
automated
> > test systems here.
> > We carry out all our testing as a customer would be expected, having
> access
> > to just the binary package. Unfortunately, this means the files you're
> > attempting to work with do not exist, causing ANT to fail.
> >
> > There are several issues that come to mind as I look at this particular
> > fix:
> > - Why are we renaming built libraries?
> > Either the test needs to cope with what it's given, or there's a
> > problem in the build and package steps.
> > In this particular case, the test script needs to determine which
of
> > the XML parsers it wishes to test with, and use directly:
> > - Why are we working with files in obj/bin?
> > Surely we should be testing against the packaged
(obj/package/....)
> > structure, as we provide to our customers?
> >
> >
> > I have added failonerror="false" to the copy task, which prevents ANT
from
> > failing. I also needed to replicate a number of new properties you've
> > recently added to build.linux.properties across to the properties files
> for
> > the other platforms.
> >
> > However, I am still not happy with this being done. I would much
prefer
> > that we set a property for the desired xmlparser library name ...
perhaps
> > overriding ${xmlParserLibraryName} with the appropriate choice of
> > ${xml4c.xmlParserLibraryName} or ${xerces.xmlParserLibraryName}, where
the
> > copy is currently taking place.
> >
> > Regards,
> > Adrian
> > _______________________________________
> > Adrian Dick (adrian.dick@uk.ibm.com)
> > WebSphere MQ and ESB Development
> > Tel: +44-(0)-1962-819212
> > Notes: Adrian Dick/UK/IBM@IBMGB
> >
> > sanjaya@apache.org wrote on 23/03/2005 09:31:30:
> >
> > > sanjaya 2005/03/23 01:31:30
> > >
> > > Modified: c/build testInitialize.xml
> > > Log:
> > > added changes to copy parser specific library to generic parser
> > > library name in ${dir.bin}
> > >
> > > Revision Changes Path
> > > 1.3 +13 -1 ws-axis/c/build/testInitialize.xml
> > >
> > > Index: testInitialize.xml
> > > ===================================================================
> > > RCS file: /home/cvs/ws-axis/c/build/testInitialize.xml,v
> > > retrieving revision 1.2
> > > retrieving revision 1.3
> > > diff -u -r1.2 -r1.3
> > > --- testInitialize.xml 8 Feb 2005 15:24:19 -0000 1.2
> > > +++ testInitialize.xml 23 Mar 2005 09:31:30 -0000 1.3
> > > @@ -16,7 +16,19 @@
> > > <isset property="windows"/>
> > > </not>
> > > </condition>
> > > - </target>
> > > +
> > > + <!-- set the built lib for the selected client partser -->
> > > + <condition property="selectedClientParserLib"
> > >
value="${libraryPrefix}${xml4c.xmlParserLibraryName}${librarySuffix}">
> > > + <istrue value="${testconf.client.parser.xml4c}"/>
> > > + </condition>
> > > + <condition property="selectedClientParserLib"
> > >
value="${libraryPrefix}${xerces.xmlParserLibraryName}${librarySuffix}">
> > > + <istrue value="${testconf.client.parser.xerces}"/>
> > > + </condition>
> > > + <!-- make a copy of the parser specfic library with the
> > > general parser library name -->
> > > + <copy file="${dir.bin}/${selectedClientParserLib}"
> > >
> >
>
tofile="${dir.bin}/${libraryPrefix}${xmlParserLibraryName}${librarySuffix}"/
> >
> >
> > > +
> > > +</target>
> > > +
> > >
> > > <target name="initializeLogFile">
> > > <mkdir dir="${dir.results}"/>
> > >
> > >
> > >
> >
> >
>
>
Re: cvs commit: ws-axis/c/build testInitialize.xml
Posted by sanjaya singharage <sa...@opensource.lk>.
sorry about this. I was going to compose a mail to inform about this change.
why I did this was because when the client test suit is run we have to
manually have a libaxis_xmlparser.so in LD_LIBRARY_PATH not
libaxis_xerces.so or some other parser specific library. as I understand
both parser libraries can be built if set to true in the
build.PLATFORM.properties file?
I will revert this change. sorry about breaking your test runs.
build/executeTest.xml:
<env key="LD_LIBRARY_PATH"
path="${dir.libraries}${path.separator}${dir.xmlParser}${path.separator}${HT
TP.SSLChannel.dir}/lib${path.separator}${test.directory}"/>
and...
build/build.Linux.properties:dir.libraries = ${dir.bin}
correct me if I am wrong. but doesn't this use the binaries in the bin
directory? If you don't have the bin directories I don't understand how the
tests can be run.
What I want to do is to have libaxis_xmlparser.so in LD_LIBRARY_PATH when
the clients run. Apart from the option that you mentioned is there any other
way that this can be achieved? How about when the tests are run I create
libaxis_xmlparser.so from the parser specified in build.PLATFORM.properties
in the "package bin" folder from what is in the package folder and point
LD_LIBRARY_PATH there?
may be it is a trivial thing to change the PARSER.xmlParserLibraryName in
build.PLATFORM.properties with the "general parse library name". but I would
rather set a true or false value to get this done. What do you think?
sanjaya.
----- Original Message -----
From: "Adrian Dick" <ad...@uk.ibm.com>
To: <ax...@ws.apache.org>
Sent: Wednesday, March 23, 2005 11:37 PM
Subject: Re: cvs commit: ws-axis/c/build testInitialize.xml
> Hi,
>
> This fix is not suitable, and indeed breaks completely for our automated
> test systems here.
> We carry out all our testing as a customer would be expected, having
access
> to just the binary package. Unfortunately, this means the files you're
> attempting to work with do not exist, causing ANT to fail.
>
> There are several issues that come to mind as I look at this particular
> fix:
> - Why are we renaming built libraries?
> Either the test needs to cope with what it's given, or there's a
> problem in the build and package steps.
> In this particular case, the test script needs to determine which of
> the XML parsers it wishes to test with, and use directly:
> - Why are we working with files in obj/bin?
> Surely we should be testing against the packaged (obj/package/....)
> structure, as we provide to our customers?
>
>
> I have added failonerror="false" to the copy task, which prevents ANT from
> failing. I also needed to replicate a number of new properties you've
> recently added to build.linux.properties across to the properties files
for
> the other platforms.
>
> However, I am still not happy with this being done. I would much prefer
> that we set a property for the desired xmlparser library name ... perhaps
> overriding ${xmlParserLibraryName} with the appropriate choice of
> ${xml4c.xmlParserLibraryName} or ${xerces.xmlParserLibraryName}, where the
> copy is currently taking place.
>
> Regards,
> Adrian
> _______________________________________
> Adrian Dick (adrian.dick@uk.ibm.com)
> WebSphere MQ and ESB Development
> Tel: +44-(0)-1962-819212
> Notes: Adrian Dick/UK/IBM@IBMGB
>
> sanjaya@apache.org wrote on 23/03/2005 09:31:30:
>
> > sanjaya 2005/03/23 01:31:30
> >
> > Modified: c/build testInitialize.xml
> > Log:
> > added changes to copy parser specific library to generic parser
> > library name in ${dir.bin}
> >
> > Revision Changes Path
> > 1.3 +13 -1 ws-axis/c/build/testInitialize.xml
> >
> > Index: testInitialize.xml
> > ===================================================================
> > RCS file: /home/cvs/ws-axis/c/build/testInitialize.xml,v
> > retrieving revision 1.2
> > retrieving revision 1.3
> > diff -u -r1.2 -r1.3
> > --- testInitialize.xml 8 Feb 2005 15:24:19 -0000 1.2
> > +++ testInitialize.xml 23 Mar 2005 09:31:30 -0000 1.3
> > @@ -16,7 +16,19 @@
> > <isset property="windows"/>
> > </not>
> > </condition>
> > - </target>
> > +
> > + <!-- set the built lib for the selected client partser -->
> > + <condition property="selectedClientParserLib"
> > value="${libraryPrefix}${xml4c.xmlParserLibraryName}${librarySuffix}">
> > + <istrue value="${testconf.client.parser.xml4c}"/>
> > + </condition>
> > + <condition property="selectedClientParserLib"
> > value="${libraryPrefix}${xerces.xmlParserLibraryName}${librarySuffix}">
> > + <istrue value="${testconf.client.parser.xerces}"/>
> > + </condition>
> > + <!-- make a copy of the parser specfic library with the
> > general parser library name -->
> > + <copy file="${dir.bin}/${selectedClientParserLib}"
> >
>
tofile="${dir.bin}/${libraryPrefix}${xmlParserLibraryName}${librarySuffix}"/
>
>
> > +
> > +</target>
> > +
> >
> > <target name="initializeLogFile">
> > <mkdir dir="${dir.results}"/>
> >
> >
> >
>
>
Re: cvs commit: ws-axis/c/build testInitialize.xml
Posted by Adrian Dick <ad...@uk.ibm.com>.
Hi,
This fix is not suitable, and indeed breaks completely for our automated
test systems here.
We carry out all our testing as a customer would be expected, having access
to just the binary package. Unfortunately, this means the files you're
attempting to work with do not exist, causing ANT to fail.
There are several issues that come to mind as I look at this particular
fix:
- Why are we renaming built libraries?
Either the test needs to cope with what it's given, or there's a
problem in the build and package steps.
In this particular case, the test script needs to determine which of
the XML parsers it wishes to test with, and use directly:
- Why are we working with files in obj/bin?
Surely we should be testing against the packaged (obj/package/....)
structure, as we provide to our customers?
I have added failonerror="false" to the copy task, which prevents ANT from
failing. I also needed to replicate a number of new properties you've
recently added to build.linux.properties across to the properties files for
the other platforms.
However, I am still not happy with this being done. I would much prefer
that we set a property for the desired xmlparser library name ... perhaps
overriding ${xmlParserLibraryName} with the appropriate choice of
${xml4c.xmlParserLibraryName} or ${xerces.xmlParserLibraryName}, where the
copy is currently taking place.
Regards,
Adrian
_______________________________________
Adrian Dick (adrian.dick@uk.ibm.com)
WebSphere MQ and ESB Development
Tel: +44-(0)-1962-819212
Notes: Adrian Dick/UK/IBM@IBMGB
sanjaya@apache.org wrote on 23/03/2005 09:31:30:
> sanjaya 2005/03/23 01:31:30
>
> Modified: c/build testInitialize.xml
> Log:
> added changes to copy parser specific library to generic parser
> library name in ${dir.bin}
>
> Revision Changes Path
> 1.3 +13 -1 ws-axis/c/build/testInitialize.xml
>
> Index: testInitialize.xml
> ===================================================================
> RCS file: /home/cvs/ws-axis/c/build/testInitialize.xml,v
> retrieving revision 1.2
> retrieving revision 1.3
> diff -u -r1.2 -r1.3
> --- testInitialize.xml 8 Feb 2005 15:24:19 -0000 1.2
> +++ testInitialize.xml 23 Mar 2005 09:31:30 -0000 1.3
> @@ -16,7 +16,19 @@
> <isset property="windows"/>
> </not>
> </condition>
> - </target>
> +
> + <!-- set the built lib for the selected client partser -->
> + <condition property="selectedClientParserLib"
> value="${libraryPrefix}${xml4c.xmlParserLibraryName}${librarySuffix}">
> + <istrue value="${testconf.client.parser.xml4c}"/>
> + </condition>
> + <condition property="selectedClientParserLib"
> value="${libraryPrefix}${xerces.xmlParserLibraryName}${librarySuffix}">
> + <istrue value="${testconf.client.parser.xerces}"/>
> + </condition>
> + <!-- make a copy of the parser specfic library with the
> general parser library name -->
> + <copy file="${dir.bin}/${selectedClientParserLib}"
>
tofile="${dir.bin}/${libraryPrefix}${xmlParserLibraryName}${librarySuffix}"/>
> +
> +</target>
> +
>
> <target name="initializeLogFile">
> <mkdir dir="${dir.results}"/>
>
>
>