[GitHub] [kafka] satishd commented on a diff in pull request #14427: KAFKA-15485: Fix "this-escape" compiler warnings introduced by JDK 21 (1/N)

["satishd (via GitHub)" <gi...@apache.org>]

satishd commented on code in PR #14427:
URL: https://github.com/apache/kafka/pull/14427#discussion_r1334967466


##########
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##########
@@ -50,6 +50,7 @@ public class RemoteLogMetadataSerde {
     private final Map<Short, RemoteLogMetadataTransform> keyToTransform;
     private final BytesApiMessageSerde bytesApiMessageSerde;
 
+    @SuppressWarnings("this-escape")

Review Comment:
   It is not a public API. We should be able to make any required changes to this class without worrying about API compatibility. 
   
   We plan to build a tool to inspect messages in the remote log metadata topic. That tool may use some of these classes in future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org