[GitHub] [airflow] leahecole commented on pull request #17271: update return value for sql, template and flex template operators

[GitBox <gi...@apache.org>]

leahecole commented on pull request #17271:
URL: https://github.com/apache/airflow/pull/17271#issuecomment-896301055


   Hey @orossini ! I saw you pinged me internally about what kind of tests to add and to be as Airflow-y as possible I'm replying here so other non Googlers can also reply 😄 I haven't poked around in awhile with GCP operator system tests, but I'm remembering that @rachael-ds did so earlier this year in #14033. 
   
   Judging by that PR, I think the tests you should look at are (I didn't look super closely so I'm not sure if you need both, but you may)
   
   * [Dataflow test](https://github.com/apache/airflow/blob/main/tests/providers/google/cloud/operators/test_dataflow.py)
   * [Dataflow System Test](https://github.com/apache/airflow/blob/main/tests/providers/google/cloud/operators/test_dataflow_system.py)
   
   
   Additionally, you might want to double check the example DAGs
   * [Dataflow](https://github.com/apache/airflow/blob/main/airflow/providers/google/cloud/example_dags/example_dataflow.py)
   * [Dataflow Flex Templates](https://github.com/apache/airflow/blob/main/airflow/providers/google/cloud/example_dags/example_dataflow_flex_template.py)
   * [Dataflow SQL](https://github.com/apache/airflow/blob/main/airflow/providers/google/cloud/example_dags/example_dataflow_sql.py)
   
   And double check the [Dataflow docs](https://github.com/apache/airflow/blob/main/docs/apache-airflow-providers-google/operators/cloud/dataflow.rst)
   
   You may notice a couple other files in Rachael's PR I didn't recommend here (like the `test_project_structure` file) - that's because in addition to changing the behavior of an operator she also changed the name of one that had a typo, which required a few additional checks. 
   
   @potiuk or anyone else, please feel free to chime in if I missed something or if any of the files I've mentioned are autogenerated - I'm pretty weak on how our tests work in general so I'm excited to learn too 😄 
   
   
   And, in case folks are wondering what's taking Olivier awhile, I did notice from his work calendar that he's OOO this week so @orossini plz don't worry about this til you're back online! 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org