You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/07/06 20:50:32 UTC

Review Request 67848: Installed CSI bindings as part of Mesos.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67848/
-----------------------------------------------------------

Review request for mesos and Chun-Hung Hsiao.


Repository: mesos


Description
-------

Mesos is tightly coupled against a particular CSI version. This patch
adds CSI protobuf definitions and generated headers to the headers
installed by Mesos. We install the headers into a Mesos include
directory to allow users to have other CSI headers installed.


Diffs
-----

  include/csi/spec.hpp  
  include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc 
  src/Makefile.am 3ac1e1ce650d7238c108d0ac4123228500053a6f 
  src/csi/client.hpp 5d40d54c2abbd03993ce8835d37db23e209c7554 
  src/csi/rpc.hpp c30a5091b0daedb58bc93385cf236ad93fef721d 
  src/csi/utils.hpp 5ce318e52bc39555ca09bf68dca6dedea988e5a4 
  src/examples/test_csi_plugin.cpp 9c4da8811cc260bcf3bccfea3036a7964cb75697 
  src/resource_provider/storage/disk_profile_adaptor.cpp 7c3aa1614e995889c8587867e8c40483641216d4 
  src/resource_provider/storage/disk_profile_utils.hpp 8a83a15ba555ce66bbb86b8df72178bce17a615a 
  src/resource_provider/storage/uri_disk_profile_adaptor.hpp 0484933b42d0bd66c689b06cb48f492eef7bc606 
  src/resource_provider/storage/uri_disk_profile_adaptor.cpp 614590ef7d1c0cc1df99b8e57c7fbd496793b5a7 
  src/tests/mock_csi_plugin.hpp 4642326b65ba7145bc57ac4a56d492697a7501b9 


Diff: https://reviews.apache.org/r/67848/diff/1/


Testing
-------

`make distcheck`


Thanks,

Benjamin Bannier

Re: Review Request 67848: Installed CSI bindings as part of Mesos.

Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67848/#review205945
-----------------------------------------------------------




src/Makefile.am
Lines 1536 (patched)
<https://reviews.apache.org/r/67848/#comment288869>

    I'm thinking that, if the install path is `$PREFIX/include/mesos/csi/csi.pb.h`, then should we also generate it under `$build_dir)/include/mesos/csi/csi.pb.h` to make the structure more consistent?
    
    Also I'm not sure if `#include <csi/csi.pb.h>` in `spec.hpp` would work due to the inconsistent path.
    
    Ditto below.


- Chun-Hung Hsiao


On July 6, 2018, 8:50 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67848/
> -----------------------------------------------------------
> 
> (Updated July 6, 2018, 8:50 p.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Mesos is tightly coupled against a particular CSI version. This patch
> adds CSI protobuf definitions and generated headers to the headers
> installed by Mesos. We install the headers into a Mesos include
> directory to allow users to have other CSI headers installed.
> 
> 
> Diffs
> -----
> 
>   include/csi/spec.hpp  
>   include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc 
>   src/Makefile.am 3ac1e1ce650d7238c108d0ac4123228500053a6f 
>   src/csi/client.hpp 5d40d54c2abbd03993ce8835d37db23e209c7554 
>   src/csi/rpc.hpp c30a5091b0daedb58bc93385cf236ad93fef721d 
>   src/csi/utils.hpp 5ce318e52bc39555ca09bf68dca6dedea988e5a4 
>   src/examples/test_csi_plugin.cpp 9c4da8811cc260bcf3bccfea3036a7964cb75697 
>   src/resource_provider/storage/disk_profile_adaptor.cpp 7c3aa1614e995889c8587867e8c40483641216d4 
>   src/resource_provider/storage/disk_profile_utils.hpp 8a83a15ba555ce66bbb86b8df72178bce17a615a 
>   src/resource_provider/storage/uri_disk_profile_adaptor.hpp 0484933b42d0bd66c689b06cb48f492eef7bc606 
>   src/resource_provider/storage/uri_disk_profile_adaptor.cpp 614590ef7d1c0cc1df99b8e57c7fbd496793b5a7 
>   src/tests/mock_csi_plugin.hpp 4642326b65ba7145bc57ac4a56d492697a7501b9 
> 
> 
> Diff: https://reviews.apache.org/r/67848/diff/1/
> 
> 
> Testing
> -------
> 
> `make distcheck`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>