You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/02 14:58:59 UTC

[GitHub] [flink] JingGe commented on a change in pull request #18825: [FLINK-26126][kafka] fix numRecordsOut metric error

JingGe commented on a change in pull request #18825:
URL: https://github.com/apache/flink/pull/18825#discussion_r817774909



##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java
##########
@@ -406,6 +409,7 @@ public WriterCallback(
         @Override
         public void onCompletion(RecordMetadata metadata, Exception exception) {
             if (exception != null) {
+                numRecordsOutErrorsCounter.inc();

Review comment:
       This is on the unhappy path that is normally not covered by ITCase. Do you have any idea on how to test it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org