You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "wangyepeng2 (via GitHub)" <gi...@apache.org> on 2023/03/30 13:08:10 UTC
[GitHub] [kyuubi] wangyepeng2 opened a new pull request, #4640: [KYUUBI #3872] fix:spark batch submit should not set proxy user when keytab is used
wangyepeng2 opened a new pull request, #4640:
URL: https://github.com/apache/kyuubi/pull/4640
see detail description in issue [KYUUBI #3872]
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [X] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 closed pull request #4640: [KYUUBI #3872][BATCH] Skip setting proxy user when keytab is provided
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #4640: [KYUUBI #3872][BATCH] Skip setting proxy user when keytab is provided
URL: https://github.com/apache/kyuubi/pull/4640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] codecov-commenter commented on pull request #4640: [KYUUBI #3872][BATCH] Skip setting proxy user when keytab is provided
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4640:
URL: https://github.com/apache/kyuubi/pull/4640#issuecomment-1490452460
## [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4640?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4640](https://codecov.io/gh/apache/kyuubi/pull/4640?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (63fc5de) into [master](https://codecov.io/gh/apache/kyuubi/commit/36927551c19535422d4201b957c863881833a539?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3692755) will **increase** coverage by `3.98%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 63fc5de differs from pull request most recent head c7228b9. Consider uploading reports for the commit c7228b9 to get more accurate results
```diff
@@ Coverage Diff @@
## master #4640 +/- ##
============================================
+ Coverage 53.61% 57.60% +3.98%
Complexity 13 13
============================================
Files 579 579
Lines 31816 31901 +85
Branches 4254 4263 +9
============================================
+ Hits 17057 18375 +1318
+ Misses 13172 11770 -1402
- Partials 1587 1756 +169
```
| [Impacted Files](https://codecov.io/gh/apache/kyuubi/pull/4640?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...kyuubi/engine/spark/SparkBatchProcessBuilder.scala](https://codecov.io/gh/apache/kyuubi/pull/4640?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvc3BhcmsvU3BhcmtCYXRjaFByb2Nlc3NCdWlsZGVyLnNjYWxh) | `96.87% <100.00%> (-0.19%)` | :arrow_down: |
| [...ache/kyuubi/engine/spark/SparkProcessBuilder.scala](https://codecov.io/gh/apache/kyuubi/pull/4640?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvc3BhcmsvU3BhcmtQcm9jZXNzQnVpbGRlci5zY2FsYQ==) | `84.31% <100.00%> (+0.15%)` | :arrow_up: |
... and [47 files with indirect coverage changes](https://codecov.io/gh/apache/kyuubi/pull/4640/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4640: [KYUUBI #3872][BATCH] Skip setting proxy user when keytab is provided
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4640:
URL: https://github.com/apache/kyuubi/pull/4640#issuecomment-1490760065
Thanks, merged to master/1.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4640: [KYUUBI #3872] fix:spark batch submit should not set proxy user when keytab is used
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #4640:
URL: https://github.com/apache/kyuubi/pull/4640#discussion_r1153249981
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilder.scala:
##########
@@ -121,6 +121,16 @@ class SparkProcessBuilder(
buffer += s"${convertConfigKey(k)}=$v"
}
+ setUser(buffer)
+
+ mainResource.foreach { r => buffer += r }
+
+ buffer.toArray
+ }
+
+ override protected def module: String = "kyuubi-spark-sql-engine"
+
+ def setUser(buffer: ArrayBuffer[String]): Unit = {
Review Comment:
let's name it `setupKerberos` and use `protected`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4640: [KYUUBI #3872][BATCH] Skip setting proxy user when keytab is provided
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #4640:
URL: https://github.com/apache/kyuubi/pull/4640#discussion_r1153388670
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilder.scala:
##########
@@ -121,6 +121,16 @@ class SparkProcessBuilder(
buffer += s"${convertConfigKey(k)}=$v"
}
+ setUser(buffer)
Review Comment:
```suggestion
setupKerberos(buffer)
```
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/spark/SparkBatchProcessBuilder.scala:
##########
@@ -56,9 +56,7 @@ class SparkBatchProcessBuilder(
buffer += s"${convertConfigKey(k)}=$v"
}
- setSparkUserName(proxyUser, buffer)
- buffer += PROXY_USER
- buffer += proxyUser
+ setUser(buffer)
Review Comment:
```suggestion
setupKerberos(buffer)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org