[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19754: [fix][meta] Fix deadlock causes session notification is not to work

["mattisonchao (via GitHub)" <gi...@apache.org>]

mattisonchao commented on code in PR #19754:
URL: https://github.com/apache/pulsar/pull/19754#discussion_r1129772399


##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/coordination/impl/LeaderElectionImpl.java:
##########
@@ -111,13 +112,13 @@ private synchronized CompletableFuture<LeaderElectionState> elect() {
             } else {
                 return tryToBecomeLeader();
             }
-        }).thenComposeAsync(leaderElectionState -> {
+        }).thenCompose(leaderElectionState -> {
             // make sure that the cache contains the current leader
             // so that getLeaderValueIfPresent works on all brokers
             cache.refresh(path);

Review Comment:
   I checked the logic, this method looks changed, no blocking call here. /cc @lhotari 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org