You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/06/21 22:00:27 UTC
Review Request 60311: Windows: Replaced use of `_stat()` with
`os::stat::isdir()`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60311/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, Joseph Wu, Li Li, and Michael Park.
Bugs: MESOS-6817, MESOS-7371 and MESOS-7407
https://issues.apache.org/jira/browse/MESOS-6817
https://issues.apache.org/jira/browse/MESOS-7371
https://issues.apache.org/jira/browse/MESOS-7407
Repository: mesos
Description
-------
This removes hairy, duplicated code which did not support long paths.
Diffs
-----
3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp a9228437bc1b2b287dd19cb9903ce048db2a90ef
Diff: https://reviews.apache.org/r/60311/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 60311: Windows: Replaced use of `_stat()` with
`os::stat::isdir()`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60311/#review179942
-----------------------------------------------------------
Fix it, then Ship it!
I'll make some tweaks before committing.
3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
Lines 194-195 (patched)
<https://reviews.apache.org/r/60311/#comment254898>
Needs some error handling.
3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
Lines 323-328 (original), 331-332 (patched)
<https://reviews.apache.org/r/60311/#comment254881>
Hm... a previous patch ( https://reviews.apache.org/r/60308/ ) explicitly made `reparsepoint.hpp` depend on `stat.hpp`. It is better to avoid forward declaring a function that is defined in a separate header.
So here, we should (unfortunately or not) copy the `get_file_attributes` logic over again.
- Joseph Wu
On June 21, 2017, 3 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60311/
> -----------------------------------------------------------
>
> (Updated June 21, 2017, 3 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, Joseph Wu, Li Li, and Michael Park.
>
>
> Bugs: MESOS-6817, MESOS-7371 and MESOS-7407
> https://issues.apache.org/jira/browse/MESOS-6817
> https://issues.apache.org/jira/browse/MESOS-7371
> https://issues.apache.org/jira/browse/MESOS-7407
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This removes hairy, duplicated code which did not support long paths.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp a9228437bc1b2b287dd19cb9903ce048db2a90ef
>
>
> Diff: https://reviews.apache.org/r/60311/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>