You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2015/11/26 07:52:58 UTC

Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40731/
-----------------------------------------------------------

Review request for mesos, Bernd Mathiske, Klaus Ma, and Neil Conway.


Bugs: 3552
    https://issues.apache.org/jira/browse/3552


Repository: mesos


Description
-------

Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/


Diffs
-----

  src/tests/reservation_tests.cpp 15d180f92ec0aea99e6f3a7d0b505c62bd207b61 

Diff: https://reviews.apache.org/r/40731/diff/


Testing
-------

Ran make check after adding Mandeep's test case to the GTEST framework.


Thanks,

Avinash sridharan


Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

Posted by Bernd Mathiske <be...@mesosphere.io>.

> On Nov. 30, 2015, 6:15 a.m., Bernd Mathiske wrote:
> > src/tests/reservation_tests.cpp, line 248
> > <https://reviews.apache.org/r/40731/diff/1/?file=1147237#file1147237line248>
> >
> >     s/RESERVE/UNRESERVE/ ?
> >     
> >     What is the intention here? Please explain.
> 
> Avinash sridharan wrote:
>     Can you clarify this comment? The idea here seems to be to generate multiple CPU resource requests. Hence the RESERVE?

The misleading comment near this is gone and a new one is there that addresses the issue. Thx


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40731/#review108313
-----------------------------------------------------------


On Dec. 2, 2015, 12:27 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40731/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 12:27 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Klaus Ma, Mandeep Chadha, and Neil Conway.
> 
> 
> Bugs: MESOS-3552
>     https://issues.apache.org/jira/browse/MESOS-3552
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/
> 
> 
> Diffs
> -----
> 
>   src/tests/reservation_tests.cpp e7f14079e766ce0a8bad2da646776347e4a17169 
> 
> Diff: https://reviews.apache.org/r/40731/diff/
> 
> 
> Testing
> -------
> 
> Ran make check after adding Mandeep's test case to the GTEST framework.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

Posted by Avinash sridharan <av...@mesosphere.io>.

> On Nov. 30, 2015, 2:15 p.m., Bernd Mathiske wrote:
> > src/tests/reservation_tests.cpp, line 176
> > <https://reviews.apache.org/r/40731/diff/1/?file=1147237#file1147237line176>
> >
> >     Also see the indentations in various other statements involving argument passing, etc. Best to sit down with one of us at the same screen and then clean up all these indentations in one swoop. Respectively see: 
> >     http://mesos.apache.org/documentation/latest/c++-style-guide/

Tried following the style guide as closely as possible. If we still see some missing style errors will sit with one of the core folks here and fix it.


> On Nov. 30, 2015, 2:15 p.m., Bernd Mathiske wrote:
> > src/tests/reservation_tests.cpp, line 248
> > <https://reviews.apache.org/r/40731/diff/1/?file=1147237#file1147237line248>
> >
> >     s/RESERVE/UNRESERVE/ ?
> >     
> >     What is the intention here? Please explain.

Can you clarify this comment? The idea here seems to be to generate multiple CPU resource requests. Hence the RESERVE?


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40731/#review108313
-----------------------------------------------------------


On Dec. 2, 2015, 8:27 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40731/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 8:27 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Klaus Ma, Mandeep Chadha, and Neil Conway.
> 
> 
> Bugs: MESOS-3552
>     https://issues.apache.org/jira/browse/MESOS-3552
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/
> 
> 
> Diffs
> -----
> 
>   src/tests/reservation_tests.cpp e7f14079e766ce0a8bad2da646776347e4a17169 
> 
> Diff: https://reviews.apache.org/r/40731/diff/
> 
> 
> Testing
> -------
> 
> Ran make check after adding Mandeep's test case to the GTEST framework.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40731/#review108313
-----------------------------------------------------------



src/tests/reservation_tests.cpp (line 168)
<https://reviews.apache.org/r/40731/#comment167714>

    s/double/a double
    
    But the whole sentence is warped. Suggestion:
    
    "This involves a value for CPUs of type double, which triggers a problematic floating point comparison."



src/tests/reservation_tests.cpp (line 172)
<https://reviews.apache.org/r/40731/#comment167730>

    Please write a comment in the code below that explains where the comparison occurs.



src/tests/reservation_tests.cpp (line 173)
<https://reviews.apache.org/r/40731/#comment167715>

    s/with/with an/



src/tests/reservation_tests.cpp (line 176)
<https://reviews.apache.org/r/40731/#comment167717>

    Also see the indentations in various other statements involving argument passing, etc. Best to sit down with one of us at the same screen and then clean up all these indentations in one swoop. Respectively see: 
    http://mesos.apache.org/documentation/latest/c++-style-guide/



src/tests/reservation_tests.cpp (line 198)
<https://reviews.apache.org/r/40731/#comment167718>

    This can be made less ambigous:
    
    "We apply a filter that causes these resources not to be filtered (default would be 5 seconds).



src/tests/reservation_tests.cpp (line 208)
<https://reviews.apache.org/r/40731/#comment167719>

    s/We use this to/
    
    Redundant.



src/tests/reservation_tests.cpp (line 219)
<https://reviews.apache.org/r/40731/#comment167722>

    This comment pertains to line 225, not 220.



src/tests/reservation_tests.cpp (line 227)
<https://reviews.apache.org/r/40731/#comment167725>

    If you use "next" here and below for two different offers, it gets confusing. Better "second", "third".



src/tests/reservation_tests.cpp (line 235)
<https://reviews.apache.org/r/40731/#comment167723>

    This comment seems to belong to line 241.



src/tests/reservation_tests.cpp (line 239)
<https://reviews.apache.org/r/40731/#comment167727>

    Better to use freah variables like offer 2, offer3. It will be easier to grasp where in the algorithm we are then.



src/tests/reservation_tests.cpp (line 248)
<https://reviews.apache.org/r/40731/#comment167731>

    s/RESERVE/UNRESERVE/ ?
    
    What is the intention here? Please explain.



src/tests/reservation_tests.cpp (line 251)
<https://reviews.apache.org/r/40731/#comment167724>

    This comment pertains to line 257.
    
    s/reserved/unreserved/ ?


- Bernd Mathiske


On Nov. 30, 2015, 5:39 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40731/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2015, 5:39 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Klaus Ma, and Neil Conway.
> 
> 
> Bugs: MESOS-3552
>     https://issues.apache.org/jira/browse/MESOS-3552
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/
> 
> 
> Diffs
> -----
> 
>   src/tests/reservation_tests.cpp 15d180f92ec0aea99e6f3a7d0b505c62bd207b61 
> 
> Diff: https://reviews.apache.org/r/40731/diff/
> 
> 
> Testing
> -------
> 
> Ran make check after adding Mandeep's test case to the GTEST framework.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40731/
-----------------------------------------------------------

(Updated Dec. 2, 2015, 8:23 a.m.)


Review request for mesos, Bernd Mathiske, Klaus Ma, and Neil Conway.


Bugs: MESOS-3552
    https://issues.apache.org/jira/browse/MESOS-3552


Repository: mesos


Description
-------

Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/


Diffs (updated)
-----

  src/tests/reservation_tests.cpp e7f14079e766ce0a8bad2da646776347e4a17169 

Diff: https://reviews.apache.org/r/40731/diff/


Testing
-------

Ran make check after adding Mandeep's test case to the GTEST framework.


Thanks,

Avinash sridharan


Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40731/
-----------------------------------------------------------

(Updated Nov. 30, 2015, 5:39 a.m.)


Review request for mesos, Bernd Mathiske, Klaus Ma, and Neil Conway.


Changes
-------

Fixed the link to the JIRA issue.


Bugs: MESOS-3552
    https://issues.apache.org/jira/browse/MESOS-3552


Repository: mesos


Description
-------

Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/


Diffs
-----

  src/tests/reservation_tests.cpp 15d180f92ec0aea99e6f3a7d0b505c62bd207b61 

Diff: https://reviews.apache.org/r/40731/diff/


Testing
-------

Ran make check after adding Mandeep's test case to the GTEST framework.


Thanks,

Avinash sridharan


Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40731/#review108119
-----------------------------------------------------------


Patch looks great!

Reviews applied: [40730, 40731]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 26, 2015, 6:52 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40731/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2015, 6:52 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Klaus Ma, and Neil Conway.
> 
> 
> Bugs: 3552
>     https://issues.apache.org/jira/browse/3552
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/
> 
> 
> Diffs
> -----
> 
>   src/tests/reservation_tests.cpp 15d180f92ec0aea99e6f3a7d0b505c62bd207b61 
> 
> Diff: https://reviews.apache.org/r/40731/diff/
> 
> 
> Testing
> -------
> 
> Ran make check after adding Mandeep's test case to the GTEST framework.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40731/#review108142
-----------------------------------------------------------



src/tests/reservation_tests.cpp (line 163)
<https://reviews.apache.org/r/40731/#comment167494>

    In Mesos, we use two blank lines to separate function definitions.



src/tests/reservation_tests.cpp (line 176)
<https://reviews.apache.org/r/40731/#comment167496>

    The whitespace is wrong here: Mesos uses an indentation offset of 2 spaces, not 8. For more on the style requirements, see https://mesos.apache.org/documentation/latest/c++-style-guide/


- Neil Conway


On Nov. 26, 2015, 6:52 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40731/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2015, 6:52 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Klaus Ma, and Neil Conway.
> 
> 
> Bugs: 3552
>     https://issues.apache.org/jira/browse/3552
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/
> 
> 
> Diffs
> -----
> 
>   src/tests/reservation_tests.cpp 15d180f92ec0aea99e6f3a7d0b505c62bd207b61 
> 
> Diff: https://reviews.apache.org/r/40731/diff/
> 
> 
> Testing
> -------
> 
> Ran make check after adding Mandeep's test case to the GTEST framework.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>