You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "jmark99 (via GitHub)" <gi...@apache.org> on 2023/08/10 18:14:30 UTC
[GitHub] [accumulo] jmark99 opened a new pull request, #3681: Remove getTabletHostingGoal method from TableOperations
jmark99 opened a new pull request, #3681:
URL: https://github.com/apache/accumulo/pull/3681
Remove the `getTabletHostingGoal` method from `TableOperations` as the information can now be retrieved with the more robust `getTabletInformation` method.
The shell command, `getgoals`, still works as before, but the `GetTabletHostingGoalCommand` was updated to use the new `getTabletInformation` method to retrieve the necessary information rather than the removed `getTabletHostingGoal` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] jmark99 merged pull request #3681: Remove getTabletHostingGoal method from TableOperations
Posted by "jmark99 (via GitHub)" <gi...@apache.org>.
jmark99 merged PR #3681:
URL: https://github.com/apache/accumulo/pull/3681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on a diff in pull request #3681: Remove getTabletHostingGoal method from TableOperations
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #3681:
URL: https://github.com/apache/accumulo/pull/3681#discussion_r1290848998
##########
shell/src/main/java/org/apache/accumulo/shell/commands/GetTabletHostingGoalCommand.java:
##########
@@ -48,11 +48,11 @@ public String description() {
@Override
protected void doTableOp(Shell shellState, String tableName) throws Exception {
- List<HostingGoalForTablet> tabletHostingGoal = shellState.getAccumuloClient().tableOperations()
- .getTabletHostingGoal(tableName, range).collect(Collectors.toList());
+ List<TabletInformation> tabletInformationList = shellState.getAccumuloClient().tableOperations()
+ .getTabletInformation(tableName, range).collect(Collectors.toList());
shellState.getWriter().println("TABLE: " + tableName);
shellState.getWriter().println("TABLET ID HOSTING GOAL");
- tabletHostingGoal.forEach(p -> shellState.getWriter()
+ tabletInformationList.forEach(p -> shellState.getWriter()
Review Comment:
May be able to do something like the following and avoid creating the list.
```suggestion
shellState.getAccumuloClient().tableOperations()
.getTabletInformation(tableName, range).forEach(p -> shellState.getWriter()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org