[jira] [Commented] (SOLR-16129) Solr specific InputStreamResponseListener to prevent client threads from hanging forever

["Chris M. Hostetter (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-16129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515005#comment-17515005 ] 

Chris M. Hostetter commented on SOLR-16129:
-------------------------------------------

I should mention: Even if the bug causing SOLR-16129 is magically fixed in jetty tomorrow, I still think this patch is useful for us because:

* it "future proofs" the solr client code from getting hung up on other bugs like this that may exist
* it improves the solr client code to not wait around forever for a remote server stalls out (and how long it's willing to waits is driven by {{timeAllowed }}of the request)

> Solr specific InputStreamResponseListener to prevent client threads from hanging forever
> ----------------------------------------------------------------------------------------
>
>                 Key: SOLR-16129
>                 URL: https://issues.apache.org/jira/browse/SOLR-16129
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Chris M. Hostetter
>            Assignee: Chris M. Hostetter
>            Priority: Major
>         Attachments: SOLR-16129.patch
>
>
> This issue tracks the implementation of workaround I suggested for SOLR-16099 - it does not _fix_ the underlying bug (which as of this writting doesn't have an identified root cause) but it does ensure that client threads which encounter the bug won't hang forever...
> {quote}One thing we may want to consider (in Solr) is replacing our usage of {{InputStreamResponseListener}} with a variant implementation that uses a "timeout" instead of an unlimited {{wait()}} (along the lines of a [spin-off jetty enhancement issue|https://github.com/eclipse/jetty.project/issues/7259] one of the jetty devs filed). We could probably (with some effort) tweak the impacted Solr APIs to propogate the (remaining) {{timeAllowed}} (if that option was specified) down to this class – and/or have an "extreme" default (ie: 30min) just to prevent threads from sticking around forever.
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org