[GitHub] [airflow] potiuk edited a comment on pull request #13246: Add OracleToGCS Transfer

[GitBox <gi...@apache.org>]

potiuk edited a comment on pull request #13246:
URL: https://github.com/apache/airflow/pull/13246#issuecomment-749945362


   First quick view looks good. The tests will have to be fixed (both static checks - I heartily recommend to install pre-commit loclly and run it  see https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst) as well as the unit tests. 
   
   What could be really useful as well is adding an example_dag and HowTo Guide for the operator. You can see plenty of examples in Google Provider, the nice thing is that you can use pieces of the example dag in the HowToGuide. 
   
   Finally (though this is not a requirement) the example dag can be turned into a "system test" https://github.com/apache/airflow/blob/master/TESTING.rst#airflow-system-tests - we have not yet automated them, but soon we will. The example dag could be simply made into a runnable example that could perform end-2-end test of the operator. This would require connection to the actual Oracle DB though (credentials might be stored in environment variable).
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org