[GitHub] [airflow] yourhiro edited a comment on issue #5111: [AIRFLOW-4294] fix missing dag & task runs in UI when . in dag_id

[GitBox <gi...@apache.org>]

yourhiro edited a comment on issue #5111: [AIRFLOW-4294] fix missing dag & task runs in UI when . in dag_id
URL: https://github.com/apache/airflow/pull/5111#issuecomment-483813878
 
 
   aha, I see that up until 1.10.2, the payload did indeed keyed on safe_dag_id.
   
   as of 1.10.2, it was working in both old and new UIs:
   https://github.com/apache/airflow/blob/1.10.2/airflow/www/views.py#L577-L585
   https://github.com/apache/airflow/blob/1.10.2/airflow/www_rbac/views.py#L337-L345
   
   looks like it was changed in this commit:
   https://github.com/apache/airflow/commit/ad7a70297b639142e0a89cfb89a116371d90e605
   
   I would argue that the coupling of the endpoint response to the way it's used on the client led to this being accidentally changed but I'm not familiar with the API design in Airflow so maybe that's a normal thing.
   
   Either way, I would personally prefer a client-side fix because I feel it keeps the endpoint response clean but don't feel too strongly about it so I'll defer to you on which is more consistent with the rest of the web app.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services