You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/12/29 07:48:55 UTC
[GitHub] [echarts] TonyYanOnFire opened a new issue, #18121: [Feature] supports action "saveAsImage"
TonyYanOnFire opened a new issue, #18121:
URL: https://github.com/apache/echarts/issues/18121
### What problem does this feature solve?
Add an action "saveAsImage" for `dispatchAction` so that you can write code to trigger the saveAsImage event of an echart instance.
### What does the proposed API look like?
```
myChart.dispatchAction({
type: 'saveAsImage',
// saveAsImage options
...
})
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on issue #18121: [Feature] supports action "saveAsImage"
Posted by GitBox <gi...@apache.org>.
Ovilia commented on issue #18121:
URL: https://github.com/apache/echarts/issues/18121#issuecomment-1375080976
Can this be done by `chart.getDom().toDataURL()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] TonyYanOnFire commented on issue #18121: [Feature] supports action "saveAsImage"
Posted by "TonyYanOnFire (via GitHub)" <gi...@apache.org>.
TonyYanOnFire commented on issue #18121:
URL: https://github.com/apache/echarts/issues/18121#issuecomment-1462175253
Hey, anyone still interested in this feature? If no official team members reply within 24 hours, I'm gonna close this issue and related PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [I] [Feature] supports action "saveAsImage" [echarts]
Posted by "jdgme (via GitHub)" <gi...@apache.org>.
jdgme commented on issue #18121:
URL: https://github.com/apache/echarts/issues/18121#issuecomment-2250905653
I concur that this is needed as any external trigger noted above using getDataURL() or getConnectedDataURL() would not have "saveAsImage.excludeComponents" applied, but rather save the image as shown on screen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] TonyYanOnFire commented on issue #18121: [Feature] supports action "saveAsImage"
Posted by GitBox <gi...@apache.org>.
TonyYanOnFire commented on issue #18121:
URL: https://github.com/apache/echarts/issues/18121#issuecomment-1375598193
You sure can use current APIs like `getDataURL` and `getConnectedDataURL` to extract the url and save it as an image, which is exactly what I'm doing in my production codes right now. But from what I see there are at least 2 inconveniences:
1. I have to somehow extract and maintain the option I use both in defining `toolbox.feature.saveAsImage` and `getDataURL`
2. I have to define my own download method, which has a great chance to have less compatibility compare to the one echarts has already defined
What I wanna do is as simply as trigger the saveAsImage action, and at first I was like "How hard it is? We already have a saveAasImage button here!" . But turns out the work I have to put into is not that simple, to be fair.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] TonyYanOnFire closed issue #18121: [Feature] supports action "saveAsImage"
Posted by "TonyYanOnFire (via GitHub)" <gi...@apache.org>.
TonyYanOnFire closed issue #18121: [Feature] supports action "saveAsImage"
URL: https://github.com/apache/echarts/issues/18121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org