You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Darrel Schneider (JIRA)" <ji...@apache.org> on 2016/05/11 17:25:13 UTC

[jira] [Resolved] (GEODE-1282) missing release of GatewaySenderEventImpl when it is removed from tempQueue

     [ https://issues.apache.org/jira/browse/GEODE-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Darrel Schneider resolved GEODE-1282.
-------------------------------------
       Resolution: Fixed
    Fix Version/s: 1.0.0-incubating.M3

fixed in revision: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/463ae16a

> missing release of GatewaySenderEventImpl when it is removed from tempQueue
> ---------------------------------------------------------------------------
>
>                 Key: GEODE-1282
>                 URL: https://issues.apache.org/jira/browse/GEODE-1282
>             Project: Geode
>          Issue Type: Bug
>          Components: offheap
>            Reporter: Darrel Schneider
>            Assignee: Darrel Schneider
>             Fix For: 1.0.0-incubating.M3
>
>
> This code might be the cause of off-heap orphans in gateway tests:
> com.gemstone.gemfire.internal.cache.wan.parallel.ParallelQueueRemovalMessage.destroyFromTempQueue(PartitionedRegion, int, Object)
>       BlockingQueue<GatewaySenderEventImpl> tempQueue = prq
>     		  .getBucketTmpQueue(bId);
>       if (tempQueue != null) {
>         Iterator<GatewaySenderEventImpl> itr = tempQueue.iterator();
>         while (itr.hasNext()) {
>           GatewaySenderEventImpl eventForFilter = itr.next();
>           //fix for #48082
>           afterAckForSecondary_EventInTempQueue(qPR.getParallelGatewaySender(), eventForFilter);
>           if (eventForFilter.getShadowKey().equals(key)) {
>             itr.remove();
>             isDestroyed = true;
>           }
>         }
>       }
> The bug is when it does "itr.remove();". It needs to also do "eventForFilter.release();".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)