You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2014/04/11 03:09:40 UTC
Review Request 20244: Create default blueprint definitions executable
through a script
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20244/
-----------------------------------------------------------
Review request for Ambari, Mahadev Konar and Sumit Mohanty.
Bugs: AMBARI-5398
https://issues.apache.org/jira/browse/AMBARI-5398
Repository: ambari
Description
-------
Blueprints allow for repeatable touch-less cluster installation. We need to allow for repeatable creation of clusters with little effort.
*Objective*:
Create a script to deploy a cluster with arbitrary number of nodes with few large master nodes and deploy the cluster using an existing blueprint.
Diffs
-----
ambari-server/src/main/resources/scripts/cluster_blueprint.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.1/blueprints/multinode-default.json PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.1/blueprints/singlenode-default.json PRE-CREATION
ambari-server/src/test/python/TestClusterBlueprint.py PRE-CREATION
ambari-server/src/test/resources/TestAmbaryServer.samples/blueprint_hosts.json PRE-CREATION
ambari-server/src/test/resources/TestAmbaryServer.samples/multinode-default.json PRE-CREATION
Diff: https://reviews.apache.org/r/20244/diff/
Testing
-------
Thanks,
Sid Wagle
Re: Review Request 20244: Create default blueprint definitions executable
through a script
Posted by Sid Wagle <sw...@hortonworks.com>.
> On April 11, 2014, 1:19 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/scripts/cluster_blueprint.py, line 359
> > <https://reviews.apache.org/r/20244/diff/1/?file=554941#file554941line359>
> >
> > Should we report back the request id when this is an import operation?
We print the response json to console with request id.
> On April 11, 2014, 1:19 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/scripts/cluster_blueprint.py, line 411
> > <https://reviews.apache.org/r/20244/diff/1/?file=554941#file554941line411>
> >
> > Default should be export, I think.
Currently using this for import so the choice.
> On April 11, 2014, 1:19 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/scripts/cluster_blueprint.py, line 413
> > <https://reviews.apache.org/r/20244/diff/1/?file=554941#file554941line413>
> >
> > Does export do a console out if no file is provided?
Good point, I will set a default path and print the path to log. Do not like console json output.
> On April 11, 2014, 1:19 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/scripts/cluster_blueprint.py, line 418
> > <https://reviews.apache.org/r/20244/diff/1/?file=554941#file554941line418>
> >
> > What are these arguments for?
To provide a comma separated list of hosts. Script allows user to not provide a hosts json but a comma separated list of hosts.
> On April 11, 2014, 1:19 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/scripts/cluster_blueprint.py, line 421
> > <https://reviews.apache.org/r/20244/diff/1/?file=554941#file554941line421>
> >
> > We would need to accept host/port user/password as parameters for silent option.
Agreed, will make those changes.
> On April 11, 2014, 1:19 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/scripts/cluster_blueprint.py, line 324
> > <https://reviews.apache.org/r/20244/diff/1/?file=554941#file554941line324>
> >
> > Can we add some form of validation on the hosts json file and tests against some sample invalid formatted files?
Agreed I will create a separate Jira for this. AMBARI-5465
- Sid
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20244/#review40153
-----------------------------------------------------------
On April 11, 2014, 1:09 a.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20244/
> -----------------------------------------------------------
>
> (Updated April 11, 2014, 1:09 a.m.)
>
>
> Review request for Ambari, Mahadev Konar and Sumit Mohanty.
>
>
> Bugs: AMBARI-5398
> https://issues.apache.org/jira/browse/AMBARI-5398
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Blueprints allow for repeatable touch-less cluster installation. We need to allow for repeatable creation of clusters with little effort.
>
> *Objective*:
> Create a script to deploy a cluster with arbitrary number of nodes with few large master nodes and deploy the cluster using an existing blueprint.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/scripts/cluster_blueprint.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.1/blueprints/multinode-default.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.1/blueprints/singlenode-default.json PRE-CREATION
> ambari-server/src/test/python/TestClusterBlueprint.py PRE-CREATION
> ambari-server/src/test/resources/TestAmbaryServer.samples/blueprint_hosts.json PRE-CREATION
> ambari-server/src/test/resources/TestAmbaryServer.samples/multinode-default.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20244/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 20244: Create default blueprint definitions executable
through a script
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20244/#review40153
-----------------------------------------------------------
ambari-server/src/main/resources/scripts/cluster_blueprint.py
<https://reviews.apache.org/r/20244/#comment73029>
Can we add some form of validation on the hosts json file and tests against some sample invalid formatted files?
ambari-server/src/main/resources/scripts/cluster_blueprint.py
<https://reviews.apache.org/r/20244/#comment73028>
Should we report back the request id when this is an import operation?
ambari-server/src/main/resources/scripts/cluster_blueprint.py
<https://reviews.apache.org/r/20244/#comment73023>
Default should be export, I think.
ambari-server/src/main/resources/scripts/cluster_blueprint.py
<https://reviews.apache.org/r/20244/#comment73024>
Does export do a console out if no file is provided?
ambari-server/src/main/resources/scripts/cluster_blueprint.py
<https://reviews.apache.org/r/20244/#comment73025>
What are these arguments for?
ambari-server/src/main/resources/scripts/cluster_blueprint.py
<https://reviews.apache.org/r/20244/#comment73027>
We would need to accept host/port user/password as parameters for silent option.
- Sumit Mohanty
On April 11, 2014, 1:09 a.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20244/
> -----------------------------------------------------------
>
> (Updated April 11, 2014, 1:09 a.m.)
>
>
> Review request for Ambari, Mahadev Konar and Sumit Mohanty.
>
>
> Bugs: AMBARI-5398
> https://issues.apache.org/jira/browse/AMBARI-5398
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Blueprints allow for repeatable touch-less cluster installation. We need to allow for repeatable creation of clusters with little effort.
>
> *Objective*:
> Create a script to deploy a cluster with arbitrary number of nodes with few large master nodes and deploy the cluster using an existing blueprint.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/scripts/cluster_blueprint.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.1/blueprints/multinode-default.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.1/blueprints/singlenode-default.json PRE-CREATION
> ambari-server/src/test/python/TestClusterBlueprint.py PRE-CREATION
> ambari-server/src/test/resources/TestAmbaryServer.samples/blueprint_hosts.json PRE-CREATION
> ambari-server/src/test/resources/TestAmbaryServer.samples/multinode-default.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20244/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 20244: Create default blueprint definitions executable
through a script
Posted by Sid Wagle <sw...@hortonworks.com>.
> On April 11, 2014, 1:31 a.m., Michael Harp wrote:
> > Hi Sid,
> > Could we make the port a command line option or a Global?
Agreed, will make it a part of the next patch.
- Sid
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20244/#review40118
-----------------------------------------------------------
On April 11, 2014, 1:09 a.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20244/
> -----------------------------------------------------------
>
> (Updated April 11, 2014, 1:09 a.m.)
>
>
> Review request for Ambari, Mahadev Konar and Sumit Mohanty.
>
>
> Bugs: AMBARI-5398
> https://issues.apache.org/jira/browse/AMBARI-5398
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Blueprints allow for repeatable touch-less cluster installation. We need to allow for repeatable creation of clusters with little effort.
>
> *Objective*:
> Create a script to deploy a cluster with arbitrary number of nodes with few large master nodes and deploy the cluster using an existing blueprint.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/scripts/cluster_blueprint.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.1/blueprints/multinode-default.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.1/blueprints/singlenode-default.json PRE-CREATION
> ambari-server/src/test/python/TestClusterBlueprint.py PRE-CREATION
> ambari-server/src/test/resources/TestAmbaryServer.samples/blueprint_hosts.json PRE-CREATION
> ambari-server/src/test/resources/TestAmbaryServer.samples/multinode-default.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20244/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 20244: Create default blueprint definitions executable
through a script
Posted by Michael Harp <mi...@teradata.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20244/#review40118
-----------------------------------------------------------
Hi Sid,
Could we make the port a command line option or a Global?
- Michael Harp
On April 11, 2014, 1:09 a.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20244/
> -----------------------------------------------------------
>
> (Updated April 11, 2014, 1:09 a.m.)
>
>
> Review request for Ambari, Mahadev Konar and Sumit Mohanty.
>
>
> Bugs: AMBARI-5398
> https://issues.apache.org/jira/browse/AMBARI-5398
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Blueprints allow for repeatable touch-less cluster installation. We need to allow for repeatable creation of clusters with little effort.
>
> *Objective*:
> Create a script to deploy a cluster with arbitrary number of nodes with few large master nodes and deploy the cluster using an existing blueprint.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/scripts/cluster_blueprint.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.1/blueprints/multinode-default.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.1/blueprints/singlenode-default.json PRE-CREATION
> ambari-server/src/test/python/TestClusterBlueprint.py PRE-CREATION
> ambari-server/src/test/resources/TestAmbaryServer.samples/blueprint_hosts.json PRE-CREATION
> ambari-server/src/test/resources/TestAmbaryServer.samples/multinode-default.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20244/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 20244: Create default blueprint definitions executable
through a script
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20244/#review41209
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On April 23, 2014, 8:36 p.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20244/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 8:36 p.m.)
>
>
> Review request for Ambari, John Speidel, Mahadev Konar, and Sumit Mohanty.
>
>
> Bugs: AMBARI-5398
> https://issues.apache.org/jira/browse/AMBARI-5398
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Blueprints allow for repeatable touch-less cluster installation. We need to allow for repeatable creation of clusters with little effort.
>
> *Objective*:
> Create a script to deploy a cluster with arbitrary number of nodes with few large master nodes and deploy the cluster using an existing blueprint.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/scripts/cluster_blueprint.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.1/blueprints/multinode-default.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.1/blueprints/singlenode-default.json PRE-CREATION
> ambari-server/src/test/python/TestClusterBlueprint.py PRE-CREATION
> ambari-server/src/test/python/unitTests.py 8395217
> ambari-server/src/test/resources/TestAmbaryServer.samples/blueprint_hosts.json PRE-CREATION
> ambari-server/src/test/resources/TestAmbaryServer.samples/multinode-default.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20244/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 20244: Create default blueprint definitions executable
through a script
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20244/
-----------------------------------------------------------
(Updated April 23, 2014, 8:36 p.m.)
Review request for Ambari, John Speidel, Mahadev Konar, and Sumit Mohanty.
Changes
-------
Incorporated comments.
----------------------------------------------------------------------
Ran 196 tests in 2.647s
OK
----------------------------------------------------------------------
Total run:541
Total errors:0
Total failures:0
OK
Bugs: AMBARI-5398
https://issues.apache.org/jira/browse/AMBARI-5398
Repository: ambari
Description
-------
Blueprints allow for repeatable touch-less cluster installation. We need to allow for repeatable creation of clusters with little effort.
*Objective*:
Create a script to deploy a cluster with arbitrary number of nodes with few large master nodes and deploy the cluster using an existing blueprint.
Diffs (updated)
-----
ambari-server/src/main/resources/scripts/cluster_blueprint.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.1/blueprints/multinode-default.json PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.1/blueprints/singlenode-default.json PRE-CREATION
ambari-server/src/test/python/TestClusterBlueprint.py PRE-CREATION
ambari-server/src/test/python/unitTests.py 8395217
ambari-server/src/test/resources/TestAmbaryServer.samples/blueprint_hosts.json PRE-CREATION
ambari-server/src/test/resources/TestAmbaryServer.samples/multinode-default.json PRE-CREATION
Diff: https://reviews.apache.org/r/20244/diff/
Testing
-------
Thanks,
Sid Wagle
Re: Review Request 20244: Create default blueprint definitions executable
through a script
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20244/
-----------------------------------------------------------
(Updated April 16, 2014, 12:04 a.m.)
Review request for Ambari, John Speidel, Mahadev Konar, and Sumit Mohanty.
Bugs: AMBARI-5398
https://issues.apache.org/jira/browse/AMBARI-5398
Repository: ambari
Description
-------
Blueprints allow for repeatable touch-less cluster installation. We need to allow for repeatable creation of clusters with little effort.
*Objective*:
Create a script to deploy a cluster with arbitrary number of nodes with few large master nodes and deploy the cluster using an existing blueprint.
Diffs
-----
ambari-server/src/main/resources/scripts/cluster_blueprint.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.1/blueprints/multinode-default.json PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.1/blueprints/singlenode-default.json PRE-CREATION
ambari-server/src/test/python/TestClusterBlueprint.py PRE-CREATION
ambari-server/src/test/resources/TestAmbaryServer.samples/blueprint_hosts.json PRE-CREATION
ambari-server/src/test/resources/TestAmbaryServer.samples/multinode-default.json PRE-CREATION
Diff: https://reviews.apache.org/r/20244/diff/
Testing
-------
Thanks,
Sid Wagle