Re: [PR] Remove extra solr.xml and other config setup for tests that are not needed [solr]

["dsmiley (via GitHub)" <gi...@apache.org>]

dsmiley commented on code in PR #3988:
URL: https://github.com/apache/solr/pull/3988#discussion_r2658431140


##########
solr/core/src/test/org/apache/solr/handler/V2StandaloneTest.java:
##########
@@ -35,7 +34,6 @@ public void testWelcomeMessage() throws Exception {
     Path solrHomeTmp = createTempDir();
     PathUtils.copyDirectory(
         TEST_HOME().resolve("configsets/minimal/conf"), solrHomeTmp.resolve("conf"));
-    Files.copy(TEST_HOME().resolve("solr.xml"), solrHomeTmp.resolve("solr.xml"));

Review Comment:
   I noticed that I documented the rule's `startSolr` [as follows](https://github.com/apache/solr/blob/6b82523c3836f8dca10ec62ea6e619aebdb1e168/solr/test-framework/src/java/org/apache/solr/util/SolrClientTestRule.java#L45-L49), meaning it has good test defaults.  But only EmbeddedSolrServerTestRule follows this.  I suppose then we have room to improve the Jetty side, after which it will indeed make sense to not copy a general test solr.xml.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org