[GitHub] [arrow] emkornfield commented on a diff in pull request #35691: GH-34785: [C++][Parquet] Skeleton for Parquet bloom filter writer

["emkornfield (via GitHub)" <gi...@apache.org>]

emkornfield commented on code in PR #35691:
URL: https://github.com/apache/arrow/pull/35691#discussion_r1208107579


##########
cpp/src/parquet/bloom_filter.h:
##########
@@ -101,6 +101,12 @@ class PARQUET_EXPORT BloomFilter {
   /// @return hash result.
   virtual uint64_t Hash(const FLBA* value, uint32_t len) const = 0;
 
+  // Variant of const pointer argument to facilitate template

Review Comment:
   instead of doing these, could we make const-ref parameters for the pointer types?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org