You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by tison <wa...@gmail.com> on 2023/05/27 08:36:20 UTC
[VOTE] Apply a consistent code style to our codebase
See [1] for the discussion thread and [2] for the demo implementation.
Briefly, I propose to adopt spotless-maven-plugin to format all our source
code with a consistent Plantir style. JIRA ticket will be filed if we agree
on the direction here.
This is the vote for an explicit consensus to do so. It will remain at
least 72 hours.
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)
Enjoy your day!
Best,
tison.
[1] https://lists.apache.org/thread/12rwy3y1zcs3pjh9q30851mldgdh4sgg
[2] https://github.com/apache/curator/pull/463
[RESULT][VOTE] Apply a consistent code style to our codebase
Posted by tison <wa...@gmail.com>.
This vote has passed with 4 +1 bindings vote and 1 +0 bindings vote
+1 bindings
Enrico Olivelli
tison
Kezhu Wang
Cameron McKenzie
+0 bindings
Jordan Zimmerman
Thanks for your participation! I'll file a ticket and continue the code
work :D
Best,
tison.
Cameron McKenzie <mc...@gmail.com> 于2023年5月29日周一 06:03写道：
> +1 from me.
>
> On Sun, May 28, 2023 at 11:33 AM Kezhu Wang <ke...@apache.org> wrote:
>
> > Carry my +1 from the discussion thread.
> >
> > Look forward to this!
> >
> > Best,
> > Kezhu Wang
> >
> > On Sun, May 28, 2023 at 7:49 AM tison <wa...@gmail.com> wrote:
> > >
> > > +1
> > >
> > > Thanks for your advice! I'll keep this vote running while preparing the
> > > code part now.
> > >
> > > Best,
> > > tison.
> > >
> > >
> > > Enrico Olivelli <eo...@gmail.com> 于2023年5月27日周六 22:09写道：
> > >
> > > > +1
> > > >
> > > > I don't think we need a vote for this.
> > > >
> > > >
> > > > Enrico
> > > >
> > > > Il Sab 27 Mag 2023, 10:54 Jordan Zimmerman <
> jordan@jordanzimmerman.com>
> > ha
> > > > scritto:
> > > >
> > > > > +0
> > > > >
> > > > > It's fine either way with me
> > > > >
> > > > > > On May 27, 2023, at 9:36 AM, tison <wa...@gmail.com> wrote:
> > > > > >
> > > > > > See [1] for the discussion thread and [2] for the demo
> > implementation.
> > > > > >
> > > > > > Briefly, I propose to adopt spotless-maven-plugin to format all
> our
> > > > > source
> > > > > > code with a consistent Plantir style. JIRA ticket will be filed
> if
> > we
> > > > > agree
> > > > > > on the direction here.
> > > > > >
> > > > > > This is the vote for an explicit consensus to do so. It will
> > remain at
> > > > > > least 72 hours.
> > > > > >
> > > > > > [ ] +1 approve
> > > > > > [ ] +0 no opinion
> > > > > > [ ] -1 disapprove (and reason why)
> > > > > >
> > > > > > Enjoy your day!
> > > > > >
> > > > > > Best,
> > > > > > tison.
> > > > > >
> > > > > > [1]
> > https://lists.apache.org/thread/12rwy3y1zcs3pjh9q30851mldgdh4sgg
> > > > > > [2] https://github.com/apache/curator/pull/463
> > > > >
> > > > >
> > > >
> >
>
Re: [VOTE] Apply a consistent code style to our codebase
Posted by Cameron McKenzie <mc...@gmail.com>.
+1 from me.
On Sun, May 28, 2023 at 11:33 AM Kezhu Wang <ke...@apache.org> wrote:
> Carry my +1 from the discussion thread.
>
> Look forward to this!
>
> Best,
> Kezhu Wang
>
> On Sun, May 28, 2023 at 7:49 AM tison <wa...@gmail.com> wrote:
> >
> > +1
> >
> > Thanks for your advice! I'll keep this vote running while preparing the
> > code part now.
> >
> > Best,
> > tison.
> >
> >
> > Enrico Olivelli <eo...@gmail.com> 于2023年5月27日周六 22:09写道：
> >
> > > +1
> > >
> > > I don't think we need a vote for this.
> > >
> > >
> > > Enrico
> > >
> > > Il Sab 27 Mag 2023, 10:54 Jordan Zimmerman <jo...@jordanzimmerman.com>
> ha
> > > scritto:
> > >
> > > > +0
> > > >
> > > > It's fine either way with me
> > > >
> > > > > On May 27, 2023, at 9:36 AM, tison <wa...@gmail.com> wrote:
> > > > >
> > > > > See [1] for the discussion thread and [2] for the demo
> implementation.
> > > > >
> > > > > Briefly, I propose to adopt spotless-maven-plugin to format all our
> > > > source
> > > > > code with a consistent Plantir style. JIRA ticket will be filed if
> we
> > > > agree
> > > > > on the direction here.
> > > > >
> > > > > This is the vote for an explicit consensus to do so. It will
> remain at
> > > > > least 72 hours.
> > > > >
> > > > > [ ] +1 approve
> > > > > [ ] +0 no opinion
> > > > > [ ] -1 disapprove (and reason why)
> > > > >
> > > > > Enjoy your day!
> > > > >
> > > > > Best,
> > > > > tison.
> > > > >
> > > > > [1]
> https://lists.apache.org/thread/12rwy3y1zcs3pjh9q30851mldgdh4sgg
> > > > > [2] https://github.com/apache/curator/pull/463
> > > >
> > > >
> > >
>
Re: [VOTE] Apply a consistent code style to our codebase
Posted by Kezhu Wang <ke...@apache.org>.
Carry my +1 from the discussion thread.
Look forward to this!
Best,
Kezhu Wang
On Sun, May 28, 2023 at 7:49 AM tison <wa...@gmail.com> wrote:
>
> +1
>
> Thanks for your advice! I'll keep this vote running while preparing the
> code part now.
>
> Best,
> tison.
>
>
> Enrico Olivelli <eo...@gmail.com> 于2023年5月27日周六 22:09写道：
>
> > +1
> >
> > I don't think we need a vote for this.
> >
> >
> > Enrico
> >
> > Il Sab 27 Mag 2023, 10:54 Jordan Zimmerman <jo...@jordanzimmerman.com> ha
> > scritto:
> >
> > > +0
> > >
> > > It's fine either way with me
> > >
> > > > On May 27, 2023, at 9:36 AM, tison <wa...@gmail.com> wrote:
> > > >
> > > > See [1] for the discussion thread and [2] for the demo implementation.
> > > >
> > > > Briefly, I propose to adopt spotless-maven-plugin to format all our
> > > source
> > > > code with a consistent Plantir style. JIRA ticket will be filed if we
> > > agree
> > > > on the direction here.
> > > >
> > > > This is the vote for an explicit consensus to do so. It will remain at
> > > > least 72 hours.
> > > >
> > > > [ ] +1 approve
> > > > [ ] +0 no opinion
> > > > [ ] -1 disapprove (and reason why)
> > > >
> > > > Enjoy your day!
> > > >
> > > > Best,
> > > > tison.
> > > >
> > > > [1] https://lists.apache.org/thread/12rwy3y1zcs3pjh9q30851mldgdh4sgg
> > > > [2] https://github.com/apache/curator/pull/463
> > >
> > >
> >
Re: [VOTE] Apply a consistent code style to our codebase
Posted by tison <wa...@gmail.com>.
+1
Thanks for your advice! I'll keep this vote running while preparing the
code part now.
Best,
tison.
Enrico Olivelli <eo...@gmail.com> 于2023年5月27日周六 22:09写道：
> +1
>
> I don't think we need a vote for this.
>
>
> Enrico
>
> Il Sab 27 Mag 2023, 10:54 Jordan Zimmerman <jo...@jordanzimmerman.com> ha
> scritto:
>
> > +0
> >
> > It's fine either way with me
> >
> > > On May 27, 2023, at 9:36 AM, tison <wa...@gmail.com> wrote:
> > >
> > > See [1] for the discussion thread and [2] for the demo implementation.
> > >
> > > Briefly, I propose to adopt spotless-maven-plugin to format all our
> > source
> > > code with a consistent Plantir style. JIRA ticket will be filed if we
> > agree
> > > on the direction here.
> > >
> > > This is the vote for an explicit consensus to do so. It will remain at
> > > least 72 hours.
> > >
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove (and reason why)
> > >
> > > Enjoy your day!
> > >
> > > Best,
> > > tison.
> > >
> > > [1] https://lists.apache.org/thread/12rwy3y1zcs3pjh9q30851mldgdh4sgg
> > > [2] https://github.com/apache/curator/pull/463
> >
> >
>
Re: [VOTE] Apply a consistent code style to our codebase
Posted by Enrico Olivelli <eo...@gmail.com>.
+1
I don't think we need a vote for this.
Enrico
Il Sab 27 Mag 2023, 10:54 Jordan Zimmerman <jo...@jordanzimmerman.com> ha
scritto:
> +0
>
> It's fine either way with me
>
> > On May 27, 2023, at 9:36 AM, tison <wa...@gmail.com> wrote:
> >
> > See [1] for the discussion thread and [2] for the demo implementation.
> >
> > Briefly, I propose to adopt spotless-maven-plugin to format all our
> source
> > code with a consistent Plantir style. JIRA ticket will be filed if we
> agree
> > on the direction here.
> >
> > This is the vote for an explicit consensus to do so. It will remain at
> > least 72 hours.
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove (and reason why)
> >
> > Enjoy your day!
> >
> > Best,
> > tison.
> >
> > [1] https://lists.apache.org/thread/12rwy3y1zcs3pjh9q30851mldgdh4sgg
> > [2] https://github.com/apache/curator/pull/463
>
>
Re: [VOTE] Apply a consistent code style to our codebase
Posted by Jordan Zimmerman <jo...@jordanzimmerman.com>.
+0
It's fine either way with me
> On May 27, 2023, at 9:36 AM, tison <wa...@gmail.com> wrote:
>
> See [1] for the discussion thread and [2] for the demo implementation.
>
> Briefly, I propose to adopt spotless-maven-plugin to format all our source
> code with a consistent Plantir style. JIRA ticket will be filed if we agree
> on the direction here.
>
> This is the vote for an explicit consensus to do so. It will remain at
> least 72 hours.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Enjoy your day!
>
> Best,
> tison.
>
> [1] https://lists.apache.org/thread/12rwy3y1zcs3pjh9q30851mldgdh4sgg
> [2] https://github.com/apache/curator/pull/463