You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "WangzJi (via GitHub)" <gi...@apache.org> on 2025/06/06 09:09:07 UTC
[PR] optimize: add ASF-compliant source-release assembly and update pom.xm… [incubator-seata]
WangzJi opened a new pull request, #7419:
URL: https://github.com/apache/incubator-seata/pull/7419
…l for source packaging
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing guidelines -->
- [x] I have registered the PR [changes](../changes).
### Ⅰ. Describe what this PR did
Add ASF-compliant source-release assembly and update pom.xml for source packaging
### Ⅱ. Does this pull request fix one issue?
Closes #7367
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add ASF-compliant source-release assembly [incubator-seata]
Posted by "WangzJi (via GitHub)" <gi...@apache.org>.
WangzJi commented on code in PR #7419:
URL: https://github.com/apache/incubator-seata/pull/7419#discussion_r2139282557
##########
pom.xml:
##########
@@ -60,9 +60,9 @@
<module>rocketmq</module>
<module>spring</module>
<module>tcc</module>
- <module>test</module>
+ <!--<module>test</module>--> <!-- excluded from source release -->
<module>mock-server</module>
- <module>test-old-version</module>
+ <!--<module>test-old-version</module>--> <!-- excluded from source release -->
Review Comment:
@funky-eyes
Because while these two modules are no longer included in the source package, they are still declared in the pom module.How should we properly handle this kind of situation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add ASF-compliant source-release assembly [incubator-seata]
Posted by "WangzJi (via GitHub)" <gi...@apache.org>.
WangzJi commented on code in PR #7419:
URL: https://github.com/apache/incubator-seata/pull/7419#discussion_r2139294768
##########
pom.xml:
##########
@@ -60,9 +60,9 @@
<module>rocketmq</module>
<module>spring</module>
<module>tcc</module>
- <module>test</module>
+ <!--<module>test</module>--> <!-- excluded from source release -->
<module>mock-server</module>
- <module>test-old-version</module>
+ <!--<module>test-old-version</module>--> <!-- excluded from source release -->
Review Comment:
> Do not exclude these two modules from the project. Only exclude these two directories when packaging the source code compressed package.
Let me try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add ASF-compliant source-release assembly [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #7419:
URL: https://github.com/apache/incubator-seata/pull/7419#discussion_r2139067565
##########
pom.xml:
##########
@@ -60,9 +60,9 @@
<module>rocketmq</module>
<module>spring</module>
<module>tcc</module>
- <module>test</module>
+ <!--<module>test</module>--> <!-- excluded from source release -->
<module>mock-server</module>
- <module>test-old-version</module>
+ <!--<module>test-old-version</module>--> <!-- excluded from source release -->
Review Comment:
排除这两个模块后，单测覆盖度大幅度下降。这两个模块本身就不会发布到源码中！
Excluding these two modules resulted in a significant decrease in test coverage. These two modules will not be released in the source code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add ASF-compliant source-release assembly [incubator-seata]
Posted by "slievrly (via GitHub)" <gi...@apache.org>.
slievrly merged PR #7419:
URL: https://github.com/apache/incubator-seata/pull/7419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add ASF-compliant source-release assembly and update pom.xm… [incubator-seata]
Posted by "WangzJi (via GitHub)" <gi...@apache.org>.
WangzJi commented on code in PR #7419:
URL: https://github.com/apache/incubator-seata/pull/7419#discussion_r2135270229
##########
src/assembly/source-release.xml:
##########
@@ -0,0 +1,52 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<assembly xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3 http://maven.apache.org/xsd/assembly-1.1.3.xsd">
+ <id>incubating-src</id>
+ <formats>
+ <format>tar.gz</format>
+ </formats>
+ <baseDirectory>apache-seata-${project.version}-incubating-src</baseDirectory>
+ <fileSets>
+ <fileSet>
+ <directory>${basedir}</directory>
+ <outputDirectory>/</outputDirectory>
+ <includes>
+ <include>**/*</include>
+ </includes>
+ <excludes>
+ <exclude>.git/**</exclude>
+ <exclude>.github/**</exclude>
+ <exclude>.idea/**</exclude>
+ <exclude>**/target/**</exclude>
+ <exclude>**/*.iml</exclude>
+ <exclude>**/*.class</exclude>
+ <exclude>**/*.log</exclude>
+ <exclude>**/.DS_Store</exclude>
+ <exclude>**/.flattened-pom.xml</exclude>
+ <exclude>distribution/**</exclude>
+ <exclude>test-old-version/**</exclude>
+ <exclude>test/**</exclude>
+ <exclude>**/node_modules/**</exclude>
+ <exclude>**/node/**</exclude>
+ <exclude>**/dist/**</exclude>
+ <exclude>**/public/saga-statemachine-designer/**</exclude>
Review Comment:
@slievrly Thanks for the review! I've thoroughly tested both scenarios:
## ✅ Verification Results
**Test Command**: `./mvnw clean package -DskipTests=true`
| Configuration | Source Package Size | Frontend Files | Build Status |
|---------------|--------------------|--------------------|-------------|
| **Without excludes** | ~25MB | 19,584 files | ✅ Can build |
| **With excludes** | ~4MB | 0 files | ✅ Can build |
## 📊 Key Findings
1. **`public/saga-statemachine-designer`**: Yes, this directory exists in `console/src/main/resources/static/console-fe/public/saga-statemachine-designer/` and needs to be excluded.
2. **Build capability**: Both configurations allow successful builds after decompression, confirming the packaged source code works correctly.
3. **Exclusion necessity**: Without frontend exclusions, the source package becomes 6x larger and includes nearly 20K frontend build artifacts (node_modules, dist, etc.), which pollute the source distribution.
## 🎯 Conclusion
The frontend exclusion rules are **essential** for producing clean source packages:
- They reduce package size from 25MB to 4MB
- They eliminate 19,584 unnecessary frontend build artifacts
- They maintain the ability to build successfully after extraction
The exclusions ensure we distribute clean source code rather than polluted packages with build artifacts.
**Test extraction and build**: ✅ Verified working with `./mvnw clean package -DskipTests=true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add ASF-compliant source-release assembly and update pom.xm… [incubator-seata]
Posted by "slievrly (via GitHub)" <gi...@apache.org>.
slievrly commented on code in PR #7419:
URL: https://github.com/apache/incubator-seata/pull/7419#discussion_r2134761493
##########
src/assembly/source-release.xml:
##########
@@ -0,0 +1,52 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<assembly xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3 http://maven.apache.org/xsd/assembly-1.1.3.xsd">
+ <id>incubating-src</id>
+ <formats>
+ <format>tar.gz</format>
+ </formats>
+ <baseDirectory>apache-seata-${project.version}-incubating-src</baseDirectory>
+ <fileSets>
+ <fileSet>
+ <directory>${basedir}</directory>
+ <outputDirectory>/</outputDirectory>
+ <includes>
+ <include>**/*</include>
+ </includes>
+ <excludes>
+ <exclude>.git/**</exclude>
+ <exclude>.github/**</exclude>
+ <exclude>.idea/**</exclude>
+ <exclude>**/target/**</exclude>
+ <exclude>**/*.iml</exclude>
+ <exclude>**/*.class</exclude>
+ <exclude>**/*.log</exclude>
+ <exclude>**/.DS_Store</exclude>
+ <exclude>**/.flattened-pom.xml</exclude>
+ <exclude>distribution/**</exclude>
+ <exclude>test-old-version/**</exclude>
+ <exclude>test/**</exclude>
+ <exclude>**/node_modules/**</exclude>
+ <exclude>**/node/**</exclude>
+ <exclude>**/dist/**</exclude>
+ <exclude>**/public/saga-statemachine-designer/**</exclude>
Review Comment:
Was this directory copied to the console module? For the packaged source code, is it normal to test after decompression? This command can be used for testing: `./mvnw clean package -DskipTests=true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add ASF-compliant source-release assembly [incubator-seata]
Posted by "slievrly (via GitHub)" <gi...@apache.org>.
slievrly commented on code in PR #7419:
URL: https://github.com/apache/incubator-seata/pull/7419#discussion_r2139287126
##########
pom.xml:
##########
@@ -60,9 +60,9 @@
<module>rocketmq</module>
<module>spring</module>
<module>tcc</module>
- <module>test</module>
+ <!--<module>test</module>--> <!-- excluded from source release -->
<module>mock-server</module>
- <module>test-old-version</module>
+ <!--<module>test-old-version</module>--> <!-- excluded from source release -->
Review Comment:
Do not exclude these two modules from the project. Only exclude these two directories when packaging the source code compressed package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add ASF-compliant source-release assembly [incubator-seata]
Posted by "WangzJi (via GitHub)" <gi...@apache.org>.
WangzJi commented on code in PR #7419:
URL: https://github.com/apache/incubator-seata/pull/7419#discussion_r2139615464
##########
pom.xml:
##########
@@ -60,9 +60,9 @@
<module>rocketmq</module>
<module>spring</module>
<module>tcc</module>
- <module>test</module>
+ <!--<module>test</module>--> <!-- excluded from source release -->
<module>mock-server</module>
- <module>test-old-version</module>
+ <!--<module>test-old-version</module>--> <!-- excluded from source release -->
Review Comment:
Hi @slievrly @funky-eyes
I've submitted a follow-up PR #7432 to address the module exclusion issue more cleanly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add ASF-compliant source-release assembly and update pom.xm… [incubator-seata]
Posted by "slievrly (via GitHub)" <gi...@apache.org>.
slievrly commented on code in PR #7419:
URL: https://github.com/apache/incubator-seata/pull/7419#discussion_r2137706044
##########
src/assembly/source-release.xml:
##########
@@ -0,0 +1,52 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<assembly xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3 http://maven.apache.org/xsd/assembly-1.1.3.xsd">
+ <id>incubating-src</id>
+ <formats>
+ <format>tar.gz</format>
+ </formats>
+ <baseDirectory>apache-seata-${project.version}-incubating-src</baseDirectory>
+ <fileSets>
+ <fileSet>
+ <directory>${basedir}</directory>
+ <outputDirectory>/</outputDirectory>
+ <includes>
+ <include>**/*</include>
+ </includes>
+ <excludes>
+ <exclude>.git/**</exclude>
+ <exclude>.github/**</exclude>
+ <exclude>.idea/**</exclude>
+ <exclude>**/target/**</exclude>
+ <exclude>**/*.iml</exclude>
+ <exclude>**/*.class</exclude>
+ <exclude>**/*.log</exclude>
+ <exclude>**/.DS_Store</exclude>
+ <exclude>**/.flattened-pom.xml</exclude>
+ <exclude>distribution/**</exclude>
+ <exclude>test-old-version/**</exclude>
+ <exclude>test/**</exclude>
+ <exclude>**/node_modules/**</exclude>
+ <exclude>**/node/**</exclude>
+ <exclude>**/dist/**</exclude>
+ <exclude>**/public/saga-statemachine-designer/**</exclude>
Review Comment:
Good job. But I feel that you seem like an AI agent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add ASF-compliant source-release assembly [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #7419:
URL: https://github.com/apache/incubator-seata/pull/7419#discussion_r2139249957
##########
pom.xml:
##########
@@ -60,9 +60,9 @@
<module>rocketmq</module>
<module>spring</module>
<module>tcc</module>
- <module>test</module>
+ <!--<module>test</module>--> <!-- excluded from source release -->
<module>mock-server</module>
- <module>test-old-version</module>
+ <!--<module>test-old-version</module>--> <!-- excluded from source release -->
Review Comment:
> > 排除这两个模块后，单测覆盖度大幅度下降。这两个模块本身就不会发布到源码中！ Excluding these two modules resulted in a significant decrease in test coverage. These two modules will not be released in the source code.
>
> If these two modules are not excluded, executing `./mvnw clean package -DskipTests=true` on the packaged source code will throw an exception.
What was the exception? You should be addressing the cause of the exception, not removing the test module or test case that exposed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add ASF-compliant source-release assembly and update pom.xm… [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7419:
URL: https://github.com/apache/incubator-seata/pull/7419#issuecomment-2955152706
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/7419?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 58.55%. Comparing base [(`c902076`)](https://app.codecov.io/gh/apache/incubator-seata/commit/c90207648f2d2d048022399cd39a75e7f8b9810c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`2496e8f`)](https://app.codecov.io/gh/apache/incubator-seata/commit/2496e8fff38dacffd4709505da58549370ea088f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 2.x #7419 +/- ##
============================================
- Coverage 59.45% 58.55% -0.91%
- Complexity 543 571 +28
============================================
Files 1281 1269 -12
Lines 46142 45730 -412
Branches 5561 5548 -13
============================================
- Hits 27432 26775 -657
- Misses 16143 16378 +235
- Partials 2567 2577 +10
```
[see 61 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/7419/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
[](https://app.codecov.io/gh/apache/incubator-seata/pull/7419?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add ASF-compliant source-release assembly [incubator-seata]
Posted by "WangzJi (via GitHub)" <gi...@apache.org>.
WangzJi commented on code in PR #7419:
URL: https://github.com/apache/incubator-seata/pull/7419#discussion_r2139123679
##########
pom.xml:
##########
@@ -60,9 +60,9 @@
<module>rocketmq</module>
<module>spring</module>
<module>tcc</module>
- <module>test</module>
+ <!--<module>test</module>--> <!-- excluded from source release -->
<module>mock-server</module>
- <module>test-old-version</module>
+ <!--<module>test-old-version</module>--> <!-- excluded from source release -->
Review Comment:
> 排除这两个模块后，单测覆盖度大幅度下降。这两个模块本身就不会发布到源码中！ Excluding these two modules resulted in a significant decrease in test coverage. These two modules will not be released in the source code.
If these two modules are not excluded, executing ./mvnw clean package -DskipTests=true on the packaged source code will throw an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add ASF-compliant source-release assembly [incubator-seata]
Posted by "WangzJi (via GitHub)" <gi...@apache.org>.
WangzJi commented on code in PR #7419:
URL: https://github.com/apache/incubator-seata/pull/7419#discussion_r2139123679
##########
pom.xml:
##########
@@ -60,9 +60,9 @@
<module>rocketmq</module>
<module>spring</module>
<module>tcc</module>
- <module>test</module>
+ <!--<module>test</module>--> <!-- excluded from source release -->
<module>mock-server</module>
- <module>test-old-version</module>
+ <!--<module>test-old-version</module>--> <!-- excluded from source release -->
Review Comment:
> 排除这两个模块后，单测覆盖度大幅度下降。这两个模块本身就不会发布到源码中！ Excluding these two modules resulted in a significant decrease in test coverage. These two modules will not be released in the source code.
If these two modules are not excluded, executing `./mvnw clean package -DskipTests=true` on the packaged source code will throw an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org