You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Jamie goodyear (JIRA)" <ji...@apache.org> on 2009/05/27 00:59:45 UTC
[jira] Created: (FELIX-1180) Improve Karaf DefaultJDBCLock to use
proper logging mechanism instead of System err prints.
Improve Karaf DefaultJDBCLock to use proper logging mechanism instead of System err prints.
-------------------------------------------------------------------------------------------
Key: FELIX-1180
URL: https://issues.apache.org/jira/browse/FELIX-1180
Project: Felix
Issue Type: Improvement
Components: Karaf
Reporter: Jamie goodyear
Currently DefaultJDBCLock is using System.err.println to log information and errors. This class needs to be writing this information (along with full stack traces whenever an exception is caught) to the servicemix.log file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1180) Improve Karaf DefaultJDBCLock to use
proper logging mechanism instead of System err prints.
Posted by "Chris Custine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Custine updated FELIX-1180:
---------------------------------
Assignee: Chris Custine
> Improve Karaf DefaultJDBCLock to use proper logging mechanism instead of System err prints.
> -------------------------------------------------------------------------------------------
>
> Key: FELIX-1180
> URL: https://issues.apache.org/jira/browse/FELIX-1180
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Reporter: Jamie goodyear
> Assignee: Chris Custine
> Attachments: felix-1180.patch
>
>
> Currently DefaultJDBCLock is using System.err.println to log information and errors. This class needs to be writing this information (along with full stack traces whenever an exception is caught) to the servicemix.log file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-1180) Improve Karaf DefaultJDBCLock to use
proper logging mechanism instead of System err prints.
Posted by "Chris Custine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Custine resolved FELIX-1180.
----------------------------------
Resolution: Fixed
> Improve Karaf DefaultJDBCLock to use proper logging mechanism instead of System err prints.
> -------------------------------------------------------------------------------------------
>
> Key: FELIX-1180
> URL: https://issues.apache.org/jira/browse/FELIX-1180
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Reporter: Jamie goodyear
> Assignee: Chris Custine
> Fix For: karaf-1.0.0
>
> Attachments: felix-1180.patch
>
>
> Currently DefaultJDBCLock is using System.err.println to log information and errors. This class needs to be writing this information (along with full stack traces whenever an exception is caught) to the servicemix.log file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1180) Improve Karaf DefaultJDBCLock to use
proper logging mechanism instead of System err prints.
Posted by "Jamie goodyear (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jamie goodyear updated FELIX-1180:
----------------------------------
Attachment: felix-1180.patch
File: felix-1180.patch
Contains my first attempt at adding a Log class to classes in the Main module of Karaf. This implementation places a copy of the commons-logging jar in the Karaf lib folder. There is probably a better way of doing this, however I wasn't able to get the maven bundle plugin to load the dependency in a satisfactory way, any suggestions here would be welcome.
Please note that I added some log entries where there was previously 'ignore' comments.
> Improve Karaf DefaultJDBCLock to use proper logging mechanism instead of System err prints.
> -------------------------------------------------------------------------------------------
>
> Key: FELIX-1180
> URL: https://issues.apache.org/jira/browse/FELIX-1180
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Reporter: Jamie goodyear
> Attachments: felix-1180.patch
>
>
> Currently DefaultJDBCLock is using System.err.println to log information and errors. This class needs to be writing this information (along with full stack traces whenever an exception is caught) to the servicemix.log file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1180) Improve Karaf DefaultJDBCLock to use
proper logging mechanism instead of System err prints.
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721687#action_12721687 ]
Guillaume Nodet commented on FELIX-1180:
----------------------------------------
I'm not sure if it's a good idea to add more dependencies to the main module.
If you put commons-logging, you also need a back-end to do the actual logging. Which one would that be ?
> Improve Karaf DefaultJDBCLock to use proper logging mechanism instead of System err prints.
> -------------------------------------------------------------------------------------------
>
> Key: FELIX-1180
> URL: https://issues.apache.org/jira/browse/FELIX-1180
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Reporter: Jamie goodyear
> Assignee: Chris Custine
> Attachments: felix-1180.patch
>
>
> Currently DefaultJDBCLock is using System.err.println to log information and errors. This class needs to be writing this information (along with full stack traces whenever an exception is caught) to the servicemix.log file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1180) Improve Karaf DefaultJDBCLock to use
proper logging mechanism instead of System err prints.
Posted by "Jamie goodyear (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749911#action_12749911 ]
Jamie goodyear commented on FELIX-1180:
---------------------------------------
New direction:
No logger dependency to be added to main module.
Just write to a configurable location (such as data/log/servicemix.log <- a possible good default value).
> Improve Karaf DefaultJDBCLock to use proper logging mechanism instead of System err prints.
> -------------------------------------------------------------------------------------------
>
> Key: FELIX-1180
> URL: https://issues.apache.org/jira/browse/FELIX-1180
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Reporter: Jamie goodyear
> Assignee: Chris Custine
> Attachments: felix-1180.patch
>
>
> Currently DefaultJDBCLock is using System.err.println to log information and errors. This class needs to be writing this information (along with full stack traces whenever an exception is caught) to the servicemix.log file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1180) Improve Karaf DefaultJDBCLock to use
proper logging mechanism instead of System err prints.
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet updated FELIX-1180:
-----------------------------------
Fix Version/s: karaf-1.0.0
> Improve Karaf DefaultJDBCLock to use proper logging mechanism instead of System err prints.
> -------------------------------------------------------------------------------------------
>
> Key: FELIX-1180
> URL: https://issues.apache.org/jira/browse/FELIX-1180
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Reporter: Jamie goodyear
> Assignee: Chris Custine
> Fix For: karaf-1.0.0
>
> Attachments: felix-1180.patch
>
>
> Currently DefaultJDBCLock is using System.err.println to log information and errors. This class needs to be writing this information (along with full stack traces whenever an exception is caught) to the servicemix.log file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1180) Improve Karaf DefaultJDBCLock to use
proper logging mechanism instead of System err prints.
Posted by "Chris Custine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752027#action_12752027 ]
Chris Custine commented on FELIX-1180:
--------------------------------------
Added bootstrap logger using java.util.logging
- Log file will be the default "out" file appender from log4j config
- File location can be overridden by setting "karaf.bootstrap.log" in config.properties
- There are probably better ways to do this, but this works reasonably well and gives a common logging interface (juli) to work with.
> Improve Karaf DefaultJDBCLock to use proper logging mechanism instead of System err prints.
> -------------------------------------------------------------------------------------------
>
> Key: FELIX-1180
> URL: https://issues.apache.org/jira/browse/FELIX-1180
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Reporter: Jamie goodyear
> Assignee: Chris Custine
> Fix For: karaf-1.0.0
>
> Attachments: felix-1180.patch
>
>
> Currently DefaultJDBCLock is using System.err.println to log information and errors. This class needs to be writing this information (along with full stack traces whenever an exception is caught) to the servicemix.log file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1180) Improve Karaf DefaultJDBCLock to use
proper logging mechanism instead of System err prints.
Posted by "Jamie goodyear (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713315#action_12713315 ]
Jamie goodyear commented on FELIX-1180:
---------------------------------------
I'll be submitting a patch for this issue. During my time reviewing the locking mechanism I've found a few other issues as well, will submit new Jira's with patches for them as well :)
> Improve Karaf DefaultJDBCLock to use proper logging mechanism instead of System err prints.
> -------------------------------------------------------------------------------------------
>
> Key: FELIX-1180
> URL: https://issues.apache.org/jira/browse/FELIX-1180
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Reporter: Jamie goodyear
>
> Currently DefaultJDBCLock is using System.err.println to log information and errors. This class needs to be writing this information (along with full stack traces whenever an exception is caught) to the servicemix.log file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.