You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/09 02:00:57 UTC

[GitHub] [flink] vthinkxie opened a new pull request #10803: [FLINK-15518][web]: don not hide web frontend side pane automatically

vthinkxie opened a new pull request #10803: [FLINK-15518][web]: don not hide web frontend side pane automatically
URL: https://github.com/apache/flink/pull/10803
 
 
   ## What is the purpose of the change
   
   https://issues.apache.org/jira/browse/FLINK-15518
   
   ## Brief change log
   
   support more metric display at once
   
   ## Verifying this change
   
     - *Go to the job page*
     - *Side tab do not hide automaticlly*
   
   
   before:
   
   ![image](https://user-images.githubusercontent.com/1506722/72031252-d4017480-32c6-11ea-9e31-99176c095097.png)
   
   
   after:
   
   ![image](https://user-images.githubusercontent.com/1506722/72031264-e085cd00-32c6-11ea-8429-7f3439558c77.png)
   
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10803: [FLINK-15518][web]: don not hide web frontend side pane automatically

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10803: [FLINK-15518][web]: don not hide web frontend side pane automatically
URL: https://github.com/apache/flink/pull/10803#issuecomment-572348603
 
 
   <!--
   Meta data
   Hash:0807678093dc557042e46f1dc16ac30cde313220 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143661824 TriggerType:PUSH TriggerID:0807678093dc557042e46f1dc16ac30cde313220
   Hash:0807678093dc557042e46f1dc16ac30cde313220 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4200 TriggerType:PUSH TriggerID:0807678093dc557042e46f1dc16ac30cde313220
   -->
   ## CI report:
   
   * 0807678093dc557042e46f1dc16ac30cde313220 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143661824) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4200) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong commented on issue #10803: [FLINK-15518][web]: don not hide web frontend side pane automatically

Posted by GitBox <gi...@apache.org>.
wuchong commented on issue #10803: [FLINK-15518][web]: don not hide web frontend side pane automatically
URL: https://github.com/apache/flink/pull/10803#issuecomment-572515158
 
 
   Thanks @vthinkxie , great job! 
   I built and verified in my local machine and it works as expected. So +1 from user side. 
   
   But I'm not familiar with the frontend code, so would be great to have +1 from a committer who is familiar with the code and merge it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong merged pull request #10803: [FLINK-15518][web]: don not hide web frontend side pane automatically

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #10803: [FLINK-15518][web]: don not hide web frontend side pane automatically
URL: https://github.com/apache/flink/pull/10803
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] aljoscha commented on issue #10803: [FLINK-15518][web]: don not hide web frontend side pane automatically

Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #10803: [FLINK-15518][web]: don not hide web frontend side pane automatically
URL: https://github.com/apache/flink/pull/10803#issuecomment-572562611
 
 
   @wuchong I think you are as familiar as any commiter with the web frontend code, meaning that no one is really familiar. 😅 
   
   The code looks good, though, and if it does what we want I think this is good to merge!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10803: [FLINK-15518][web]: don not hide web frontend side pane automatically

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10803: [FLINK-15518][web]: don not hide web frontend side pane automatically
URL: https://github.com/apache/flink/pull/10803#issuecomment-572348603
 
 
   <!--
   Meta data
   Hash:0807678093dc557042e46f1dc16ac30cde313220 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143661824 TriggerType:PUSH TriggerID:0807678093dc557042e46f1dc16ac30cde313220
   Hash:0807678093dc557042e46f1dc16ac30cde313220 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4200 TriggerType:PUSH TriggerID:0807678093dc557042e46f1dc16ac30cde313220
   -->
   ## CI report:
   
   * 0807678093dc557042e46f1dc16ac30cde313220 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143661824) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4200) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10803: [FLINK-15518][web]: don not hide web frontend side pane automatically

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10803: [FLINK-15518][web]: don not hide web frontend side pane automatically
URL: https://github.com/apache/flink/pull/10803#issuecomment-572346672
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 0807678093dc557042e46f1dc16ac30cde313220 (Thu Jan 09 02:03:40 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15518).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10803: [FLINK-15518][web]: don not hide web frontend side pane automatically

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10803: [FLINK-15518][web]: don not hide web frontend side pane automatically
URL: https://github.com/apache/flink/pull/10803#issuecomment-572348603
 
 
   <!--
   Meta data
   Hash:0807678093dc557042e46f1dc16ac30cde313220 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:0807678093dc557042e46f1dc16ac30cde313220
   -->
   ## CI report:
   
   * 0807678093dc557042e46f1dc16ac30cde313220 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10803: [FLINK-15518][web]: don not hide web frontend side pane automatically

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10803: [FLINK-15518][web]: don not hide web frontend side pane automatically
URL: https://github.com/apache/flink/pull/10803#issuecomment-572348603
 
 
   <!--
   Meta data
   Hash:0807678093dc557042e46f1dc16ac30cde313220 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143661824 TriggerType:PUSH TriggerID:0807678093dc557042e46f1dc16ac30cde313220
   Hash:0807678093dc557042e46f1dc16ac30cde313220 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4200 TriggerType:PUSH TriggerID:0807678093dc557042e46f1dc16ac30cde313220
   -->
   ## CI report:
   
   * 0807678093dc557042e46f1dc16ac30cde313220 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143661824) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4200) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong commented on issue #10803: [FLINK-15518][web]: don not hide web frontend side pane automatically

Posted by GitBox <gi...@apache.org>.
wuchong commented on issue #10803: [FLINK-15518][web]: don not hide web frontend side pane automatically
URL: https://github.com/apache/flink/pull/10803#issuecomment-572570762
 
 
   Thanks @aljoscha 😅
   I will merge this PR then. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] aljoscha commented on issue #10803: [FLINK-15518][web]: don not hide web frontend side pane automatically

Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #10803: [FLINK-15518][web]: don not hide web frontend side pane automatically
URL: https://github.com/apache/flink/pull/10803#issuecomment-572562860
 
 
   Also, thanks for the fix @vthinkxie! 🍵 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services