You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/05/10 20:40:34 UTC
[GitHub] [kafka] mumrah commented on a diff in pull request #12062: KAFKA-13833: Remove the min_version_level from the finalized version written to ZooKeeper
mumrah commented on code in PR #12062:
URL: https://github.com/apache/kafka/pull/12062#discussion_r869578975
##########
core/src/main/scala/kafka/server/ApiVersionManager.scala:
##########
@@ -86,15 +86,15 @@ class DefaultApiVersionManager(
throttleTimeMs,
interBrokerProtocolVersion.highestSupportedRecordVersion,
supportedFeatures,
- finalizedFeatures.features,
+ finalizedFeatures.features.map(kv => (kv._1, kv._2.asInstanceOf[java.lang.Short])).asJava,
Review Comment:
Is this just needed to convert the Scala short to Java short in the map?
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -148,7 +148,10 @@ public enum MetadataVersion {
IBP_3_1_IV0(3, "3.1", "IV0"),
// Support for leader recovery for unclean leader election (KIP-704)
- IBP_3_2_IV0(4, "3.2", "IV0");
+ IBP_3_2_IV0(4, "3.2", "IV0"),
+
+ // Removes min_version_level from the finalized version range that is written to ZooKeeper
+ IBP_3_2_IV1(5, "3.2", "IV1");
Review Comment:
Should this be 3.3-IV0 since we're on the 3.3 release now? (i.e., current build version is 3.3-SNAPSHOT)
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -148,7 +148,10 @@ public enum MetadataVersion {
IBP_3_1_IV0(3, "3.1", "IV0"),
// Support for leader recovery for unclean leader election (KIP-704)
- IBP_3_2_IV0(4, "3.2", "IV0");
+ IBP_3_2_IV0(4, "3.2", "IV0"),
+
+ // Removes min_version_level from the finalized version range that is written to ZooKeeper
Review Comment:
Can you add a mention of the KIP here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org