You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/13 14:45:40 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #777: Fix typos in
comments
yamt opened a new pull request #777: Fix typos in comments
URL: https://github.com/apache/incubator-nuttx/pull/777
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#777: Fix typos in comments
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #777: Fix typos in comments
URL: https://github.com/apache/incubator-nuttx/pull/777#discussion_r407592739
##########
File path: include/nuttx/fs/fs.h
##########
@@ -179,7 +179,8 @@
* the open method will redirect to another driver and return a file
* descriptor instead.
*
- * This case is when SUSv1 pseudo-terminals are used (CONFIG_PSEUDOTERM_SUSV1=y).
+ * This case is when SUSv1 pseudo-terminals are usedi
Review comment:
I will fix that. License header should be changed too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #777: Fix typos in comments
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #777: Fix typos in comments
URL: https://github.com/apache/incubator-nuttx/pull/777#discussion_r407585666
##########
File path: include/nuttx/fs/fs.h
##########
@@ -179,7 +179,8 @@
* the open method will redirect to another driver and return a file
* descriptor instead.
*
- * This case is when SUSv1 pseudo-terminals are used (CONFIG_PSEUDOTERM_SUSV1=y).
+ * This case is when SUSv1 pseudo-terminals are usedi
Review comment:
usedi->used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#777: Fix typos in comments
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #777: Fix typos in comments
URL: https://github.com/apache/incubator-nuttx/pull/777#discussion_r407592739
##########
File path: include/nuttx/fs/fs.h
##########
@@ -179,7 +179,8 @@
* the open method will redirect to another driver and return a file
* descriptor instead.
*
- * This case is when SUSv1 pseudo-terminals are used (CONFIG_PSEUDOTERM_SUSV1=y).
+ * This case is when SUSv1 pseudo-terminals are usedi
Review comment:
I will fix that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#777: Fix typos in comments
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #777: Fix typos in comments
URL: https://github.com/apache/incubator-nuttx/pull/777#discussion_r407590791
##########
File path: include/nuttx/fs/fs.h
##########
@@ -179,7 +179,8 @@
* the open method will redirect to another driver and return a file
* descriptor instead.
*
- * This case is when SUSv1 pseudo-terminals are used (CONFIG_PSEUDOTERM_SUSV1=y).
+ * This case is when SUSv1 pseudo-terminals are usedi
Review comment:
That happens when I use vim. i = INSERT mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #777:
Fix typos in comments
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #777: Fix typos in comments
URL: https://github.com/apache/incubator-nuttx/pull/777#discussion_r407864244
##########
File path: include/nuttx/fs/fs.h
##########
@@ -179,7 +179,8 @@
* the open method will redirect to another driver and return a file
* descriptor instead.
*
- * This case is when SUSv1 pseudo-terminals are used (CONFIG_PSEUDOTERM_SUSV1=y).
+ * This case is when SUSv1 pseudo-terminals are usedi
Review comment:
oops, sorry.
yes, i'm using vi. and my "i" key has a bad chattering. i plan to fix the keyboard.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #777: Fix typos in
comments
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #777: Fix typos in comments
URL: https://github.com/apache/incubator-nuttx/pull/777
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#777: Fix typos in comments
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #777: Fix typos in comments
URL: https://github.com/apache/incubator-nuttx/pull/777#discussion_r407594448
##########
File path: include/nuttx/fs/fs.h
##########
@@ -179,7 +179,8 @@
* the open method will redirect to another driver and return a file
* descriptor instead.
*
- * This case is when SUSv1 pseudo-terminals are used (CONFIG_PSEUDOTERM_SUSV1=y).
+ * This case is when SUSv1 pseudo-terminals are usedi
Review comment:
See PR #778
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services