You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2019/02/12 06:13:52 UTC

[GitHub] qiuchenjian commented on a change in pull request #3124: [CARBONDATA-3290] No need to apply MVAnalyzerRule for Command

qiuchenjian commented on a change in pull request #3124: [CARBONDATA-3290] No need to apply MVAnalyzerRule for Command
URL: https://github.com/apache/carbondata/pull/3124#discussion_r255814848
 
 

 ##########
 File path: integration/spark2/src/main/commonTo2.2And2.3/org/apache/spark/sql/hive/CarbonAnalyzer.scala
 ##########
 @@ -42,10 +42,10 @@ class CarbonAnalyzer(catalog: SessionCatalog,
     var logicalPlan = analyzer.execute(plan)
     logicalPlan = CarbonPreAggregateDataLoadingRules(sparkSession).apply(logicalPlan)
     logicalPlan = CarbonPreAggregateQueryRules(sparkSession).apply(logicalPlan)
-    if (mvPlan != null) {
+    if (mvPlan != null && !logicalPlan.isInstanceOf[Command]) {
 
 Review comment:
   does command also need CarbonPreAggregateQueryRules?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services